Re: [PATCH]: Make Linux use the new unified x86 watchpoint support

[Michael Snyder <msnyder@cygnus.com>]

Eli Zaretskii wrote:
> 
> On Tue, 27 Mar 2001, Michael Snyder wrote:
> > There is a
> > call to STOPPED_BY_WATCHPOINT in wait_for_inferior, and
> > you can't even connect to the target without wait_for_inferior
> > being called.
> 
> Actually, that call to STOPPED_BY_WATCHPOINT is IMHO totally bogus: no
> one looks at the result it returns, and I have yet to see any
> implementation of watchpoints that needs that call.

I agree, I think it's bogus too, but we would need to trace back
its history or at least analyze it more carefully than I have done.


> I'm guessing that this call goes back to the implementation for
> Sparclite, which uses this call to produce a side effect (to be able
> to step over the instruction which caused the watchpoint to trigger),
> see config/sparc/tm-sparclite.h.  Since this seems to be the only
> platform which needs a side effect, and since we already have an
> equivalent mechanism for doing the same, with the HAVE_*_WATCHPOINT
> macros, I think this call can be removed.

I'd like to see it removed, but I'm chicken.  ;-)