* RFA: Obvious fix to remote-rdp.c ?
@ 2001-03-27 9:11 Nick Clifton
2001-03-27 9:20 ` Fernando Nasser
2001-03-27 11:52 ` Michael Snyder
0 siblings, 2 replies; 3+ messages in thread
From: Nick Clifton @ 2001-03-27 9:11 UTC (permalink / raw)
To: gdb-patches
Hi Guys,
I think that the following patch ought to be covered under the
obvious fix rule, but since I am not a maintainer, I am seeking
approval before committing it.
Cheers
Nick
2001-03-27 Nick Clifton <nickc@redhat.com>
* remote-rdp.c (rdp_set_command_line): Add missing double quote.
Index: remote-rdp.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-rdp.c,v
retrieving revision 1.14
diff -p -r1.14 remote-rdp.c
*** remote-rdp.c 2001/03/20 01:37:09 1.14
--- remote-rdp.c 2001/03/27 17:08:12
*************** rdp_set_command_line (char *command, cha
*** 699,705 ****
if (commandline != NULL)
xfree (commandline);
! xasprintf (&commandline, %s %s", command, args);
}
static void
--- 699,705 ----
if (commandline != NULL)
xfree (commandline);
! xasprintf (&commandline, "%s %s", command, args);
}
static void
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: RFA: Obvious fix to remote-rdp.c ?
2001-03-27 9:11 RFA: Obvious fix to remote-rdp.c ? Nick Clifton
@ 2001-03-27 9:20 ` Fernando Nasser
2001-03-27 11:52 ` Michael Snyder
1 sibling, 0 replies; 3+ messages in thread
From: Fernando Nasser @ 2001-03-27 9:20 UTC (permalink / raw)
To: Nick Clifton; +Cc: gdb-patches
Thank you Nick.
Please check it in.
Fernando
Nick Clifton wrote:
>
> Hi Guys,
>
> I think that the following patch ought to be covered under the
> obvious fix rule, but since I am not a maintainer, I am seeking
> approval before committing it.
>
> Cheers
> Nick
>
> 2001-03-27 Nick Clifton <nickc@redhat.com>
>
> * remote-rdp.c (rdp_set_command_line): Add missing double quote.
>
> Index: remote-rdp.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/remote-rdp.c,v
> retrieving revision 1.14
> diff -p -r1.14 remote-rdp.c
> *** remote-rdp.c 2001/03/20 01:37:09 1.14
> --- remote-rdp.c 2001/03/27 17:08:12
> *************** rdp_set_command_line (char *command, cha
> *** 699,705 ****
> if (commandline != NULL)
> xfree (commandline);
>
> ! xasprintf (&commandline, %s %s", command, args);
> }
>
> static void
> --- 699,705 ----
> if (commandline != NULL)
> xfree (commandline);
>
> ! xasprintf (&commandline, "%s %s", command, args);
> }
>
> static void
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: RFA: Obvious fix to remote-rdp.c ?
2001-03-27 9:11 RFA: Obvious fix to remote-rdp.c ? Nick Clifton
2001-03-27 9:20 ` Fernando Nasser
@ 2001-03-27 11:52 ` Michael Snyder
1 sibling, 0 replies; 3+ messages in thread
From: Michael Snyder @ 2001-03-27 11:52 UTC (permalink / raw)
To: Nick Clifton; +Cc: gdb-patches
Nick Clifton wrote:
>
> Hi Guys,
>
> I think that the following patch ought to be covered under the
> obvious fix rule, but since I am not a maintainer, I am seeking
> approval before committing it.
I agree -- please commit it.
>
> Cheers
> Nick
>
> 2001-03-27 Nick Clifton <nickc@redhat.com>
>
> * remote-rdp.c (rdp_set_command_line): Add missing double quote.
>
> Index: remote-rdp.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/remote-rdp.c,v
> retrieving revision 1.14
> diff -p -r1.14 remote-rdp.c
> *** remote-rdp.c 2001/03/20 01:37:09 1.14
> --- remote-rdp.c 2001/03/27 17:08:12
> *************** rdp_set_command_line (char *command, cha
> *** 699,705 ****
> if (commandline != NULL)
> xfree (commandline);
>
> ! xasprintf (&commandline, %s %s", command, args);
> }
>
> static void
> --- 699,705 ----
> if (commandline != NULL)
> xfree (commandline);
>
> ! xasprintf (&commandline, "%s %s", command, args);
> }
>
> static void
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-03-27 11:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-03-27 9:11 RFA: Obvious fix to remote-rdp.c ? Nick Clifton
2001-03-27 9:20 ` Fernando Nasser
2001-03-27 11:52 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox