* testsuite fix for remote targets
@ 2001-03-15 9:57 Mark Salter
2001-03-15 10:38 ` Fernando Nasser
2001-03-15 11:23 ` Michael Snyder
0 siblings, 2 replies; 3+ messages in thread
From: Mark Salter @ 2001-03-15 9:57 UTC (permalink / raw)
To: gdb-patches
This change:
* config/monitor.exp (gdb_target_cmd): Abstracts some of the
code from gdb_target_monitor, so it can be used independantly
for gdbserver.
apparently broke some remote targets. I'm not sure how this worked at
all, but following is a simple patch that fixes the problem I'm seeing.
--Mark
gdb/testsuite/ChangeLog:
2001-03-15 Mark Salter <msalter@redhat.com>
* config/monitor.exp (gdb_target_cmd): Add explicit error return.
(gdb_target_monitor): Add check of gdb_target_cmd return value.
Index: gdb/testsuite/config/monitor.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/config/monitor.exp,v
retrieving revision 1.3
diff -u -p -5 -r1.3 monitor.exp
--- gdb/testsuite/config/monitor.exp 2001/03/06 08:21:48 1.3
+++ gdb/testsuite/config/monitor.exp 2001/03/15 17:41:35
@@ -65,10 +65,11 @@ proc gdb_target_cmd { targetname serialp
send_gdb "\x03";
break
}
}
}
+ return 1
}
#
@@ -107,11 +108,11 @@ proc gdb_target_monitor { exec_file } {
}
for {set j 1} {$j <= 2} {incr j} {
if [gdb_file_cmd $exec_file] { return -1; }
- gdb_target_cmd $targetname $serialport;
+ if ![gdb_target_cmd $targetname $serialport] { return 0; }
gdb_target_exec;
if { $j == 1 && ![reboot_target] } {
break;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: testsuite fix for remote targets
2001-03-15 9:57 testsuite fix for remote targets Mark Salter
@ 2001-03-15 10:38 ` Fernando Nasser
2001-03-15 11:23 ` Michael Snyder
1 sibling, 0 replies; 3+ messages in thread
From: Fernando Nasser @ 2001-03-15 10:38 UTC (permalink / raw)
To: Mark Salter; +Cc: gdb-patches
Thanks Mark.
Please check it in.
Fernando
Mark Salter wrote:
>
> This change:
>
> * config/monitor.exp (gdb_target_cmd): Abstracts some of the
> code from gdb_target_monitor, so it can be used independantly
> for gdbserver.
>
> apparently broke some remote targets. I'm not sure how this worked at
> all, but following is a simple patch that fixes the problem I'm seeing.
>
> --Mark
>
> gdb/testsuite/ChangeLog:
>
> 2001-03-15 Mark Salter <msalter@redhat.com>
>
> * config/monitor.exp (gdb_target_cmd): Add explicit error return.
> (gdb_target_monitor): Add check of gdb_target_cmd return value.
>
> Index: gdb/testsuite/config/monitor.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/config/monitor.exp,v
> retrieving revision 1.3
> diff -u -p -5 -r1.3 monitor.exp
> --- gdb/testsuite/config/monitor.exp 2001/03/06 08:21:48 1.3
> +++ gdb/testsuite/config/monitor.exp 2001/03/15 17:41:35
> @@ -65,10 +65,11 @@ proc gdb_target_cmd { targetname serialp
> send_gdb "\x03";
> break
> }
> }
> }
> + return 1
> }
>
>
>
> #
> @@ -107,11 +108,11 @@ proc gdb_target_monitor { exec_file } {
> }
>
> for {set j 1} {$j <= 2} {incr j} {
> if [gdb_file_cmd $exec_file] { return -1; }
>
> - gdb_target_cmd $targetname $serialport;
> + if ![gdb_target_cmd $targetname $serialport] { return 0; }
>
> gdb_target_exec;
>
> if { $j == 1 && ![reboot_target] } {
> break;
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: testsuite fix for remote targets
2001-03-15 9:57 testsuite fix for remote targets Mark Salter
2001-03-15 10:38 ` Fernando Nasser
@ 2001-03-15 11:23 ` Michael Snyder
1 sibling, 0 replies; 3+ messages in thread
From: Michael Snyder @ 2001-03-15 11:23 UTC (permalink / raw)
To: Mark Salter; +Cc: gdb-patches
Mark Salter wrote:
>
> This change:
>
> * config/monitor.exp (gdb_target_cmd): Abstracts some of the
> code from gdb_target_monitor, so it can be used independantly
> for gdbserver.
>
> apparently broke some remote targets. I'm not sure how this worked at
> all, but following is a simple patch that fixes the problem I'm seeing.
Speaking as the author of the offending change -- approved.
Please check it in.
>
> --Mark
>
> gdb/testsuite/ChangeLog:
>
> 2001-03-15 Mark Salter <msalter@redhat.com>
>
> * config/monitor.exp (gdb_target_cmd): Add explicit error return.
> (gdb_target_monitor): Add check of gdb_target_cmd return value.
>
> Index: gdb/testsuite/config/monitor.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/config/monitor.exp,v
> retrieving revision 1.3
> diff -u -p -5 -r1.3 monitor.exp
> --- gdb/testsuite/config/monitor.exp 2001/03/06 08:21:48 1.3
> +++ gdb/testsuite/config/monitor.exp 2001/03/15 17:41:35
> @@ -65,10 +65,11 @@ proc gdb_target_cmd { targetname serialp
> send_gdb "\x03";
> break
> }
> }
> }
> + return 1
> }
>
>
>
> #
> @@ -107,11 +108,11 @@ proc gdb_target_monitor { exec_file } {
> }
>
> for {set j 1} {$j <= 2} {incr j} {
> if [gdb_file_cmd $exec_file] { return -1; }
>
> - gdb_target_cmd $targetname $serialport;
> + if ![gdb_target_cmd $targetname $serialport] { return 0; }
>
> gdb_target_exec;
>
> if { $j == 1 && ![reboot_target] } {
> break;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-03-15 11:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-03-15 9:57 testsuite fix for remote targets Mark Salter
2001-03-15 10:38 ` Fernando Nasser
2001-03-15 11:23 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox