From: Andrew Cagney <ac131313@cygnus.com>
To: Fernando Nasser <fnasser@redhat.com>
Cc: gdb-patches@sources.redhat.com, Nick Clifton <nickc@cygnus.com>
Subject: Re: RFA: [buildsym.c] Turn off unused addr bits in linetable
Date: Tue, 13 Mar 2001 08:52:00 -0000 [thread overview]
Message-ID: <3AAE3502.BFFE90D2@cygnus.com> (raw)
In-Reply-To: <3AAD70B6.A9C16F36@redhat.com>
Fernando Nasser wrote:
>
> Some systems like ARM may have extra bits set in the address to indicate
> a mode or something else (the LSB=1 means thumb mode for ARM).
>
> So, before storing line number addresses we may need to turn this bits
> off as they may be passed to gdb with the bits on as result of
> relocation (ld has no way of knowing it is for a line table entry).
>
> The following patch passes the line addresses through the target
> dependent macro ADDR_BITS_REMOVE() before storing it on the table.
>
> OK to commit?
>
> ChangeLog:
>
> * buildsym.c (record_line): Turn off unused addr bits.
I'm not sure about this. The ARM has two ways of identifying THUMB code
- the LSB and a tacky symbol lookup.
Others, such as MIPS/MIPS16 don't. I'm not sure how this will affect
that target. Does the code that uses this address of line also ``turn
off unused addr bits''?
Andrew
next prev parent reply other threads:[~2001-03-13 8:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-12 17:01 Fernando Nasser
2001-03-12 17:11 ` Michael Snyder
2001-03-13 8:52 ` Andrew Cagney [this message]
2001-03-13 9:21 ` Fernando Nasser
2001-03-15 16:27 ` Fernando Nasser
2001-03-15 17:58 ` Andrew Cagney
2001-04-01 17:37 ` Elena Zannoni
2001-04-06 6:23 ` Fernando Nasser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AAE3502.BFFE90D2@cygnus.com \
--to=ac131313@cygnus.com \
--cc=fnasser@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=nickc@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox