From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Fernando Nasser Cc: gdb-patches@sources.redhat.com, Nick Clifton Subject: Re: RFA: [buildsym.c] Turn off unused addr bits in linetable Date: Tue, 13 Mar 2001 08:52:00 -0000 Message-id: <3AAE3502.BFFE90D2@cygnus.com> References: <3AAD70B6.A9C16F36@redhat.com> X-SW-Source: 2001-03/msg00190.html Fernando Nasser wrote: > > Some systems like ARM may have extra bits set in the address to indicate > a mode or something else (the LSB=1 means thumb mode for ARM). > > So, before storing line number addresses we may need to turn this bits > off as they may be passed to gdb with the bits on as result of > relocation (ld has no way of knowing it is for a line table entry). > > The following patch passes the line addresses through the target > dependent macro ADDR_BITS_REMOVE() before storing it on the table. > > OK to commit? > > ChangeLog: > > * buildsym.c (record_line): Turn off unused addr bits. I'm not sure about this. The ARM has two ways of identifying THUMB code - the LSB and a tacky symbol lookup. Others, such as MIPS/MIPS16 don't. I'm not sure how this will affect that target. Does the code that uses this address of line also ``turn off unused addr bits''? Andrew