Completion in "set history filename"

Completion in "set history filename"

[Eli Zaretskii]

One more command which didn't complete as God intended...

Okay to commit?

2001-03-04  Eli Zaretskii  <eliz@is.elta.co.il>

	* top.c (init_main): Make `set history filename' complete on file
	names.

--- gdb/top.c~0	Thu Jan 25 17:19:30 2001
+++ gdb/top.c	Sun Mar  4 19:21:10 2001
@@ -2080,11 +2080,12 @@ ie. the number of previous commands to k
   add_show_from_set (c, &showhistlist);
   c->function.sfunc = set_history_size_command;
 
-  add_show_from_set
-    (add_set_cmd ("filename", no_class, var_filename, (char *) &history_filename,
-		  "Set the filename in which to record the command history\n\
- (the list of previous commands of which a record is kept).", &sethistlist),
-     &showhistlist);
+  c = add_set_cmd ("filename", no_class, var_filename,
+		   (char *) &history_filename,
+		   "Set the filename in which to record the command history\n\
+ (the list of previous commands of which a record is kept).", &sethistlist);
+  c->completer = filename_completer;
+  add_show_from_set (c, &showhistlist);
 
   add_show_from_set
     (add_set_cmd ("confirm", class_support, var_boolean,

Re: Completion in "set history filename"

[Fernando Nasser]

Eli Zaretskii wrote:
> 
> One more command which didn't complete as God intended...
> 
> Okay to commit?
> 

Sure.  If you find any more of these cases just post and check it in.

Thanks for improving the completion.

Regards,
Fernando



> 2001-03-04  Eli Zaretskii  <eliz@is.elta.co.il>
> 
>         * top.c (init_main): Make `set history filename' complete on file
>         names.
> 
> --- gdb/top.c~0 Thu Jan 25 17:19:30 2001
> +++ gdb/top.c   Sun Mar  4 19:21:10 2001
> @@ -2080,11 +2080,12 @@ ie. the number of previous commands to k
>    add_show_from_set (c, &showhistlist);
>    c->function.sfunc = set_history_size_command;
> 
> -  add_show_from_set
> -    (add_set_cmd ("filename", no_class, var_filename, (char *) &history_filename,
> -                 "Set the filename in which to record the command history\n\
> - (the list of previous commands of which a record is kept).", &sethistlist),
> -     &showhistlist);
> +  c = add_set_cmd ("filename", no_class, var_filename,
> +                  (char *) &history_filename,
> +                  "Set the filename in which to record the command history\n\
> + (the list of previous commands of which a record is kept).", &sethistlist);
> +  c->completer = filename_completer;
> +  add_show_from_set (c, &showhistlist);
> 
>    add_show_from_set
>      (add_set_cmd ("confirm", class_support, var_boolean,

-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9

Re: Completion in "set history filename"

[Eli Zaretskii]

On Tue, 6 Mar 2001, Fernando Nasser wrote:

> Eli Zaretskii wrote:
> > 
> > One more command which didn't complete as God intended...
> > 
> > Okay to commit?
> > 
> 
> Sure.

Committed.

> If you find any more of these cases just post and check it in.

Will do.

Re: Completion in "set history filename"

[Elena Zannoni]

Did I ever reply to this?
I don't think I did, sorry.
Looks ok to me, please check it in.

Thanks
Elena

Eli Zaretskii writes:
 > One more command which didn't complete as God intended...
 > 
 > Okay to commit?
 > 
 > 2001-03-04  Eli Zaretskii  <eliz@is.elta.co.il>
 > 
 > 	* top.c (init_main): Make `set history filename' complete on file
 > 	names.
 > 
 > --- gdb/top.c~0	Thu Jan 25 17:19:30 2001
 > +++ gdb/top.c	Sun Mar  4 19:21:10 2001
 > @@ -2080,11 +2080,12 @@ ie. the number of previous commands to k
 >    add_show_from_set (c, &showhistlist);
 >    c->function.sfunc = set_history_size_command;
 >  
 > -  add_show_from_set
 > -    (add_set_cmd ("filename", no_class, var_filename, (char *) &history_filename,
 > -		  "Set the filename in which to record the command history\n\
 > - (the list of previous commands of which a record is kept).", &sethistlist),
 > -     &showhistlist);
 > +  c = add_set_cmd ("filename", no_class, var_filename,
 > +		   (char *) &history_filename,
 > +		   "Set the filename in which to record the command history\n\
 > + (the list of previous commands of which a record is kept).", &sethistlist);
 > +  c->completer = filename_completer;
 > +  add_show_from_set (c, &showhistlist);
 >  
 >    add_show_from_set
 >      (add_set_cmd ("confirm", class_support, var_boolean,
 > 

Re: Completion in "set history filename"

[Eli Zaretskii]

On Fri, 11 May 2001, Elena Zannoni wrote:

> Did I ever reply to this?
> I don't think I did, sorry.
> Looks ok to me, please check it in.

It's in the CVS since 7 March.  So either you did approve it, or someone
else did (or I just goofed and committed it without seeing an approval ;-).

Re: Completion in "set history filename"

[Elena Zannoni]

Eli Zaretskii writes:
 > 
 > On Fri, 11 May 2001, Elena Zannoni wrote:
 > 
 > > Did I ever reply to this?
 > > I don't think I did, sorry.
 > > Looks ok to me, please check it in.
 > 
 > It's in the CVS since 7 March.  So either you did approve it, or someone
 > else did (or I just goofed and committed it without seeing an approval ;-).
 > 

[After looking at my old mailbox]
I think Fernando did. So it's ok.

Elena