ChangeLog fixes

ChangeLog fixes

[Michael Elizabeth Chastain]

Here is the text of the ChangeLog fixes which I committed today.

For the wildcard expansions, I checked each listed file individually with
"cvs -D ... -D ... $file" to verify that the documented change happened
on the documented date.

Michael

http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog-1997.diff?cvsroot=src&r1=1.1&r2=1.2
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog-1997,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- src/gdb/ChangeLog-1997	2001/01/12 03:44:31	1.1
+++ src/gdb/ChangeLog-1997	2001/03/04 18:44:42	1.2
@@ -2523,7 +2523,7 @@
 
 	* m32r-rom.c: #include <sys/types.h>.
 	#ifdef out new load support if wingdb.
-	* m32r/tm-m32r.h (TARGET_M32R): Define, for wingdb.
+	* config/m32r/tm-m32r.h (TARGET_M32R): Define, for wingdb.
 
 Tue Feb 11 12:28:09 1997  Jeffrey A Law  (law@cygnus.com)
 
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog-1998.diff?cvsroot=src&r1=1.1&r2=1.2
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog-1998,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- src/gdb/ChangeLog-1998	2001/01/12 03:44:31	1.1
+++ src/gdb/ChangeLog-1998	2001/03/04 18:52:48	1.2
@@ -6767,7 +6767,7 @@
 
 Mon Feb 10 12:37:47 1998  Philippe De Muyter  <phdm@macqel.be>
 
-        * m68k/tm-delta68.h (EXTRACT_RETURN_VALUE): Type argument for
+        * config/m68k/tm-delta68.h (EXTRACT_RETURN_VALUE): Type argument for
         `REGISTER_CONVERT_TO_VIRTUAL is `TYPE', not
         `REGISTER_VIRTUAL_TYPE (FP0_REGNUM)';
         (STORE_RETURN_VALUE): Ditto, and offset for `write_register_bytes'
@@ -6808,7 +6808,7 @@
 
 Sun Feb  6 02:44:28 1998  Philippe De Muyter  <phdm@macqel.be>
 
-        * m68k/tm-delta68.h (CPLUS_MARKER): Macro deleted.
+        * config/m68k/tm-delta68.h (CPLUS_MARKER): Macro deleted.
         (EXTRACT_STRUCT_VALUE_ADDRESS): Macro defined.
         (EXTRACT_RETURN_VALUE, STORE_RETURN_VALUE): Macros modified
         because floating-point values return via %fp0.

http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.80&r2=1.81
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.80
retrieving revision 1.81
diff -u -r1.80 -r1.81
--- src/gdb/testsuite/ChangeLog	2001/03/01 22:18:45	1.80
+++ src/gdb/testsuite/ChangeLog	2001/03/04 20:26:44	1.81
@@ -2837,9 +2837,67 @@
 
 	* config/vr4300.exp: New file.
 
-	* gdb.*/*.exp: Call gdb_expect instead of expect.
-	
-	* lib/gdb.exp(gdb_expect): New function.
+	* lib/gdb.exp (gdb_expect): New function.
+	* config/m32r-stub.exp: Call gdb_expect instead of expect.
+	* config/monitor.exp: Ditto.
+	* config/netware.exp: Ditto.
+	* config/sim.exp: Ditto.
+	* config/slite.exp: Ditto.
+	* config/sparclet.exp: Ditto.
+	* config/udi.exp: Ditto.
+	* config/vx.exp: Ditto.
+	* gdb.base/a2-run.exp: Ditto.
+	* gdb.base/bitfields.exp: Ditto.
+	* gdb.base/break.exp: Ditto.
+	* gdb.base/callfuncs.exp: Ditto.
+	* gdb.base/commands.exp: Ditto.
+	* gdb.base/corefile.exp: Ditto.
+	* gdb.base/default.exp: Ditto.
+	* gdb.base/funcargs.exp: Ditto.
+	* gdb.base/gdbvars.exp: Ditto.
+	* gdb.base/interrupt.exp: Ditto.
+	* gdb.base/list.exp: Ditto.
+	* gdb.base/ptype.exp: Ditto.
+	* gdb.base/return.exp: Ditto.
+	* gdb.base/scope.exp: Ditto.
+	* gdb.base/setshow.exp: Ditto.
+	* gdb.base/setvar.exp: Ditto.
+	* gdb.base/sigall.exp: Ditto.
+	* gdb.base/signals.exp: Ditto.
+	* gdb.base/structs.exp: Ditto.
+	* gdb.base/term.exp: Ditto.
+	* gdb.base/watchpoint.exp: Ditto.
+	* gdb.c++/classes.exp: Ditto.
+	* gdb.c++/cplusfuncs.exp: Ditto.
+	* gdb.c++/demangle.exp: Ditto.
+	* gdb.c++/inherit.exp: Ditto.
+	* gdb.c++/misc.exp: Ditto.
+	* gdb.c++/templates.exp: Ditto.
+	* gdb.c++/virtfunc.exp: Ditto.
+	* gdb.chill/builtins.exp: Ditto.
+	* gdb.chill/callch.exp: Ditto.
+	* gdb.chill/chexp.exp: Ditto.
+	* gdb.chill/enum.exp: Ditto.
+	* gdb.chill/gch1041.exp: Ditto.
+	* gdb.chill/gch1272.exp: Ditto.
+	* gdb.chill/gch1280.exp: Ditto.
+	* gdb.chill/gch922.exp: Ditto.
+	* gdb.chill/gch981.exp: Ditto.
+	* gdb.chill/misc.exp: Ditto.
+	* gdb.chill/powerset.exp: Ditto.
+	* gdb.chill/pr-5984.exp: Ditto.
+	* gdb.chill/pr-6292.exp: Ditto.
+	* gdb.chill/pr-9946.exp: Ditto.
+	* gdb.chill/tests1.exp: Ditto.
+	* gdb.chill/tests2.exp: Ditto.
+	* gdb.disasm/hppa.exp: Ditto.
+	* gdb.disasm/mn10200.exp: Ditto.
+	* gdb.disasm/sh3.exp: Ditto.
+	* gdb.stabs/weird.exp: Ditto.
+	* gdb.threads/pthreads.exp: Ditto.
+	* gdb.threads/step.exp: Ditto.
+	* gdb.threads/step2.exp: Ditto.
+	* lib/gdb.exp: Ditto.
 
 Thu Feb 20 13:57:01 1997  Bob Manson  <manson@charmed.cygnus.com>
 
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.81&r2=1.82
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.81
retrieving revision 1.82
diff -u -r1.81 -r1.82
--- src/gdb/testsuite/ChangeLog	2001/03/04 20:26:44	1.81
+++ src/gdb/testsuite/ChangeLog	2001/03/04 21:15:17	1.82
@@ -50,7 +50,7 @@
 	(dm_type_unsigned_int): Ditto.
 	(dm_type_void): Ditto.
 	(dm_type_void_star): Ditto.
-	* gdb.base/cplusfuncs.exp (probe_demangler): New function.
+	* gdb.c++/cplusfuncs.exp (probe_demangler): New function.
 	Probe the gdb demangler and set variables to accommodate
 	formatting differences.
 	(info_func_regexp): New function.  Same as info_func, but

http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.82&r2=1.83
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.82
retrieving revision 1.83
diff -u -r1.82 -r1.83
--- src/gdb/testsuite/ChangeLog	2001/03/04 21:15:17	1.82
+++ src/gdb/testsuite/ChangeLog	2001/03/04 21:23:05	1.83
@@ -72,6 +72,28 @@
 
 	* gdb.c++/templates.cc (printf): Remove unused function definition.
 
+2001-01-28  Michael Chastain  <chastain@redhat.com>
+
+	* gdb.c++/ovldbreak.exp (take_gdb_out_of_choice_menu): New proc
+	to call when tests fail.  It takes gdb out of the overloaded
+	function choice menu back to the main prompt, so that the test
+	program stays synchronized.
+	(set_bp_overloaded): New proc to collect all the common
+	code for setting a breakpoint on an overloaded name.  Calls
+	take_gdb_out_of_choice_menu when needed.
+	(menu_overload1arg): New variable to collect the repeated
+	instances of the expected menu for an overloaded name.  Change
+	the regular expression to handle changes in g++ type encoding:
+	"void" can be either "void" or "", and "unsigned int" can be
+	either "unsigned int" or "unsigned".
+	(continue_to_bp_overloaded): Change regular expressions to handle
+	changes in g++ type encoding.
+	(no proc): Call take_gdb_out_of_choice_menu when needed.
+	Remove redundant calls to "info break".  Accept either "canceled"
+	or "cancelled".  Change regular expressions in "info break"
+	calls to handle changes in g++ type encoding.  Give all tests
+	unique strings.
+
 2001-01-17  Ben Elliston  <bje@redhat.com>
 
 	* config/sid.exp: New file.
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.chill/ChangeLog.diff?cvsroot=src&r1=1.1.1.2&r2=1.2
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.chill/ChangeLog,v
retrieving revision 1.1.1.2
retrieving revision 1.2
diff -u -r1.1.1.2 -r1.2
--- src/gdb/testsuite/gdb.chill/ChangeLog	1999/06/28 16:04:30	1.1.1.2
+++ src/gdb/testsuite/gdb.chill/ChangeLog	2001/03/04 21:41:15	1.2
@@ -10,7 +10,29 @@
 
 Wed Sep 10 15:01:55 1997  Bob Manson  <manson@charmed.cygnus.com>
 
-	* *.exp: The end-all be-all of quoting fixes. Ha.
+	* callch.exp: The end-all be-all of quoting fixes. Ha.
+	* chillvars.exp: Ditto.
+	* gch1272.exp: Ditto.
+	* gch1280.exp: Ditto.
+	* gch922.exp: Ditto.
+	* gch981.exp: Ditto.
+	* pr-4975.exp: Ditto.
+	* pr-5016.exp: Ditto.
+	* pr-5020.exp: Ditto.
+	* pr-5022.exp: Ditto.
+	* pr-5646.exp: Ditto.
+	* pr-5984.exp: Ditto.
+	* pr-6292.exp: Ditto.
+	* pr-6632.exp: Ditto.
+	* pr-8134.exp: Ditto.
+	* pr-8136.exp: Ditto.
+	* pr-8405.exp: Ditto.
+	* pr-8742.exp: Ditto.
+	* pr-8894.exp: Ditto.
+	* pr-9095.exp: Ditto.
+	* result.exp: Ditto.
+	* string.exp: Ditto.
+	* tuples.exp: Ditto.
 
 Thu Aug 21 10:31:23 1997  Bob Manson  <manson@charmed.cygnus.com>
 
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.83&r2=1.84
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.83
retrieving revision 1.84
diff -u -r1.83 -r1.84
--- src/gdb/testsuite/ChangeLog	2001/03/04 21:23:05	1.83
+++ src/gdb/testsuite/ChangeLog	2001/03/04 22:08:49	1.84
@@ -2491,9 +2491,48 @@
 	* gdb.base/overlays.exp: Preliminary fixes; temporarily disabled
  	until it has been modified to work with the new testsuite.
 
-	* gdb.*/*.exp: Instead of causing 1 unresolved test when the
+	* lib/gdb.exp: Instead of causing 1 unresolved test when the
  	testcase won't compile, cause all of the testcases in the file to
  	fail instead.
+	* gdb.base/a2-run.exp: Ditto
+	* gdb.base/bitfields.exp: Ditto
+	* gdb.base/break.exp: Ditto
+	* gdb.base/callfuncs.exp: Ditto
+	* gdb.base/commands.exp: Ditto
+	* gdb.base/corefile.exp: Ditto
+	* gdb.base/exprs.exp: Ditto
+	* gdb.base/funcargs.exp: Ditto
+	* gdb.base/interrupt.exp: Ditto
+	* gdb.base/langs.exp: Ditto
+	* gdb.base/list.exp: Ditto
+	* gdb.base/mips_pro.exp: Ditto
+	* gdb.base/nodebug.exp: Ditto
+	* gdb.base/opaque.exp: Ditto
+	* gdb.base/overlays.exp: Ditto
+	* gdb.base/printcmds.exp: Ditto
+	* gdb.base/ptype.exp: Ditto
+	* gdb.base/recurse.exp: Ditto
+	* gdb.base/return.exp: Ditto
+	* gdb.base/scope.exp: Ditto
+	* gdb.base/setshow.exp: Ditto
+	* gdb.base/setvar.exp: Ditto
+	* gdb.base/sigall.exp: Ditto
+	* gdb.base/signals.exp: Ditto
+	* gdb.base/structs.exp: Ditto
+	* gdb.base/term.exp: Ditto
+	* gdb.base/twice.exp: Ditto
+	* gdb.base/watchpoint.exp: Ditto
+	* gdb.base/whatis.exp: Ditto
+	* gdb.c++/classes.exp: Ditto
+	* gdb.c++/cplusfuncs.exp: Ditto
+	* gdb.c++/inherit.exp: Ditto
+	* gdb.c++/misc.exp: Ditto
+	* gdb.c++/templates.exp: Ditto
+	* gdb.c++/virtfunc.exp: Ditto
+	* gdb.disasm/mn10200.exp: Ditto
+	* gdb.disasm/mn10300.exp: Ditto
+	* gdb.disasm/sh3.exp: Ditto
+	* gdb.stabs/weird.exp: Ditto
 
 	* lib/gdb.exp(gdb_suppress_entire_file): New procedure.
 	(gdb_clear_suppressed): New procedure.

http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.84&r2=1.85
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.84
retrieving revision 1.85
diff -u -r1.84 -r1.85
--- src/gdb/testsuite/ChangeLog	2001/03/04 22:08:49	1.84
+++ src/gdb/testsuite/ChangeLog	2001/03/04 22:23:30	1.85
@@ -3131,7 +3131,55 @@
 
 Sat Feb  1 23:51:01 1997  Bob Manson  <manson@charmed.cygnus.com>
 
-	* gdb.*/*.exp: Replace $prompt with $gdb_prompt.
+	* lib/gdb.exp: Replace $prompt with $gdb_prompt.
+	* config/gdbserver.exp: Ditto.
+	* config/m32r-stub.exp: Ditto.
+	* config/monitor.exp: Ditto.
+	* config/netware.exp: Ditto.
+	* config/nind.exp: Ditto.
+	* config/sim.exp: Ditto.
+	* config/slite.exp: Ditto.
+	* config/sparclet.exp: Ditto.
+	* config/udi.exp: Ditto.
+	* config/vx.exp: Ditto.
+	* gdb.base/a2-run.exp: Ditto.
+	* gdb.base/bitfields.exp: Ditto.
+	* gdb.base/break.exp: Ditto.
+	* gdb.base/callfuncs.exp: Ditto.
+	* gdb.base/commands.exp: Ditto.
+	* gdb.base/corefile.exp: Ditto.
+	* gdb.base/default.exp: Ditto.
+	* gdb.base/funcargs.exp: Ditto.
+	* gdb.base/gdbvars.exp: Ditto.
+	* gdb.base/help.exp: Ditto.
+	* gdb.base/interrupt.exp: Ditto.
+	* gdb.base/list.exp: Ditto.
+	* gdb.base/printcmds.exp: Ditto.
+	* gdb.base/ptype.exp: Ditto.
+	* gdb.base/return.exp: Ditto.
+	* gdb.base/scope.exp: Ditto.
+	* gdb.base/setshow.exp: Ditto.
+	* gdb.base/setvar.exp: Ditto.
+	* gdb.base/sigall.exp: Ditto.
+	* gdb.base/signals.exp: Ditto.
+	* gdb.base/structs.exp: Ditto.
+	* gdb.base/term.exp: Ditto.
+	* gdb.base/watchpoint.exp: Ditto.
+	* gdb.c++/classes.exp: Ditto.
+	* gdb.c++/cplusfuncs.exp: Ditto.
+	* gdb.c++/demangle.exp: Ditto.
+	* gdb.c++/inherit.exp: Ditto.
+	* gdb.c++/misc.exp: Ditto.
+	* gdb.c++/templates.exp: Ditto.
+	* gdb.c++/virtfunc.exp: Ditto.
+	* gdb.disasm/hppa.exp: Ditto.
+	* gdb.disasm/sh3.exp: Ditto.
+	* gdb.fortran/exprs.exp: Ditto.
+	* gdb.fortran/types.exp: Ditto.
+	* gdb.stabs/weird.exp: Ditto.
+	* gdb.threads/pthreads.exp: Ditto.
+	* gdb.threads/step.exp: Ditto.
+	* gdb.threads/step2.exp: Ditto.
 	
 	* gdb.base/scope.exp: Use gdb_test.
 	* gdb.c++/classes.exp: Ditto.

Re: ChangeLog fixes

[Andrew Cagney]

Michael,

I look on this as rewriting history.

Fixing, very recent ChangeLog entries to comply with current norms makes
sense.  However, rewriting very old change logs that date back to a time
when current standards didn't apply or were applied far more loosely
looks like rewriting history.

	Andrew

Re: ChangeLog fixes

[Andrew Cagney]

> I think Michael's changes are incredibly useful to have, not only for
> my script, but also for those of us who use the ChangeLog files for
> research.  And it may prove to be especially useful to those who do
> not have access to the Red Hat's internal CVS respository.

I don't dispute the usefulness of this information.  However, I don't
think that rewriting old ChangeLogs is the correct way to do it.  The
basic idea behind a ChangeLog is that it is append only - warts,
spelling mistakes, and all.

I find it is the unchanging nature of a ChangeLog that makes it useful
when doing research.

	enjoy,
		Andrew

Re: ChangeLog fixes

[Stan Shebs]

Kevin Buettner wrote:
> 
> For real historians, I would imagine that it's incredibly tricky to
> figure out whether such corrections are a rewriting of history in the
> pejorative sense or are truly accurate corrections.  Our historical
> texts are the ChangeLog entries, and for these, we (or some of us
> anyway) have the luxury of being able to check the veracity of the
> ChangeLog entries by means of the CVS repositories.

I have a little familiarity with what real historians do, and this
process is called "textual editing".  For instance, most of the Greek
and Roman literature exists today only as manuscript copies made by monks,
the oldest of those still a thousand years separated from the originals.
In the worst cases, a monk might not know the language of the text he
was copying and make serious nonsensical mistakes, then the next
monk would try to fix them while making his copy, and so today we end
up with a dozen manuscripts, all inconsistent with each other.  Even
worse, in some cases the mistakes completely change the sense of a
passage, and there are learned papers debating which interpretation
is more plausible, based on context ("internal evidence") or other
documents, archaeology, etc ("external evidence").

> Now to specifics...  The bulk of Michael's ChangeLog fixes concern the
> use of the ``*'' wildcard.  He left the original author's comment the
> same; all he did was expand the ``*'' to list all of those files which
> were actually affected.  As I understand it, he verified the accuracy
> of his rewrites by checking against CVS.

This seems like a reasonable thing, but beware of ChangeLogs that
predate CVS.  Since there are many secret files mentioned in the
internal RH repositories, of necessity he must have done that
additional edit of wildcard expansions as well.  So I think the
change is fine, but as the GNU coding standard mentions, the ChangeLog
is still just an approximation to what actually happened.

Because of the likelihood of compounding errors by rewriting old
ChangeLogs, in general I would recommend resisting the temptation
to try to improve them.  (I've had to hold myself back many times.)

Stan