From: Andrew Cagney <ac131313@cygnus.com>
To: Daniel Berlin <dberlin@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Start abstraction of C++ abi's
Date: Mon, 19 Feb 2001 13:36:00 -0000 [thread overview]
Message-ID: <3A91916B.37B26DED@cygnus.com> (raw)
In-Reply-To: <x7n1bi5q61.fsf@dynamic-addr-83-177.resnet.rochester.edu>
Daniel Berlin wrote:
>
> Andrew Cagney <ac131313@cygnus.com> writes:
>
> > Daniel Berlin wrote:
> > >
> > > This patch, plus the attached files, start the abstraction of the C++
> > > ABI's.
> > >
> > > I've started by replacing the simple things, and will incrementally
> > > replace the more complex things, and the things that require real code
> > > changes, as time goes on.
> > >
> > > The cp-abi directory, and it's files, are attached in a gzipped tar file.
> >
> > FYI,
> >
> > Moving stuff into a sub directory is a significant change and should
> > really be discussed separatly - at present the only think in sub
> > directories are UIs. I tend to recommend leaving such cosmetic changes
> > as a latter pass.
I probably phrased this badly. The trick with getting a patch through
quickly is to go over it repeatedly with a fine tooth comb until you've
removed everything that isn't directly related to the intended change.
> It's not moving stuff into a subdir, as it didn't exist before. I'm
> creating it in a subdir. Why is it necessary to have a long discussion
> about creating a directory for a bunch of related files? I'm happy to
> see if anyone objects, but I don't see it as a significant change.
> Maybe this is why it never gets done.
There isn't a necessity for a long discussion however I think it is
reasonable for me to ask you to explaine the rationale behind the
introduction of a new directory. Remember, you're putting in place
conventions that will last a very long time - it is important to get
them reasonably right first up.
If it were me doing this work, I would have broken it down into several
stages:
o create cp-abi.[hc]
Here, the only thing
anyone could possibly object
to is the name :-)
o re-structure language
directories
I'd be seeking idea's from all
the players (C, Pascal, O-C,
et.al.)
enjoy,
Andrew
next prev parent reply other threads:[~2001-02-19 13:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-18 12:51 Daniel Berlin
2001-02-18 22:52 ` Eli Zaretskii
2001-02-19 0:02 ` Daniel Berlin
2001-02-19 3:06 ` Eli Zaretskii
2001-02-19 6:32 ` Daniel Berlin
2001-02-19 8:48 ` Elena Zannoni
2001-02-19 10:24 ` Daniel Berlin
2001-02-19 11:27 ` Andrew Cagney
2001-02-19 13:17 ` Daniel Berlin
2001-02-19 13:36 ` Andrew Cagney [this message]
2001-02-19 14:58 ` Stan Shebs
2001-02-19 15:13 ` Michael Snyder
2001-02-18 16:09 Michael Elizabeth Chastain
2001-02-18 16:51 ` Daniel Berlin
2001-02-18 16:58 Michael Elizabeth Chastain
2001-02-18 18:05 ` Daniel Berlin
[not found] <200102192211.OAA18590@bosch.cygnus.com>
2001-02-19 14:32 ` Andrew Cagney
2001-02-19 15:01 ` Daniel Berlin
2001-02-19 15:08 Michael Elizabeth Chastain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A91916B.37B26DED@cygnus.com \
--to=ac131313@cygnus.com \
--cc=dberlin@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox