From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Daniel Berlin Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Start abstraction of C++ abi's Date: Mon, 19 Feb 2001 13:36:00 -0000 Message-id: <3A91916B.37B26DED@cygnus.com> References: <3A917341.BDA8781B@cygnus.com> X-SW-Source: 2001-02/msg00377.html Daniel Berlin wrote: > > Andrew Cagney writes: > > > Daniel Berlin wrote: > > > > > > This patch, plus the attached files, start the abstraction of the C++ > > > ABI's. > > > > > > I've started by replacing the simple things, and will incrementally > > > replace the more complex things, and the things that require real code > > > changes, as time goes on. > > > > > > The cp-abi directory, and it's files, are attached in a gzipped tar file. > > > > FYI, > > > > Moving stuff into a sub directory is a significant change and should > > really be discussed separatly - at present the only think in sub > > directories are UIs. I tend to recommend leaving such cosmetic changes > > as a latter pass. I probably phrased this badly. The trick with getting a patch through quickly is to go over it repeatedly with a fine tooth comb until you've removed everything that isn't directly related to the intended change. > It's not moving stuff into a subdir, as it didn't exist before. I'm > creating it in a subdir. Why is it necessary to have a long discussion > about creating a directory for a bunch of related files? I'm happy to > see if anyone objects, but I don't see it as a significant change. > Maybe this is why it never gets done. There isn't a necessity for a long discussion however I think it is reasonable for me to ask you to explaine the rationale behind the introduction of a new directory. Remember, you're putting in place conventions that will last a very long time - it is important to get them reasonably right first up. If it were me doing this work, I would have broken it down into several stages: o create cp-abi.[hc] Here, the only thing anyone could possibly object to is the name :-) o re-structure language directories I'd be seeking idea's from all the players (C, Pascal, O-C, et.al.) enjoy, Andrew