From: Michael Snyder <msnyder@cygnus.com>
To: Kevin Buettner <kevinb@cygnus.com>
Cc: gdb-patches@sources.redhat.com, keiths@redhat.com, kevinb@redhat.com
Subject: Re: [RFC] Accomodate 64-bit msymbols in expressions
Date: Fri, 16 Feb 2001 16:32:00 -0000 [thread overview]
Message-ID: <3A8DC6A0.E36D668@cygnus.com> (raw)
In-Reply-To: <1010217003055.ZM12822@ocotillo.lan>
Kevin Buettner wrote:
>
> On Feb 16, 4:03pm, Michael Snyder wrote:
>
> > The following change is motivated by the fact that the addresses of
> > minimal symbols currently get truncated to 32 bits in expressions.
> >
> > Does this look badly wrong to anybody?
>
> Not badly wrong. The only nit that I can pick is...
>
> > ! /* Let's make the type big enough to hold a 64-bit address. */
> > ! write_exp_elt_type (builtin_type_long_long);
>
> ...that it might be preferable to use builtin_type_CORE_ADDR instead.
>
> (I.e, think about what happens if TARGET_LONG_LONG_BIT == 32, but
> TARGET_ADDR_BIT == 64.)
That's a good idea. Thanks.
prev parent reply other threads:[~2001-02-16 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-16 16:04 Michael Snyder
2001-02-16 16:31 ` Kevin Buettner
2001-02-16 16:32 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A8DC6A0.E36D668@cygnus.com \
--to=msnyder@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=keiths@redhat.com \
--cc=kevinb@cygnus.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox