* Re: [rfa] unify some pthreads.exp messages
[not found] <3A820FF8.1FD6E9B4@cygnus.com>
@ 2001-02-09 9:25 ` Michael Snyder
2001-02-09 9:35 ` Fernando Nasser
0 siblings, 1 reply; 2+ messages in thread
From: Michael Snyder @ 2001-02-09 9:25 UTC (permalink / raw)
To: Andrew Cagney; +Cc: GDB Patches
Andrew Cagney wrote:
>
> Hello,
>
> The attatched fixes a few more testsuite messages so that they are
> consistent.
This looks good to me.
>
> Andrew
>
> ---------------------------------------------------------------
> Sun Feb 4 17:32:21 2001 Andrew Cagney <cagney@redhat.com>
>
> * gdb.threads/pthreads.exp: Unify pass/fail messages for
> ``continue to bkpt at common_routine in thread 2'' and ``stopped
> before calling common_routine 15 times'' tests.
>
> Index: gdb.threads/pthreads.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/pthreads.exp,v
> retrieving revision 1.2
> diff -p -r1.2 pthreads.exp
> *** pthreads.exp 2000/04/07 01:14:10 1.2
> --- pthreads.exp 2001/02/08 03:19:56
> *************** proc all_threads_running {} {
> *** 142,150 ****
>
> send_gdb "p common_routine::hits\n"
> gdb_expect {
> ! -re ".*= 15\r\n$gdb_prompt $" {}
> ! -re ".*= 16\r\n$gdb_prompt $" {}
> ! -re ".*= 17\r\n$gdb_prompt $" {}
> default {
> fail "stopped before calling common_routine 15 times"
> return 0
> --- 142,156 ----
>
> send_gdb "p common_routine::hits\n"
> gdb_expect {
> ! -re ".*= 15\r\n$gdb_prompt $" {
> ! pass "stopped before calling common_routine 15 times"
> ! }
> ! -re ".*= 16\r\n$gdb_prompt $" {
> ! pass "stopped before calling common_routine 15 times (16 times)"
> ! }
> ! -re ".*= 17\r\n$gdb_prompt $" {
> ! pass "stopped before calling common_routine 15 times (17 times)"
> ! }
> default {
> fail "stopped before calling common_routine 15 times"
> return 0
> *************** proc check_backtraces {} {
> *** 293,298 ****
> --- 299,305 ----
> send_gdb "continue\n"
> gdb_expect {
> -re "Breakpoint .* common_routine \\(arg=2\\).*" {
> + pass "continue to bkpt at common_routine in thread 2"
> send_gdb "backtrace\n"
> gdb_expect {
> -re "#0.*common_routine \\(arg=2\\).*#1.*thread2.*" {
> *************** proc check_backtraces {} {
> *** 307,322 ****
> }
> }
> -re "Breakpoint .* common_routine \\(arg=0\\).*" {
> ! fail "stopped in main thread at breakpoint for thread 2"
> }
> -re "Breakpoint .* common_routine \\(arg=1\\).*" {
> ! fail "stopped in main thread at breakpoint for thread 1"
> }
> -re ".*$gdb_prompt" {
> fail "continue to bkpt at common_routine in thread 2"
> }
> default {
> ! fail "continue to bkpt at common_routine in thread 2"
> }
> timeout {
> fail "continue to bkpt at common_routine in thread 2 (timeout)"
> --- 314,329 ----
> }
> }
> -re "Breakpoint .* common_routine \\(arg=0\\).*" {
> ! fail "continue to bkpt at common_routine in thread 2 (arg=0)"
> }
> -re "Breakpoint .* common_routine \\(arg=1\\).*" {
> ! fail "continue to bkpt at common_routine in thread 2 (arg=1)"
> }
> -re ".*$gdb_prompt" {
> fail "continue to bkpt at common_routine in thread 2"
> }
> default {
> ! fail "continue to bkpt at common_routine in thread 2 (default)"
> }
> timeout {
> fail "continue to bkpt at common_routine in thread 2 (timeout)"
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [rfa] unify some pthreads.exp messages
2001-02-09 9:25 ` [rfa] unify some pthreads.exp messages Michael Snyder
@ 2001-02-09 9:35 ` Fernando Nasser
0 siblings, 0 replies; 2+ messages in thread
From: Fernando Nasser @ 2001-02-09 9:35 UTC (permalink / raw)
To: Michael Snyder; +Cc: Andrew Cagney, GDB Patches
Michael Snyder wrote:
>
> Andrew Cagney wrote:
> >
> > Hello,
> >
> > The attatched fixes a few more testsuite messages so that they are
> > consistent.
>
> This looks good to me.
>
For me too.
> >
> > Andrew
> >
> > ---------------------------------------------------------------
> > Sun Feb 4 17:32:21 2001 Andrew Cagney <cagney@redhat.com>
> >
> > * gdb.threads/pthreads.exp: Unify pass/fail messages for
> > ``continue to bkpt at common_routine in thread 2'' and ``stopped
> > before calling common_routine 15 times'' tests.
> >
> > Index: gdb.threads/pthreads.exp
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/pthreads.exp,v
> > retrieving revision 1.2
> > diff -p -r1.2 pthreads.exp
> > *** pthreads.exp 2000/04/07 01:14:10 1.2
> > --- pthreads.exp 2001/02/08 03:19:56
> > *************** proc all_threads_running {} {
> > *** 142,150 ****
> >
> > send_gdb "p common_routine::hits\n"
> > gdb_expect {
> > ! -re ".*= 15\r\n$gdb_prompt $" {}
> > ! -re ".*= 16\r\n$gdb_prompt $" {}
> > ! -re ".*= 17\r\n$gdb_prompt $" {}
> > default {
> > fail "stopped before calling common_routine 15 times"
> > return 0
> > --- 142,156 ----
> >
> > send_gdb "p common_routine::hits\n"
> > gdb_expect {
> > ! -re ".*= 15\r\n$gdb_prompt $" {
> > ! pass "stopped before calling common_routine 15 times"
> > ! }
> > ! -re ".*= 16\r\n$gdb_prompt $" {
> > ! pass "stopped before calling common_routine 15 times (16 times)"
> > ! }
> > ! -re ".*= 17\r\n$gdb_prompt $" {
> > ! pass "stopped before calling common_routine 15 times (17 times)"
> > ! }
> > default {
> > fail "stopped before calling common_routine 15 times"
> > return 0
> > *************** proc check_backtraces {} {
> > *** 293,298 ****
> > --- 299,305 ----
> > send_gdb "continue\n"
> > gdb_expect {
> > -re "Breakpoint .* common_routine \\(arg=2\\).*" {
> > + pass "continue to bkpt at common_routine in thread 2"
> > send_gdb "backtrace\n"
> > gdb_expect {
> > -re "#0.*common_routine \\(arg=2\\).*#1.*thread2.*" {
> > *************** proc check_backtraces {} {
> > *** 307,322 ****
> > }
> > }
> > -re "Breakpoint .* common_routine \\(arg=0\\).*" {
> > ! fail "stopped in main thread at breakpoint for thread 2"
> > }
> > -re "Breakpoint .* common_routine \\(arg=1\\).*" {
> > ! fail "stopped in main thread at breakpoint for thread 1"
> > }
> > -re ".*$gdb_prompt" {
> > fail "continue to bkpt at common_routine in thread 2"
> > }
> > default {
> > ! fail "continue to bkpt at common_routine in thread 2"
> > }
> > timeout {
> > fail "continue to bkpt at common_routine in thread 2 (timeout)"
> > --- 314,329 ----
> > }
> > }
> > -re "Breakpoint .* common_routine \\(arg=0\\).*" {
> > ! fail "continue to bkpt at common_routine in thread 2 (arg=0)"
> > }
> > -re "Breakpoint .* common_routine \\(arg=1\\).*" {
> > ! fail "continue to bkpt at common_routine in thread 2 (arg=1)"
> > }
> > -re ".*$gdb_prompt" {
> > fail "continue to bkpt at common_routine in thread 2"
> > }
> > default {
> > ! fail "continue to bkpt at common_routine in thread 2 (default)"
> > }
> > timeout {
> > fail "continue to bkpt at common_routine in thread 2 (timeout)"
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-02-09 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <3A820FF8.1FD6E9B4@cygnus.com>
2001-02-09 9:25 ` [rfa] unify some pthreads.exp messages Michael Snyder
2001-02-09 9:35 ` Fernando Nasser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox