Re: RFA: Small fix to valops.c (value_assign)

Re: RFA: Small fix to valops.c (value_assign)

[David Taylor]

    Date: Fri, 09 Jun 2000 00:57:07 +0000
    From: Fernando Nasser <fnasser@cygnus.com>

    This causes some spurious register reads (sometimes to a invalid
    register number) on some targets when reading fields of typed registers
    that are not on the first byte of the register.

I assume that you mean that it *PREVENTS* some spurious register reads...
    -- 
    Fernando Nasser
    Red Hat Canada Ltd.    E-Mail:  fnasser@cygnus.com

    Index: ChangeLog
    ===================================================================
    RCS file: /cvs/src/src/gdb/ChangeLog,v
    retrieving revision 1.457
    diff -c -p -r1.457 ChangeLog
    *** ChangeLog   2000/06/09 00:51:54     1.457
    --- ChangeLog   2000/06/09 00:54:04
    ***************
    *** 1,5 ****
    --- 1,10 ----
      2000-06-08  Fernando Nasser  <fnasser@cygnus.com>

    +       * valops.c (value_assign): Adjust the length to take into
    +       consideration that we are not starting from the beginning.
    + 
    + 2000-06-08  Fernando Nasser  <fnasser@cygnus.com>
    + 
	    * values.c (value_primitive_field): Copy VALUE_REGNO as well.
	    With typed registers we may have the location information in this field,
	    in addition to VALUE_ADDRESS (which was already being copied).

Approved.

    Index: valops.c
    ===================================================================
    RCS file: /cvs/src/src/gdb/valops.c,v
    retrieving revision 1.16
    diff -c -p -r1.16 valops.c
    *** valops.c    2000/05/28 01:12:33     1.16
    --- valops.c    2000/06/09 00:54:05
    *************** value_assign (toval, fromval)
    *** 660,666 ****
	    if (VALUE_BITSIZE (toval))
	    {
	      char buffer[sizeof (LONGEST)];
    !         int len = REGISTER_RAW_SIZE (VALUE_REGNO (toval));

	      if (len > (int) sizeof (LONGEST))
		error ("Can't handle bitfields in registers larger than %d bits.",
    --- 660,667 ----
	    if (VALUE_BITSIZE (toval))
	    {
	      char buffer[sizeof (LONGEST)];
    !         int len = 
    !               REGISTER_RAW_SIZE (VALUE_REGNO (toval)) - VALUE_OFFSET (toval);

	      if (len > (int) sizeof (LONGEST))
		error ("Can't handle bitfields in registers larger than %d bits.",

Re: RFA: Small fix to valops.c (value_assign)

[Fernando Nasser]

David Taylor wrote:
> 
>     Date: Fri, 09 Jun 2000 00:57:07 +0000
>     From: Fernando Nasser <fnasser@cygnus.com>
> 
>     This causes some spurious register reads (sometimes to a invalid
>     register number) on some targets when reading fields of typed registers
>     that are not on the first byte of the register.
> 
> I assume that you mean that it *PREVENTS* some spurious register reads...

I meant "caused"... but you are right, "prevents" makes it clearer.

At least I was more fortunate with the ChangeLog entry wording...

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@cygnus.com
2323 Yonge Street, Suite #300           Tel:  416-482-2661 ext. 311
Toronto, Ontario   M4P 2C9              Fax:  416-482-6299
From spolk@redhat.com Mon Jun 12 10:34:00 2000
From: Syd Polk <spolk@redhat.com>
To: Chris Faylor <cgf@cygnus.com>, gdb-patches@sourceware.cygnus.com
Cc: spolk@cygnus.com, fnasser@cygnus.com
Subject: Re: [RFA] Missed one place to search for /usr/share in gdbtk
Date: Mon, 12 Jun 2000 10:34:00 -0000
Message-id: <4.2.0.58.20000612103509.00a299d0@pop.cygnus.com>
References: <20000609204522.A31630@cygnus.com>
X-SW-Source: 2000-06/msg00139.html
Content-length: 1107

This looks good.

At 08:45 PM 6/9/00 -0400, Chris Faylor wrote:
>I don't know how I missed this one but *today* I need an additional patch
>to get gdbtk working.
>
>Ok to check in?
>
>cgf
>
>Fri Jun  9 20:43:40 2000  Christopher Faylor <cgf@cygnus.com>
>
>         * src/paths.c (initialize_paths): Look in /usr/share for stuff.
>
>
>Index: src/paths.c
>===================================================================
>RCS file: /cvs/src/src/libgui/src/paths.c,v
>retrieving revision 1.2
>diff -u -p -r1.2 paths.c
>--- paths.c     2000/04/03 19:34:38     1.2
>+++ paths.c     2000/06/10 00:43:30
>@@ -68,6 +68,9 @@ proc initialize_paths {} {\n\
>    }\n\
>    cd [file dirname $exec_name]\n\
>    # Handle build with --exec-prefix and build without.\n\
>+  set d [file join [file dirname [pwd]] usr share]\n\
>+  lappend prefdirs $d\n\
>+  lappend guidirs [file join $d cygnus gui]\n\
>    set d [file join [file dirname [pwd]] share]\n\
>    lappend prefdirs $d\n\
>    lappend guidirs [file join $d cygnus gui]\n\

Syd Polk		spolk@redhat.com
Engineering Manager	+1 415 777 9810 x 241
Red Hat, Inc.