* Re: [rfa] Add a name field to ``struct floatformat''
[not found] ` <3934454E.AAB68F28@cygnus.com>
@ 2000-05-30 16:42 ` Kevin Buettner
2000-05-30 19:18 ` Andrew Cagney
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Buettner @ 2000-05-30 16:42 UTC (permalink / raw)
To: Andrew Cagney; +Cc: GDB Patches
On May 31, 8:48am, Andrew Cagney wrote:
> Did you like how GDB added floatformat_to_double() to libiberty and then
> replaced that with a local floatformat_to_doublest() ;-/
I noticed it, but did not know how it came about. Who's responsible
for maintaining libiberty?
The reason I ask is that I've been wondering what to do about the fact
that we now have a number of fixes to floatformat_to_doublest() and
floatformat_from_doublest() (or their helper functions) and that these
have not (to the best of my knowledge) been merged into libiberty.
The ones that I know about are:
* utils.c (get_field, put_field): Fix buffer underruns and
overruns. Also, handle case where total_len is not evenly
divisible by 8.
(getfield): Make sure zeroing of unwanted bits occurs even
when bit field to extract does not straddle two or more
bytes.
* utils.c (floatformat_from_doublest): Don't assume that a long
will be exactly 32 bits in length. Also... make sure space
that we're writing the float to is completely initialized to
zeroes, even when the number of bits in the float is not
evenly divisible by FLOATFORMAT_CHAR_BIT.
Kevin
From dan@cgsoftware.com Tue May 30 17:23:00 2000
From: Daniel Berlin <dan@cgsoftware.com>
To: gdb-patches@sourceware.cygnus.com
Subject: [RFA] Reduce memory usage for dwarf2 dramatically, unify hashfunctions
Date: Tue, 30 May 2000 17:23:00 -0000
Message-id: <Pine.LNX.4.10.10005301704450.27990-200000@propylaea.anduin.com>
X-SW-Source: 2000-05/msg00475.html
Content-length: 1587
This patch dramatically reduces memory usage when using DWARF2. It
should also make debugging with DWARF2 quicker because of what it
is doing. Before, we would allocate a new type every time we saw a type,
or close to it.
With this patch, we cache the last 4096 (it's controlled by a define, this
is a completely unscientific number, you could probably do with smaller,
but it won't make much difference, seeing as how it's 16k worth of
pointers) types we saw by the hash of their name, and use that, rather
than allocating a new type every time.
The results are dramatic.
Just on GDB, compiled with dwarf2, for instance, we go from 123,739 types
to 87,004, a 33% reduction. We also drop from needing 60 meg, with
everything read in (maint check symtabs was used to force readin), to 46
meg.
Since their are now really only "distinct" symbols, and "distinct" types,
rather than tons of duplicates, things should go a bit faster as well in
other lookups.
In doing all of this, i also changed the hash function in the bcache to a
much better hash function (the old one was stolen from SDBM, this one uses
what db 3.0.55 uses. The commentary in the db 3.0.55 source says it's just
as good on strings, and much better on numbers), made the hash function
available through bcache.h, and changed buildsym.c's hashname to use it as
well.
I was going to change the minsym hash to use the hash function as well,
but haven't finished regression tests on that change, so i left it out.
I'm just starting to clear out my backlog of patches, expect more memory
reductions for dwarf2 soon.
--Dan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [rfa] Add a name field to ``struct floatformat''
2000-05-30 16:42 ` [rfa] Add a name field to ``struct floatformat'' Kevin Buettner
@ 2000-05-30 19:18 ` Andrew Cagney
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Cagney @ 2000-05-30 19:18 UTC (permalink / raw)
To: Kevin Buettner; +Cc: GDB Patches, Nick Clifton
Kevin Buettner wrote:
>
> On May 31, 8:48am, Andrew Cagney wrote:
>
> > Did you like how GDB added floatformat_to_double() to libiberty and then
> > replaced that with a local floatformat_to_doublest() ;-/
>
> I noticed it, but did not know how it came about. Who's responsible
> for maintaining libiberty?
Notionally GCC. In reality, those specific files are (dig dig) only
used binutils (opcodes/m68k-dis.c) and gdb so we (gdb) are effectivly
responsibility them. We would just have to make certain that all
changes are applied to GCC's master repository.
(To be honest, I'm guessing the history bit :-)
> The reason I ask is that I've been wondering what to do about the fact
> that we now have a number of fixes to floatformat_to_doublest() and
> floatformat_from_doublest() (or their helper functions) and that these
> have not (to the best of my knowledge) been merged into libiberty.
>
> The ones that I know about are:
>
> * utils.c (get_field, put_field): Fix buffer underruns and
> overruns. Also, handle case where total_len is not evenly
> divisible by 8.
> (getfield): Make sure zeroing of unwanted bits occurs even
> when bit field to extract does not straddle two or more
> bytes.
>
> * utils.c (floatformat_from_doublest): Don't assume that a long
> will be exactly 32 bits in length. Also... make sure space
> that we're writing the float to is completely initialized to
> zeroes, even when the number of bits in the float is not
> evenly divisible by FLOATFORMAT_CHAR_BIT.
More outch!
Andrew
From eliz@delorie.com Tue May 30 23:26:00 2000
From: Eli Zaretskii <eliz@delorie.com>
To: ac131313@cygnus.com
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: [rfa/5] add PDF target to doc directory
Date: Tue, 30 May 2000 23:26:00 -0000
Message-id: <200005310626.CAA08713@indy.delorie.com>
References: <392F87DB.5E05556B@cygnus.com> <39306263.C6C5480D@cygnus.com> <3931EE33.D2EFAD6E@cygnus.com> <200005290719.DAA06087@indy.delorie.com> <39337A95.4E9DA83A@cygnus.com>
X-SW-Source: 2000-05/msg00477.html
Content-length: 290
> Date: Tue, 30 May 2000 18:23:49 +1000
> From: Andrew Cagney <ac131313@cygnus.com>
>
> Yes, I avoided ``@ifnottex'' which caused me grief last time.
> I've also tried it with makeinfo 3.12, 3.12f and 4.0 and they all went
> through without errors.
Then I think it's okay for the branch.
From eliz@delorie.com Wed May 31 00:06:00 2000
From: Eli Zaretskii <eliz@delorie.com>
To: kevinb@cygnus.com
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: [PATCH RFC] PARAMS elimination - phase 2
Date: Wed, 31 May 2000 00:06:00 -0000
Message-id: <200005310705.DAA08769@indy.delorie.com>
References: <1000530232352.ZM5368@ocotillo.lan>
X-SW-Source: 2000-05/msg00478.html
Content-length: 1447
> Date: Tue, 30 May 2000 16:23:53 -0700
> From: Kevin Buettner <kevinb@cygnus.com>
>
> If you look carefully, you'll
> notice that there are a few places where other fields within a struct
> declaration have been reformatted. I was torn between putting these
> fields back the way they were prior to running indent and leaving them
> in their newly indented state. In the end I chose the latter option
> of leaving them in their newly indented state.
[snip]
> -void (*target_overlay_update) PARAMS ((struct obj_section *))
> -= simple_overlay_update;
> +void (*target_overlay_update) (struct obj_section *) = simple_overlay_update;
[snip]
> -static struct partial_symbol *lookup_partial_symbol PARAMS
> - ((struct partial_symtab *, const char *,
> - int, namespace_enum));
> +static struct partial_symbol *lookup_partial_symbol
> + (struct partial_symtab *, const char *, int, namespace_enum);
[snip]
> - struct target_ops
> - *DONT_USE; /* formerly to_next */
> + struct target_ops *DONT_USE; /* formerly to_next */
The above are a few of the examples of such a gratuitous
reformatting. I think they are evil and should be avoided at all
costs. They make it a PITA to apply patches sent by people who have
sources before the reformatting. Introducing changes that merely
reshuffle white space really doesn't make sense to me.
I vote against those whitespace changes (even though these are not
files I'm responsible for).
From ac131313@cygnus.com Wed May 31 00:36:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: Kevin Buettner <kevinb@cygnus.com>
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: [PATCH RFC] PARAMS elimination - phase 2
Date: Wed, 31 May 2000 00:36:00 -0000
Message-id: <3934C0D1.D8E8AB44@cygnus.com>
References: <1000530232352.ZM5368@ocotillo.lan>
X-SW-Source: 2000-05/msg00479.html
Content-length: 133
Kevin,
It probably shouldn't be touching the testsuite directory. While GDB
might require ISO-C, the testsuite shouldn't.
Andrew
From ac131313@cygnus.com Wed May 31 01:00:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: Kevin Buettner <kevinb@cygnus.com>
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: [PATCH RFC] PARAMS elimination - phase 2
Date: Wed, 31 May 2000 01:00:00 -0000
Message-id: <3934C674.DBE2A089@cygnus.com>
References: <1000530232352.ZM5368@ocotillo.lan>
X-SW-Source: 2000-05/msg00480.html
Content-length: 2286
Kevin Buettner wrote:
>
> Below are changes representing phase 2 of the campaign to purge the use
> of PARAMS from the gdb sources.
Can I suggest doing just the automated part of this change and then,
again, give the dust a chance to settle. The remaining PARAMS that need
hand tweeking can then be done incrementally.
> posted earlier. (It's identical but for one line.) After running the
> script, the initial indent was incorrect for declarations appearing in
> structs and within the old pre-ansi parameter declarations.
Can the script remember how much leading white space there was and put
it back afterwards?
> I fixed
> some of these initial indents by hand. For the others, I reindented
> the struct declaration in which the declarations appeared. (I used
> "indent -sbi2" since that seemed to be the convention for the brace
> placement after the struct keyword.) If you look carefully, you'll
> notice that there are a few places where other fields within a struct
> declaration have been reformatted. I was torn between putting these
> fields back the way they were prior to running indent and leaving them
> in their newly indented state. In the end I chose the latter option
> of leaving them in their newly indented state. If you have concerns
> about this, please examine DONT_USE, to_sections, and to_sections_end
> in the patch to target.h below.
While a royal pain in the butt, if the process was automated it can be
lived with. The main thing is that people with local sources can run
the script over them and preproduce your results. Things to do include
rewrite target.h into something more like gdbarch.{h,c,sh}.
As an asside, the indent that was used had a bug with how it formatted
structs. It would format them as either
struct x
{
int i;
};
struct x
{
int i;
};
> Andrew has recommended that I give a one day notice and then, unless
> there are objections, commit the changes. So... unless I see objections
> to this patch before then, I plan to commit these changes tomorrow
> evening at around 5:00pm MST (which is midnight GMT of Thursday, June 1).
Oops, I was kind of thinking you would do the remainder by hand which
ment you would have been fixing things at the rate of one or two files a
day. Sorry.
Andrew
From ac131313@cygnus.com Wed May 31 01:05:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: kevinb@cygnus.com, gdb-patches@sourceware.cygnus.com
Subject: Re: [PATCH RFC] PARAMS elimination - phase 2
Date: Wed, 31 May 2000 01:05:00 -0000
Message-id: <3934C781.F2FF9D1F@cygnus.com>
References: <1000530232352.ZM5368@ocotillo.lan> <200005310705.DAA08769@indy.delorie.com>
X-SW-Source: 2000-05/msg00481.html
Content-length: 1232
Eli Zaretskii wrote:
>
> > Date: Tue, 30 May 2000 16:23:53 -0700
> > From: Kevin Buettner <kevinb@cygnus.com>
> >
> > If you look carefully, you'll
> > notice that there are a few places where other fields within a struct
> > declaration have been reformatted. I was torn between putting these
> > fields back the way they were prior to running indent and leaving them
> > in their newly indented state. In the end I chose the latter option
> > of leaving them in their newly indented state.
> [snip]
> > -void (*target_overlay_update) PARAMS ((struct obj_section *))
> > -= simple_overlay_update;
> > +void (*target_overlay_update) (struct obj_section *) = simple_overlay_update;
> [snip]
> > -static struct partial_symbol *lookup_partial_symbol PARAMS
> > - ((struct partial_symtab *, const char *,
> > - int, namespace_enum));
> > +static struct partial_symbol *lookup_partial_symbol
> > + (struct partial_symtab *, const char *, int, namespace_enum);
> [snip]
> > - struct target_ops
> > - *DONT_USE; /* formerly to_next */
> > + struct target_ops *DONT_USE; /* formerly to_next */
In the case of the above, it doesn't worry me (I really am the target
vector maintainer :-).
Andrew
From ac131313@cygnus.com Wed May 31 03:18:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: BINUTILS Patches <binutils@sourceware.cygnus.com>, GDB Patches <gdb-patches@sourceware.cygnus.com>
Subject: Re: Update config.guess, config.sub, texinfo.tex
Date: Wed, 31 May 2000 03:18:00 -0000
Message-id: <3934E6D5.C2AEB97@cygnus.com>
References: <3931F0DF.868A3085@cygnus.com>
X-SW-Source: 2000-05/msg00482.html
Content-length: 201
Andrew Cagney wrote:
>
> FYI,
>
> I intend updating these with more recent copies from the official
> releases. For texinfo.tex that would be makeinfo-4.0.
The texinfo.tex file is now in.
Andrew
From blymn@baesystems.com.au Wed May 31 03:28:00 2000
From: blymn@baesystems.com.au (Brett Lymn)
To: gdb-patches@sourceware.cygnus.com
Subject: problem compiling gdb5.0 on NetBSD-current i386 ELF
Date: Wed, 31 May 2000 03:28:00 -0000
Message-id: <200005311028.TAA26612@mallee.awadi>
X-SW-Source: 2000-05/msg00483.html
Content-length: 6881
Folks,
I just attempted to compile gdb5.0 on a NetBSD-current i386
ELF machine and the thing fell over compiling gdb/solib.c. The uname
of my machine gives:
NetBSD siren 1.4X NetBSD 1.4X (SKEL) #0: Mon May 15 18:20:37 CST 2000
toor@siren:/usr/src/sys/arch/i386/compile/SKEL i386
My gcc version is this:
gcc version egcs-2.91.66 19990314 (egcs-1.1.2 release)
and the errors I get are these:
gmake[1]: Entering directory `/usr/local/src/gdb-5.0/libiberty'
gmake[2]: Entering directory `/usr/local/src/gdb-5.0/libiberty/testsuite'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/local/src/gdb-5.0/libiberty/testsuite'
gmake[1]: Leaving directory `/usr/local/src/gdb-5.0/libiberty'
gmake[1]: Entering directory `/usr/local/src/gdb-5.0/intl'
gmake[1]: Nothing to be done for `all'.
gmake[1]: Leaving directory `/usr/local/src/gdb-5.0/intl'
gmake[1]: Entering directory `/usr/local/src/gdb-5.0/bfd'
gmake all-recursive
gmake[2]: Entering directory `/usr/local/src/gdb-5.0/bfd'
Making all in doc
gmake[3]: Entering directory `/usr/local/src/gdb-5.0/bfd/doc'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/usr/local/src/gdb-5.0/bfd/doc'
Making all in po
gmake[3]: Entering directory `/usr/local/src/gdb-5.0/bfd/po'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/usr/local/src/gdb-5.0/bfd/po'
gmake[3]: Entering directory `/usr/local/src/gdb-5.0/bfd'
gmake[3]: Nothing to be done for `all-am'.
gmake[3]: Leaving directory `/usr/local/src/gdb-5.0/bfd'
gmake[2]: Leaving directory `/usr/local/src/gdb-5.0/bfd'
gmake[1]: Leaving directory `/usr/local/src/gdb-5.0/bfd'
gmake[1]: Entering directory `/usr/local/src/gdb-5.0/opcodes'
gmake all-recursive
gmake[2]: Entering directory `/usr/local/src/gdb-5.0/opcodes'
Making all in po
gmake[3]: Entering directory `/usr/local/src/gdb-5.0/opcodes/po'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/usr/local/src/gdb-5.0/opcodes/po'
gmake[3]: Entering directory `/usr/local/src/gdb-5.0/opcodes'
gmake[3]: Nothing to be done for `all-am'.
gmake[3]: Leaving directory `/usr/local/src/gdb-5.0/opcodes'
gmake[2]: Leaving directory `/usr/local/src/gdb-5.0/opcodes'
gmake[1]: Leaving directory `/usr/local/src/gdb-5.0/opcodes'
gmake[1]: Entering directory `/usr/local/src/gdb-5.0/etc'
gmake[1]: Nothing to be done for `all'.
gmake[1]: Leaving directory `/usr/local/src/gdb-5.0/etc'
gmake[1]: Entering directory `/usr/local/src/gdb-5.0/mmalloc'
gmake[1]: Nothing to be done for `all'.
gmake[1]: Leaving directory `/usr/local/src/gdb-5.0/mmalloc'
gmake[1]: Entering directory `/usr/local/src/gdb-5.0/readline'
gmake[1]: Nothing to be done for `all'.
gmake[1]: Leaving directory `/usr/local/src/gdb-5.0/readline'
gmake[1]: Entering directory `/usr/local/src/gdb-5.0/sim'
gmake[1]: Leaving directory `/usr/local/src/gdb-5.0/sim'
gmake[1]: Entering directory `/usr/local/src/gdb-5.0/gdb'
gcc -c -g -O2 -I. -I. -I./config -DHAVE_CONFIG_H -I./../include/opcode -I./../readline/.. -I../bfd -I./../bfd -I./../include -I../intl -I./../intl -I./tui -DUSE_INCLUDED_REGEX solib.c
solib.c: In function `solib_map_sections':
solib.c:369: structure has no member named `som_addr'
solib.c:369: structure has no member named `som_addr'
solib.c:370: structure has no member named `som_addr'
solib.c:370: structure has no member named `som_addr'
solib.c: In function `solib_add_common_symbols':
solib.c:431: storage size of `inferior_rtc_symb' isn't known
solib.c: In function `first_link_map_member':
solib.c:896: sizeof applied to an incomplete type
solib.c:897: invalid use of undefined type `struct _dynamic'
solib.c:901: invalid use of undefined type `struct _dynamic'
solib.c:901: invalid use of undefined type `struct _dynamic'
solib.c:902: sizeof applied to an incomplete type
solib.c:903: invalid use of undefined type `struct section_dispatch_table'
solib.c:903: invalid use of undefined type `struct section_dispatch_table'
solib.c: In function `current_sos':
solib.c:1099: structure has no member named `som_next'
solib.c:1099: structure has no member named `som_next'
solib.c:1114: structure has no member named `som_path'
solib.c:1114: structure has no member named `som_path'
solib.c: In function `symbol_add_stub':
solib.c:1181: structure has no member named `som_addr'
solib.c:1181: structure has no member named `som_addr'
solib.c: In function `info_sharedlibrary_command':
solib.c:1508: structure has no member named `som_addr'
solib.c:1508: structure has no member named `som_addr'
solib.c: In function `solib_address':
solib.c:1555: structure has no member named `som_addr'
solib.c:1555: structure has no member named `som_addr'
solib.c: In function `disable_break':
solib.c:1662: sizeof applied to an incomplete type
solib.c:1668: invalid use of undefined type `struct so_debug'
solib.c:1668: invalid use of undefined type `struct so_debug'
solib.c:1669: invalid use of undefined type `struct so_debug'
solib.c:1670: invalid use of undefined type `struct so_debug'
solib.c: In function `enable_break':
solib.c:1754: sizeof applied to an incomplete type
solib.c:1763: invalid use of undefined type `struct _dynamic'
solib.c:1763: invalid use of undefined type `struct _dynamic'
solib.c:1767: invalid use of undefined type `struct so_debug'
solib.c: In function `special_symbol_handling':
solib.c:2053: sizeof applied to an incomplete type
solib.c:2064: invalid use of undefined type `struct _dynamic'
solib.c:2064: invalid use of undefined type `struct _dynamic'
solib.c:2071: sizeof applied to an incomplete type
solib.c:2077: invalid use of undefined type `struct so_debug'
solib.c:2079: invalid use of undefined type `struct so_debug'
solib.c:2079: invalid use of undefined type `struct so_debug'
solib.c: At top level:
solib.c:128: storage size of `dynamic_copy' isn't known
solib.c:129: storage size of `ld_2_copy' isn't known
solib.c:130: storage size of `debug_copy' isn't known
gmake[1]: *** [solib.o] Error 1
gmake[1]: Leaving directory `/usr/local/src/gdb-5.0/gdb'
gmake: *** [all-gdb] Error 2
The interesting thing about this is if I look at the lines that have
the error about som_addr on them I see this:
p->addr += LM_ADDR (so);
which use these defines from the top of the file:
#define SOLIB_EXTRACT_ADDRESS(member) \
extract_address (&member, sizeof (member))
#ifndef SVR4_SHARED_LIBS
#define LM_ADDR(so) (SOLIB_EXTRACT_ADDRESS ((so) -> lm.lm_addr))
_but_ if I look at the preprocessor output I see:
p->addr += (extract_address (& ( so ) -> lm. som_addr , sizeof
( ( so ) -> lm. som_addr )) ) ;
somehow the lm_addr's have been changed into som_addr which is very odd.
--
===============================================================================
Brett Lymn, Computer Systems Administrator, BAE SYSTEMS
===============================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [rfa] Add a name field to ``struct floatformat''
[not found] ` <3933695B.6CE1380D@cygnus.com>
@ 2000-05-31 3:58 ` Andrew Cagney
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Cagney @ 2000-05-31 3:58 UTC (permalink / raw)
To: GCC Patches, GDB Patches, BINUTILS Patches
Andrew Cagney wrote:
>
> Andrew Cagney wrote:
> >
> > Hello,
> >
> > The attached adds a name field to ``struct floatformat''. It would be
> > going into both the binutils+gdb and gcc repositories. Since GDB likes
> > to change its floatingpoint format on the fly, being about to print the
> > format's name out (for debugging) is very helpful.
> >
> > Any problems? (This code was once GDB's anyway :-).
> >
> > Andrew
Copyright dates fixed, patch committed.
Andrew
From aj@suse.de Wed May 31 04:11:00 2000
From: Andreas Jaeger <aj@suse.de>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: BINUTILS Patches <binutils@sourceware.cygnus.com>, GDB Patches <gdb-patches@sourceware.cygnus.com>
Subject: Re: Update config.guess, config.sub, texinfo.tex
Date: Wed, 31 May 2000 04:11:00 -0000
Message-id: <u8wvkbgf3t.fsf@gromit.rhein-neckar.de>
References: <3931F0DF.868A3085@cygnus.com> <3934E6D5.C2AEB97@cygnus.com>
X-SW-Source: 2000-05/msg00487.html
Content-length: 586
>>>>> Andrew Cagney writes:
Andrew> Andrew Cagney wrote:
>>
>> FYI,
>>
>> I intend updating these with more recent copies from the official
>> releases. For texinfo.tex that would be makeinfo-4.0.
Andrew> The texinfo.tex file is now in.
The most recent version of texinfo.tex is on ftp.gnu.org as a single
file.
ls -l manual/texinfo.tex
-rw-r--r-- 1 aj users 200234 May 17 09:58 manual/texinfo.tex
It contains:
\def\texinfoversion{2000-05-16.11}
I advise to use that version instead,
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
From msnyder@cygnus.com Wed May 31 08:04:00 2000
From: Michael Snyder <msnyder@cygnus.com>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: kevinb@cygnus.com, gdb-patches@sourceware.cygnus.com
Subject: Re: [PATCH RFC] PARAMS elimination - phase 2
Date: Wed, 31 May 2000 08:04:00 -0000
Message-id: <39352924.675A@cygnus.com>
References: <1000530232352.ZM5368@ocotillo.lan> <200005310705.DAA08769@indy.delorie.com>
X-SW-Source: 2000-05/msg00488.html
Content-length: 1391
Eli Zaretskii wrote:
> [snip]
> > -void (*target_overlay_update) PARAMS ((struct obj_section *))
> > -= simple_overlay_update;
> > +void (*target_overlay_update) (struct obj_section *) = simple_overlay_update;
> [snip]
> > -static struct partial_symbol *lookup_partial_symbol PARAMS
> > - ((struct partial_symtab *, const char *,
> > - int, namespace_enum));
> > +static struct partial_symbol *lookup_partial_symbol
> > + (struct partial_symtab *, const char *, int, namespace_enum);
> [snip]
> > - struct target_ops
> > - *DONT_USE; /* formerly to_next */
> > + struct target_ops *DONT_USE; /* formerly to_next */
>
> The above are a few of the examples of such a gratuitous
> reformatting. I think they are evil and should be avoided at all
> costs. They make it a PITA to apply patches sent by people who have
> sources before the reformatting. Introducing changes that merely
> reshuffle white space really doesn't make sense to me.
>
> I vote against those whitespace changes (even though these are not
> files I'm responsible for).
I would tend to disagree. In the first place, I like the
single-line declarations better when there is no reason to
break them up into two lines. In the second place, we agreed
that the output of indent, suitably tweaked if necessary to
conform to the GNU coding standard, would be our rule.
Michael
From msnyder@cygnus.com Wed May 31 08:05:00 2000
From: Michael Snyder <msnyder@cygnus.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: Kevin Buettner <kevinb@cygnus.com>, gdb-patches@sourceware.cygnus.com
Subject: Re: [PATCH RFC] PARAMS elimination - phase 2
Date: Wed, 31 May 2000 08:05:00 -0000
Message-id: <39352962.3974@cygnus.com>
References: <1000530232352.ZM5368@ocotillo.lan> <3934C0D1.D8E8AB44@cygnus.com>
X-SW-Source: 2000-05/msg00489.html
Content-length: 280
Andrew Cagney wrote:
>
> Kevin,
>
> It probably shouldn't be touching the testsuite directory. While GDB
> might require ISO-C, the testsuite shouldn't.
Moreover, some of the tests have line numbers hard-coded
into them. If you reformat the source, they will break.
Michael
From kevinb@cygnus.com Wed May 31 09:16:00 2000
From: Kevin Buettner <kevinb@cygnus.com>
To: gdb-patches@sourceware.cygnus.com
Subject: Re: [PATCH RFC] PARAMS elimination - phase 2
Date: Wed, 31 May 2000 09:16:00 -0000
Message-id: <1000531161626.ZM6554@ocotillo.lan>
References: <1000530232352.ZM5368@ocotillo.lan> <kevinb@cygnus.com>
X-SW-Source: 2000-05/msg00490.html
Content-length: 1319
On May 30, 4:23pm, Kevin Buettner wrote:
> Below are changes representing phase 2 of the campaign to purge the use
> of PARAMS from the gdb sources.
This patch is retracted.
There were several objections, which can be summarized as follows:
- PARAMS should not be removed from the testsuite.
- There were several non-PARAMS reformatting changes. (Though there
was also disagreement about whether this was a good thing or a bad
thing.)
- There needs to be an automatic method for making most of the
changes. (So that the script may be applied to local source
trees that may not have been sync'd in a while.)
- In the cases where PARAMS removal and reformatting needs to be
done by hand, these changes need to be done slowly, at the rate of
one or two files a day.
As Andrew suggested, I will attempt to revise my script to handle
and preserve leading indentation. This will avoid gratuitous
reformatting changes to non-PARAMS struct elements. It'll also
provide folks with a mechanism for removing PARAMS locally.
Hopefully, there will only a be a small number of PARAMS occurrences
left after application of a second script. These, I will do by hand,
at the rate of one or two files a day. The patches will be small
enough to easily review in a matter of minutes.
Kevin
From kevinb@cygnus.com Wed May 31 09:19:00 2000
From: Kevin Buettner <kevinb@cygnus.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: [PATCH RFC] PARAMS elimination - phase 2
Date: Wed, 31 May 2000 09:19:00 -0000
Message-id: <1000531161902.ZM6568@ocotillo.lan>
References: <1000530232352.ZM5368@ocotillo.lan> <3934C674.DBE2A089@cygnus.com> <ac131313@cygnus.com>
X-SW-Source: 2000-05/msg00491.html
Content-length: 392
On May 31, 5:59pm, Andrew Cagney wrote:
> As an asside, the indent that was used had a bug with how it formatted
> structs. It would format them as either
>
> struct x
> {
> int i;
> };
>
> struct x
> {
> int i;
> };
Which form is preferred?
(I was using indent 2.2.5 and it was formatting the former into the
latter -- at least on the examples that I tried.)
Kevin
From jtc@redback.com Wed May 31 11:46:00 2000
From: jtc@redback.com (J.T. Conklin)
To: blymn@baesystems.com.au (Brett Lymn)
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: problem compiling gdb5.0 on NetBSD-current i386 ELF
Date: Wed, 31 May 2000 11:46:00 -0000
Message-id: <5m8zwqy2vi.fsf@jtc.redback.com>
References: <200005311028.TAA26612@mallee.awadi>
X-SW-Source: 2000-05/msg00492.html
Content-length: 423
>>>>> "Brett" == Brett Lymn <blymn@baesystems.com.au> writes:
Brett> I just attempted to compile gdb5.0 on a NetBSD-current i386
Brett> ELF machine and the thing fell over compiling gdb/solib.c. The uname
Brett> of my machine gives:
There is currently no support for NetBSD/i386 ELF systems in the GDB
sources. I hope to have something checked in by the end of the day.
--jtc
--
J.T. Conklin
RedBack Networks
From kevinb@cygnus.com Wed May 31 13:02:00 2000
From: Kevin Buettner <kevinb@cygnus.com>
To: gdb-patches@sourceware.cygnus.com
Subject: [PATCH RFC] PARAMS elimination: pointer variables
Date: Wed, 31 May 2000 13:02:00 -0000
Message-id: <1000531200148.ZM11276@ocotillo.lan>
X-SW-Source: 2000-05/msg00493.html
Content-length: 59016
Okay, let's try this again...
The patch below eliminates PARAMS from (most occurrences of) function
pointer declarations in the gdb sources. They were generated entirely
automatically with a new script which I'll post as a reply to this
message.
In this patch, there is no gratuitous reformatting of anything not
having to do with PARAMS elimination. I believe there are still
some changes (regarding assignment statements) that Eli originally
objected to, but I believe there was enough convincing argument in
favor of this reformatting to let it stand. (I'm not averse to
further discussion on this matter though.)
After these changes, there remain about 30 occurrences of PARAMS in
the source code that need to be eliminated by hand. In addition, I
still need to revert my inadvertent changes to gnu-regexp.c from
last weekend.
As usual, I've done a test build on GNU/Linux/IA-32 and have encountered
no problems. In addition, I've looked over all of the changes and they
look good to me.
If there are no objections, I'll commit these changes at midnight of
Friday, June 2. (Which is 5:00 pm Thursday for me.)
* annotate.c, annotate.h, breakpoint.c, command.c, command.h,
corefile.c, d10v-tdep.c, d30v-tdep.c, dbxread.c, dcache.c,
dcache.h, dsrec.c, dve3900-rom.c, exec.c, fork-child.c,
gdbcore.h, hpux-thread.c, language.h, linux-thread.c,
mdebugread.c, monitor.h, ocd.c, procfs.c, ptx4-nat.c,
remote-sim.c, remote-utils.h, remote.c, rs6000-tdep.c,
ser-ocd.c, sol-thread.c, sparcl-tdep.c, stabsread.h, stack.c,
symfile.c, symfile.h, symtab.h, target.c, target.h, top.c,
tracepoint.c, tracepoint.h, utils.c, v850ice.c, varobj.c,
win32-nat.c, wince.c, xcoffsolib.c, xcoffsolib.h,
config/rs6000/tm-rs6000.h, tui/tui.h, tui/tuiIO.c: Eliminate
PARAMS from function pointer declarations.
Index: annotate.c
===================================================================
RCS file: /cvs/src/src/gdb/annotate.c,v
retrieving revision 1.2
diff -u -p -r1.2 annotate.c
--- annotate.c 2000/05/28 01:12:26 1.2
+++ annotate.c 2000/05/31 19:25:45
@@ -34,11 +34,11 @@ static void print_value_flags (struct ty
static void breakpoint_changed (struct breakpoint *);
-void (*annotate_starting_hook) PARAMS ((void));
-void (*annotate_stopped_hook) PARAMS ((void));
-void (*annotate_signalled_hook) PARAMS ((void));
-void (*annotate_signal_hook) PARAMS ((void));
-void (*annotate_exited_hook) PARAMS ((void));
+void (*annotate_starting_hook) (void);
+void (*annotate_stopped_hook) (void);
+void (*annotate_signalled_hook) (void);
+void (*annotate_signal_hook) (void);
+void (*annotate_exited_hook) (void);
static int ignore_count_changed = 0;
Index: annotate.h
===================================================================
RCS file: /cvs/src/src/gdb/annotate.h,v
retrieving revision 1.2
diff -u -p -r1.2 annotate.h
--- annotate.h 2000/05/28 01:12:26 1.2
+++ annotate.h 2000/05/31 19:25:45
@@ -98,8 +98,8 @@ extern void annotate_elt_rep_end (void);
extern void annotate_elt (void);
extern void annotate_array_section_end (void);
-extern void (*annotate_starting_hook) PARAMS ((void));
-extern void (*annotate_stopped_hook) PARAMS ((void));
-extern void (*annotate_signalled_hook) PARAMS ((void));
-extern void (*annotate_signal_hook) PARAMS ((void));
-extern void (*annotate_exited_hook) PARAMS ((void));
+extern void (*annotate_starting_hook) (void);
+extern void (*annotate_stopped_hook) (void);
+extern void (*annotate_signalled_hook) (void);
+extern void (*annotate_signal_hook) (void);
+extern void (*annotate_exited_hook) (void);
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.11
diff -u -p -r1.11 breakpoint.c
--- breakpoint.c 2000/05/28 01:12:26 1.11
+++ breakpoint.c 2000/05/31 19:26:06
@@ -7396,7 +7396,7 @@ ignore_command (args, from_tty)
static void
map_breakpoint_numbers (args, function)
char *args;
- void (*function) PARAMS ((struct breakpoint *));
+ void (*function) (struct breakpoint *);
{
register char *p = args;
char *p1;
Index: command.c
===================================================================
RCS file: /cvs/src/src/gdb/command.c,v
retrieving revision 1.10
diff -u -p -r1.10 command.c
--- command.c 2000/05/28 01:12:26 1.10
+++ command.c 2000/05/31 19:26:24
@@ -84,7 +84,7 @@ struct cmd_list_element *
add_cmd (name, class, fun, doc, list)
char *name;
enum command_class class;
- void (*fun) PARAMS ((char *, int));
+ void (*fun) (char *, int);
char *doc;
struct cmd_list_element **list;
{
@@ -168,7 +168,7 @@ struct cmd_list_element *
add_abbrev_cmd (name, class, fun, doc, list)
char *name;
enum command_class class;
- void (*fun) PARAMS ((char *, int));
+ void (*fun) (char *, int);
char *doc;
struct cmd_list_element **list;
{
@@ -222,7 +222,7 @@ add_prefix_cmd (name, class, fun, doc, p
allow_unknown, list)
char *name;
enum command_class class;
- void (*fun) PARAMS ((char *, int));
+ void (*fun) (char *, int);
char *doc;
struct cmd_list_element **prefixlist;
char *prefixname;
@@ -243,7 +243,7 @@ add_abbrev_prefix_cmd (name, class, fun,
allow_unknown, list)
char *name;
enum command_class class;
- void (*fun) PARAMS ((char *, int));
+ void (*fun) (char *, int);
char *doc;
struct cmd_list_element **prefixlist;
char *prefixname;
Index: command.h
===================================================================
RCS file: /cvs/src/src/gdb/command.h,v
retrieving revision 1.8
diff -u -p -r1.8 command.h
--- command.h 2000/05/28 01:12:26 1.8
+++ command.h 2000/05/31 19:26:24
@@ -108,12 +108,11 @@ struct cmd_list_element
union
{
/* If type is not_set_cmd, call it like this: */
- void (*cfunc) PARAMS ((char *args, int from_tty));
+ void (*cfunc) (char *args, int from_tty);
/* If type is cmd_set or show_cmd, first set the variables, and
then call this. */
- void (*sfunc) PARAMS ((char *args, int from_tty,
- struct cmd_list_element * c));
+ void (*sfunc) (char *args, int from_tty, struct cmd_list_element * c);
}
function;
#define NO_FUNCTION ((void (*) PARAMS((char *args, int from_tty))) 0)
@@ -186,7 +185,7 @@ struct cmd_list_element
returned relative to this position. For example, suppose TEXT is "foo"
and we want to complete to "foobar". If WORD is "oo", return
"oobar"; if WORD is "baz/foo", return "baz/foobar". */
- char **(*completer) PARAMS ((char *text, char *word));
+ char **(*completer) (char *text, char *word);
/* Type of "set" or "show" command (or SET_NOT_SET if not "set"
or "show"). */
Index: corefile.c
===================================================================
RCS file: /cvs/src/src/gdb/corefile.c,v
retrieving revision 1.4
diff -u -p -r1.4 corefile.c
--- corefile.c 2000/05/28 01:12:26 1.4
+++ corefile.c 2000/05/31 19:26:29
@@ -51,7 +51,7 @@ static void call_extra_exec_file_hooks (
old code that assumed that only one hook could be set, and which called
exec_file_display_hook directly. */
-typedef void (*hook_type) PARAMS ((char *));
+typedef void (*hook_type) (char *);
hook_type exec_file_display_hook; /* the original hook */
static hook_type *exec_file_extra_hooks; /* array of additional hooks */
@@ -124,7 +124,7 @@ call_extra_exec_file_hooks (filename)
void
specify_exec_file_hook (hook)
- void (*hook) PARAMS ((char *));
+ void (*hook) (char *);
{
hook_type *new_array;
Index: d10v-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/d10v-tdep.c,v
retrieving revision 1.5
diff -u -p -r1.5 d10v-tdep.c
--- d10v-tdep.c 2000/05/28 01:12:26 1.5
+++ d10v-tdep.c 2000/05/31 19:26:33
@@ -1664,8 +1664,8 @@ d10v_gdbarch_init (info, arches)
}
-extern void (*target_resume_hook) PARAMS ((void));
-extern void (*target_wait_loop_hook) PARAMS ((void));
+extern void (*target_resume_hook) (void);
+extern void (*target_wait_loop_hook) (void);
void
_initialize_d10v_tdep ()
Index: d30v-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/d30v-tdep.c,v
retrieving revision 1.2
diff -u -p -r1.2 d30v-tdep.c
--- d30v-tdep.c 2000/05/28 01:12:26 1.2
+++ d30v-tdep.c 2000/05/31 19:26:35
@@ -1365,8 +1365,8 @@ display_trace (low, high)
}
}
-extern void (*target_resume_hook) PARAMS ((void));
-extern void (*target_wait_loop_hook) PARAMS ((void));
+extern void (*target_resume_hook) (void);
+extern void (*target_wait_loop_hook) (void);
void
_initialize_d30v_tdep ()
Index: dbxread.c
===================================================================
RCS file: /cvs/src/src/gdb/dbxread.c,v
retrieving revision 1.5
diff -u -p -r1.5 dbxread.c
--- dbxread.c 2000/05/28 01:12:26 1.5
+++ dbxread.c 2000/05/31 19:26:38
@@ -809,7 +809,7 @@ struct cont_elem
int sym_idx;
int sym_end;
int symnum;
- int (*func) PARAMS ((struct objfile *, struct symbol *, char *));
+ int (*func) (struct objfile *, struct symbol *, char *);
/* other state dependancies include:
(assumption is that these will not change since process_now FIXME!!)
stringtab_global
@@ -828,7 +828,7 @@ void
process_later (sym, p, f)
struct symbol *sym;
char *p;
- int (*f) PARAMS ((struct objfile *, struct symbol *, char *));
+ int (*f) (struct objfile *, struct symbol *, char *);
{
/* Allocate more space for the deferred list. */
@@ -867,7 +867,7 @@ process_now (objfile)
struct symbol *sym;
char *stabs;
int err;
- int (*func) PARAMS ((struct objfile *, struct symbol *, char *));
+ int (*func) (struct objfile *, struct symbol *, char *);
/* Save the state of our caller, we'll want to restore it before
returning. */
Index: dcache.c
===================================================================
RCS file: /cvs/src/src/gdb/dcache.c,v
retrieving revision 1.2
diff -u -p -r1.2 dcache.c
--- dcache.c 2000/05/28 01:12:26 1.2
+++ dcache.c 2000/05/31 19:26:39
@@ -478,7 +478,7 @@ dcache_xfer_memory (dcache, memaddr, mya
if (dcache_enabled_p)
{
- int (*xfunc) PARAMS ((DCACHE * dcache, CORE_ADDR addr, char *ptr));
+ int (*xfunc) (DCACHE * dcache, CORE_ADDR addr, char *ptr);
xfunc = should_write ? dcache_poke_byte : dcache_peek_byte;
for (i = 0; i < len; i++)
Index: dcache.h
===================================================================
RCS file: /cvs/src/src/gdb/dcache.h,v
retrieving revision 1.2
diff -u -p -r1.2 dcache.h
--- dcache.h 2000/05/28 01:12:26 1.2
+++ dcache.h 2000/05/31 19:26:40
@@ -23,9 +23,7 @@
#ifndef DCACHE_H
#define DCACHE_H
-typedef int (*memxferfunc) PARAMS ((CORE_ADDR memaddr,
- char *myaddr,
- int len));
+typedef int (*memxferfunc) (CORE_ADDR memaddr, char *myaddr, int len);
typedef struct dcache_struct DCACHE;
Index: dsrec.c
===================================================================
RCS file: /cvs/src/src/gdb/dsrec.c,v
retrieving revision 1.2
diff -u -p -r1.2 dsrec.c
--- dsrec.c 2000/05/28 01:12:26 1.2
+++ dsrec.c 2000/05/31 19:26:42
@@ -51,7 +51,7 @@ load_srec (desc, file, load_offset, maxr
int maxrecsize;
int flags;
int hashmark;
- int (*waitack) PARAMS ((void));
+ int (*waitack) (void);
{
bfd *abfd;
asection *s;
Index: dve3900-rom.c
===================================================================
RCS file: /cvs/src/src/gdb/dve3900-rom.c,v
retrieving revision 1.2
diff -u -p -r1.2 dve3900-rom.c
--- dve3900-rom.c 2000/05/28 01:12:26 1.2
+++ dve3900-rom.c 2000/05/31 19:26:47
@@ -31,7 +31,7 @@
/* Type of function passed to bfd_map_over_sections. */
-typedef void (*section_map_func) PARAMS ((bfd * abfd, asection * sect, PTR obj));
+typedef void (*section_map_func) (bfd * abfd, asection * sect, PTR obj);
/* Packet escape character used by Densan monitor. */
@@ -95,13 +95,13 @@ static void r3900_open (char *args, int
format, and those that can't be modified at all. In those cases
we have to use our own functions to fetch and store their values. */
-static void (*orig_monitor_fetch_registers) PARAMS ((int regno));
-static void (*orig_monitor_store_registers) PARAMS ((int regno));
+static void (*orig_monitor_fetch_registers) (int regno);
+static void (*orig_monitor_store_registers) (int regno);
/* Pointer to static function in monitor. for loading programs.
We use this function for loading S-records via the serial link. */
-static void (*orig_monitor_load) PARAMS ((char *file, int from_tty));
+static void (*orig_monitor_load) (char *file, int from_tty);
/* This flag is set if a fast ethernet download should be used. */
Index: exec.c
===================================================================
RCS file: /cvs/src/src/gdb/exec.c,v
retrieving revision 1.3
diff -u -p -r1.3 exec.c
--- exec.c 2000/05/28 01:12:27 1.3
+++ exec.c 2000/05/31 19:27:04
@@ -47,7 +47,7 @@
struct vmap *map_vmap (bfd *, bfd *);
-void (*file_changed_hook) PARAMS ((char *));
+void (*file_changed_hook) (char *);
/* Prototypes for local functions */
@@ -473,7 +473,7 @@ xfer_memory (memaddr, myaddr, len, write
boolean res;
struct section_table *p;
CORE_ADDR nextsectaddr, memend;
- boolean (*xfer_fn) PARAMS ((bfd *, sec_ptr, PTR, file_ptr, bfd_size_type));
+ boolean (*xfer_fn) (bfd *, sec_ptr, PTR, file_ptr, bfd_size_type);
asection *section;
if (len <= 0)
Index: fork-child.c
===================================================================
RCS file: /cvs/src/src/gdb/fork-child.c,v
retrieving revision 1.2
diff -u -p -r1.2 fork-child.c
--- fork-child.c 2000/02/09 08:52:45 1.2
+++ fork-child.c 2000/05/31 19:27:12
@@ -103,9 +103,9 @@ fork_inferior (exec_file, allargs, env,
char *exec_file;
char *allargs;
char **env;
- void (*traceme_fun) PARAMS ((void));
- void (*init_trace_fun) PARAMS ((int));
- void (*pre_trace_fun) PARAMS ((void));
+ void (*traceme_fun) (void);
+ void (*init_trace_fun) (int);
+ void (*pre_trace_fun) (void);
char *shell_file;
{
int pid;
Index: gdbcore.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbcore.h,v
retrieving revision 1.3
diff -u -p -r1.3 gdbcore.h
--- gdbcore.h 2000/05/28 01:12:27 1.3
+++ gdbcore.h 2000/05/31 19:27:19
@@ -78,12 +78,12 @@ extern void generic_search (int len, cha
\f
/* Hook for `exec_file_command' command to call. */
-extern void (*exec_file_display_hook) PARAMS ((char *filename));
+extern void (*exec_file_display_hook) (char *filename);
/* Hook for "file_command", which is more useful than above
(because it is invoked AFTER symbols are read, not before) */
-extern void (*file_changed_hook) PARAMS ((char *filename));
+extern void (*file_changed_hook) (char *filename);
extern void specify_exec_file_hook (void (*hook) (char *filename));
@@ -143,13 +143,13 @@ struct core_fns
another file). Returns nonzero if the handler recognizes the
format, zero otherwise. */
- int (*check_format) PARAMS ((bfd *));
+ int (*check_format) (bfd *);
/* Core file handler function to call to ask if it can handle a
given core file format or not. Returns zero if it can't,
nonzero otherwise. */
- int (*core_sniffer) PARAMS ((struct core_fns *, bfd *));
+ int (*core_sniffer) (struct core_fns *, bfd *);
/* Extract the register values out of the core file and store them where
`read_register' will find them.
@@ -172,9 +172,9 @@ struct core_fns
registers in a large upage-plus-stack ".reg" section. Original upage
address X is at location core_reg_sect+x+reg_addr. */
- void (*core_read_registers) PARAMS ((char *core_reg_sect,
- unsigned core_reg_size,
- int which, CORE_ADDR reg_addr));
+ void (*core_read_registers) (char *core_reg_sect,
+ unsigned core_reg_size,
+ int which, CORE_ADDR reg_addr);
/* Finds the next struct core_fns. They are allocated and initialized
in whatever module implements the functions pointed to; an
Index: hpux-thread.c
===================================================================
RCS file: /cvs/src/src/gdb/hpux-thread.c,v
retrieving revision 1.2
diff -u -p -r1.2 hpux-thread.c
--- hpux-thread.c 2000/05/28 01:12:27 1.2
+++ hpux-thread.c 2000/05/31 19:27:58
@@ -524,7 +524,7 @@ hpux_thread_create_inferior (exec_file,
*/
/* Saved pointer to previous owner of the new_objfile event. */
-static void (*target_new_objfile_chain) PARAMS ((struct objfile *));
+static void (*target_new_objfile_chain) (struct objfile *);
void
hpux_thread_new_objfile (objfile)
Index: language.h
===================================================================
RCS file: /cvs/src/src/gdb/language.h,v
retrieving revision 1.3
diff -u -p -r1.3 language.h
--- language.h 2000/05/28 01:12:28 1.3
+++ language.h 2000/05/31 19:28:45
@@ -141,15 +141,15 @@ struct language_defn
/* Parser function. */
- int (*la_parser) PARAMS ((void));
+ int (*la_parser) (void);
/* Parser error function */
- void (*la_error) PARAMS ((char *));
+ void (*la_error) (char *);
/* Evaluate an expression. */
- struct value *(*evaluate_exp) PARAMS ((struct type *, struct expression *,
- int *, enum noside));
+ struct value *(*evaluate_exp) (struct type *, struct expression *,
+ int *, enum noside);
void (*la_printchar) (int ch, struct ui_file * stream);
@@ -159,7 +159,7 @@ struct language_defn
void (*la_emitchar) (int ch, struct ui_file * stream, int quoter);
- struct type *(*la_fund_type) PARAMS ((struct objfile *, int));
+ struct type *(*la_fund_type) (struct objfile *, int);
/* Print a type using syntax appropriate for this language. */
Index: linux-thread.c
===================================================================
RCS file: /cvs/src/src/gdb/linux-thread.c,v
retrieving revision 1.6
diff -u -p -r1.6 linux-thread.c
--- linux-thread.c 2000/03/24 21:07:17 1.6
+++ linux-thread.c 2000/05/31 19:28:50
@@ -902,7 +902,7 @@ update_stop_threads (test_pid)
*/
/* Saved pointer to previous owner of the new_objfile event. */
-static void (*target_new_objfile_chain) PARAMS ((struct objfile *));
+static void (*target_new_objfile_chain) (struct objfile *);
void
linuxthreads_new_objfile (objfile)
Index: mdebugread.c
===================================================================
RCS file: /cvs/src/src/gdb/mdebugread.c,v
retrieving revision 1.4
diff -u -p -r1.4 mdebugread.c
--- mdebugread.c 2000/05/28 01:12:28 1.4
+++ mdebugread.c 2000/05/31 19:29:16
@@ -699,8 +699,7 @@ parse_symbol (sh, ax, ext_sh, bigend, se
struct objfile *objfile;
{
const bfd_size_type external_sym_size = debug_swap->external_sym_size;
- void (*const swap_sym_in) PARAMS ((bfd *, PTR, SYMR *)) =
- debug_swap->swap_sym_in;
+ void (*const swap_sym_in) (bfd *, PTR, SYMR *) = debug_swap->swap_sym_in;
char *name;
struct symbol *s;
struct block *b;
@@ -2254,12 +2253,9 @@ parse_partial_symbols (objfile)
const bfd_size_type external_sym_size = debug_swap->external_sym_size;
const bfd_size_type external_rfd_size = debug_swap->external_rfd_size;
const bfd_size_type external_ext_size = debug_swap->external_ext_size;
- void (*const swap_ext_in) PARAMS ((bfd *, PTR, EXTR *))
- = debug_swap->swap_ext_in;
- void (*const swap_sym_in) PARAMS ((bfd *, PTR, SYMR *))
- = debug_swap->swap_sym_in;
- void (*const swap_rfd_in) PARAMS ((bfd *, PTR, RFDT *))
- = debug_swap->swap_rfd_in;
+ void (*const swap_ext_in) (bfd *, PTR, EXTR *) = debug_swap->swap_ext_in;
+ void (*const swap_sym_in) (bfd *, PTR, SYMR *) = debug_swap->swap_sym_in;
+ void (*const swap_rfd_in) (bfd *, PTR, RFDT *) = debug_swap->swap_rfd_in;
int f_idx, s_idx;
HDRR *hdr = &debug_info->symbolic_header;
/* Running pointers */
@@ -3167,8 +3163,7 @@ handle_psymbol_enumerators (objfile, fh,
CORE_ADDR svalue;
{
const bfd_size_type external_sym_size = debug_swap->external_sym_size;
- void (*const swap_sym_in) PARAMS ((bfd *, PTR, SYMR *))
- = debug_swap->swap_sym_in;
+ void (*const swap_sym_in) (bfd *, PTR, SYMR *) = debug_swap->swap_sym_in;
char *ext_sym = ((char *) debug_info->external_sym
+ ((fh->isymBase + cur_sdx + 1) * external_sym_size));
SYMR sh;
@@ -3260,8 +3255,8 @@ psymtab_to_symtab_1 (pst, filename)
{
bfd_size_type external_sym_size;
bfd_size_type external_pdr_size;
- void (*swap_sym_in) PARAMS ((bfd *, PTR, SYMR *));
- void (*swap_pdr_in) PARAMS ((bfd *, PTR, PDR *));
+ void (*swap_sym_in) (bfd *, PTR, SYMR *);
+ void (*swap_pdr_in) (bfd *, PTR, PDR *);
int i;
struct symtab *st;
FDR *fh;
Index: monitor.h
===================================================================
RCS file: /cvs/src/src/gdb/monitor.h,v
retrieving revision 1.2
diff -u -p -r1.2 monitor.h
--- monitor.h 2000/05/28 01:12:28 1.2
+++ monitor.h 2000/05/31 19:29:30
@@ -95,16 +95,15 @@ struct monitor_ops
GDB with the value of a register. */
char *dump_registers; /* Command to dump all regs at once */
char *register_pattern; /* Pattern that picks out register from reg dump */
- void (*supply_register) PARAMS ((char *name, int namelen,
- char *val, int vallen));
+ void (*supply_register) (char *name, int namelen, char *val, int vallen);
void (*load_routine) PARAMS ((serial_t desc, char *file,
int hashmark)); /* Download routine */
int (*dumpregs) PARAMS ((void)); /* routine to dump all registers */
int (*continue_hook) PARAMS ((void)); /* Emit the continue command */
- int (*wait_filter) PARAMS ((char *buf, /* Maybe contains registers */
- int bufmax,
- int *response_length,
- struct target_waitstatus * status));
+ int (*wait_filter) (char *buf, /* Maybe contains registers */
+ int bufmax,
+ int *response_length,
+ struct target_waitstatus * status);
char *load; /* load command */
char *loadresp; /* Response to load command */
char *prompt; /* monitor command prompt */
Index: ocd.c
===================================================================
RCS file: /cvs/src/src/gdb/ocd.c,v
retrieving revision 1.3
diff -u -p -r1.3 ocd.c
--- ocd.c 2000/05/28 01:12:28 1.3
+++ ocd.c 2000/05/31 19:29:36
@@ -1409,7 +1409,7 @@ bdm_update_flash_command (args, from_tty
{
int status, pktlen;
struct cleanup *old_chain;
- void (*store_registers_tmp) PARAMS ((int));
+ void (*store_registers_tmp) (int);
if (!ocd_desc)
error ("Not connected to OCD device.");
Index: procfs.c
===================================================================
RCS file: /cvs/src/src/gdb/procfs.c,v
retrieving revision 1.15
diff -u -p -r1.15 procfs.c
--- procfs.c 2000/05/28 01:12:29 1.15
+++ procfs.c 2000/05/31 19:30:03
@@ -2598,7 +2598,7 @@ proc_set_watchpoint (pi, addr, len, wfla
every time, I don't need to lseek it. */
int
proc_iterate_over_mappings (func)
- int (*func) PARAMS ((int, CORE_ADDR));
+ int (*func) (int, CORE_ADDR);
{
struct prmap *map;
procinfo *pi;
@@ -3140,7 +3140,7 @@ proc_update_threads (pi)
int
proc_iterate_over_threads (pi, func, ptr)
procinfo *pi;
- int (*func) PARAMS ((procinfo *, procinfo *, void *));
+ int (*func) (procinfo *, procinfo *, void *);
void *ptr;
{
procinfo *thread, *next;
Index: ptx4-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/ptx4-nat.c,v
retrieving revision 1.3
diff -u -p -r1.3 ptx4-nat.c
--- ptx4-nat.c 2000/05/26 23:22:41 1.3
+++ ptx4-nat.c 2000/05/31 19:30:03
@@ -101,7 +101,7 @@ fill_fpregset (fpregsetp, regno)
/* this could use elf_interpreter() from elfread.c */
int
proc_iterate_over_mappings (func)
- int (*func) PARAMS ((int, CORE_ADDR));
+ int (*func) (int, CORE_ADDR);
{
vaddr_t curseg, memptr;
pt_vseg_t pv;
Index: remote-sim.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sim.c,v
retrieving revision 1.4
diff -u -p -r1.4 remote-sim.c
--- remote-sim.c 2000/05/28 01:12:29 1.4
+++ remote-sim.c 2000/05/31 19:30:33
@@ -42,7 +42,7 @@
extern void _initialize_remote_sim (void);
-extern int (*ui_loop_hook) PARAMS ((int signo));
+extern int (*ui_loop_hook) (int signo);
static void dump_mem (char *buf, int len);
Index: remote-utils.h
===================================================================
RCS file: /cvs/src/src/gdb/remote-utils.h,v
retrieving revision 1.2
diff -u -p -r1.2 remote-utils.h
--- remote-utils.h 2000/05/28 01:12:29 1.2
+++ remote-utils.h 2000/05/31 19:30:37
@@ -77,10 +77,10 @@ struct gr_settings
DCACHE *dcache;
char *prompt;
struct target_ops *ops;
- int (*clear_all_breakpoints) PARAMS ((void));
+ int (*clear_all_breakpoints) (void);
memxferfunc readfunc;
memxferfunc writefunc;
- void (*checkin) PARAMS ((void));
+ void (*checkin) (void);
};
extern struct gr_settings *gr_settings;
Index: remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.11
diff -u -p -r1.11 remote.c
--- remote.c 2000/05/28 01:12:29 1.11
+++ remote.c 2000/05/31 19:30:49
@@ -603,9 +603,8 @@ add_packet_config_cmd (config, name, tit
struct packet_config *config;
char *name;
char *title;
- void (*set_func) PARAMS ((char *args, int from_tty,
- struct cmd_list_element * c));
- void (*show_func) PARAMS ((char *name, int from_tty));
+ void (*set_func) (char *args, int from_tty, struct cmd_list_element * c);
+ void (*show_func) (char *name, int from_tty);
struct cmd_list_element **setlist;
struct cmd_list_element **showlist;
{
@@ -731,8 +730,8 @@ PTR sigint_remote_token;
/* These are pointers to hook functions that may be set in order to
modify resume/wait behavior for a particular architecture. */
-void (*target_resume_hook) PARAMS ((void));
-void (*target_wait_loop_hook) PARAMS ((void));
+void (*target_resume_hook) (void);
+void (*target_wait_loop_hook) (void);
\f
@@ -2445,7 +2444,7 @@ cleanup_sigint_signal_handler (void *dum
/* Send ^C to target to halt it. Target will respond, and send us a
packet. */
-static void (*ofunc) PARAMS ((int));
+static void (*ofunc) (int);
/* The command line interface's stop routine. This function is installed
as a signal handler for SIGINT. The first time a user requests a
Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.6
diff -u -p -r1.6 rs6000-tdep.c
--- rs6000-tdep.c 2000/05/28 01:12:29 1.6
+++ rs6000-tdep.c 2000/05/31 19:30:52
@@ -47,7 +47,7 @@ stepBreaks[2];
inferior under AIX. The initialization code in rs6000-nat.c sets
this hook to point to find_toc_address. */
-CORE_ADDR (*find_toc_address_hook) PARAMS ((CORE_ADDR)) = NULL;
+CORE_ADDR (*find_toc_address_hook) (CORE_ADDR) = NULL;
/* Static function prototypes */
Index: ser-ocd.c
===================================================================
RCS file: /cvs/src/src/gdb/ser-ocd.c,v
retrieving revision 1.1.1.4
diff -u -p -r1.1.1.4 ser-ocd.c
--- ser-ocd.c 2000/02/02 00:21:10 1.1.1.4
+++ ser-ocd.c 2000/05/31 19:30:57
@@ -30,7 +30,7 @@
#ifdef _WIN32
/* On Windows, this function pointer is initialized to a function in
the wiggler DLL. */
-static int (*dll_do_command) PARAMS ((const char *, char *));
+static int (*dll_do_command) (const char *, char *);
#endif
static int
Index: sol-thread.c
===================================================================
RCS file: /cvs/src/src/gdb/sol-thread.c,v
retrieving revision 1.9
diff -u -p -r1.9 sol-thread.c
--- sol-thread.c 2000/05/28 01:12:29 1.9
+++ sol-thread.c 2000/05/31 19:31:04
@@ -857,7 +857,7 @@ sol_thread_create_inferior (exec_file, a
*/
/* Saved pointer to previous owner of the new_objfile event. */
-static void (*target_new_objfile_chain) PARAMS ((struct objfile *));
+static void (*target_new_objfile_chain) (struct objfile *);
void
sol_thread_new_objfile (objfile)
Index: sparcl-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sparcl-tdep.c,v
retrieving revision 1.4
diff -u -p -r1.4 sparcl-tdep.c
--- sparcl-tdep.c 2000/05/28 01:12:29 1.4
+++ sparcl-tdep.c 2000/05/31 19:31:20
@@ -560,9 +560,9 @@ download (target_name, args, from_tty, w
char *target_name;
char *args;
int from_tty;
- void (*write_routine) PARAMS ((bfd * from_bfd, asection * from_sec,
- file_ptr from_addr, bfd_vma to_addr, int len));
- void (*start_routine) PARAMS ((bfd_vma entry));
+ void (*write_routine) (bfd * from_bfd, asection * from_sec,
+ file_ptr from_addr, bfd_vma to_addr, int len);
+ void (*start_routine) (bfd_vma entry);
{
struct cleanup *old_chain;
asection *section;
Index: stabsread.h
===================================================================
RCS file: /cvs/src/src/gdb/stabsread.h,v
retrieving revision 1.2
diff -u -p -r1.2 stabsread.h
--- stabsread.h 2000/05/28 01:12:29 1.2
+++ stabsread.h 2000/05/31 19:31:29
@@ -213,7 +213,7 @@ extern void elfstab_offset_sections (str
extern void process_later
(struct symbol *, char *,
- int (*f) PARAMS ((struct objfile *, struct symbol *, char *)));
+ int (*f) (struct objfile *, struct symbol *, char *));
extern int symbol_reference_defined (char **);
Index: stack.c
===================================================================
RCS file: /cvs/src/src/gdb/stack.c,v
retrieving revision 1.5
diff -u -p -r1.5 stack.c
--- stack.c 2000/05/28 01:12:29 1.5
+++ stack.c 2000/05/31 19:31:32
@@ -46,7 +46,7 @@ void args_info (char *, int);
void locals_info (char *, int);
-void (*selected_frame_level_changed_hook) PARAMS ((int));
+void (*selected_frame_level_changed_hook) (int);
void _initialize_stack (void);
Index: symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.11
diff -u -p -r1.11 symfile.c
--- symfile.c 2000/05/28 01:12:29 1.11
+++ symfile.c 2000/05/31 19:31:38
@@ -68,9 +68,9 @@ void (*show_load_progress) (const char *
unsigned long section_size,
unsigned long total_sent,
unsigned long total_size);
-void (*pre_add_symbol_hook) PARAMS ((char *));
-void (*post_add_symbol_hook) PARAMS ((void));
-void (*target_new_objfile_hook) PARAMS ((struct objfile *));
+void (*pre_add_symbol_hook) (char *);
+void (*post_add_symbol_hook) (void);
+void (*target_new_objfile_hook) (struct objfile *);
static void clear_symtab_users_cleanup (void *ignore);
@@ -2554,8 +2554,7 @@ int overlay_cache_invalid = 0; /* True i
/* Target vector for refreshing overlay mapped state */
static void simple_overlay_update (struct obj_section *);
-void (*target_overlay_update) PARAMS ((struct obj_section *))
-= simple_overlay_update;
+void (*target_overlay_update) (struct obj_section *) = simple_overlay_update;
/* Function: section_is_overlay (SECTION)
Returns true if SECTION has VMA not equal to LMA, ie.
Index: symfile.h
===================================================================
RCS file: /cvs/src/src/gdb/symfile.h,v
retrieving revision 1.4
diff -u -p -r1.4 symfile.h
--- symfile.h 2000/05/28 01:12:29 1.4
+++ symfile.h 2000/05/31 19:31:38
@@ -88,13 +88,13 @@ struct sym_fns
called during symbol_file_add, when we begin debugging an entirely new
program. */
- void (*sym_new_init) PARAMS ((struct objfile *));
+ void (*sym_new_init) (struct objfile *);
/* Reads any initial information from a symbol file, and initializes the
struct sym_fns SF in preparation for sym_read(). It is called every
time we read a symbol file for any reason. */
- void (*sym_init) PARAMS ((struct objfile *));
+ void (*sym_init) (struct objfile *);
/* sym_read (objfile, mainline)
Reads a symbol file into a psymtab (or possibly a symtab).
@@ -104,12 +104,12 @@ struct sym_fns
symbol file (e.g. shared library or dynamically loaded file)
is being read. */
- void (*sym_read) PARAMS ((struct objfile *, int));
+ void (*sym_read) (struct objfile *, int);
/* Called when we are finished with an objfile. Should do all cleanup
that is specific to the object file format for the particular objfile. */
- void (*sym_finish) PARAMS ((struct objfile *));
+ void (*sym_finish) (struct objfile *);
/* This function produces a file-dependent section_offsets structure,
allocated in the objfile's storage, and based on the parameter.
@@ -118,7 +118,7 @@ struct sym_fns
a string, where NULL means the default, and others are parsed in a file
dependent way. */
- void (*sym_offsets) PARAMS ((struct objfile *, struct section_addr_info *));
+ void (*sym_offsets) (struct objfile *, struct section_addr_info *);
/* Finds the next struct sym_fns. They are allocated and initialized
in whatever module implements the functions pointed to; an
Index: symtab.h
===================================================================
RCS file: /cvs/src/src/gdb/symtab.h,v
retrieving revision 1.9
diff -u -p -r1.9 symtab.h
--- symtab.h 2000/05/29 13:18:15 1.9
+++ symtab.h 2000/05/31 19:31:48
@@ -1011,7 +1011,7 @@ struct partial_symtab
/* Pointer to function which will read in the symtab corresponding to
this psymtab. */
- void (*read_symtab) PARAMS ((struct partial_symtab *));
+ void (*read_symtab) (struct partial_symtab *);
/* Information that lets read_symtab() locate the part of the symbol table
that this psymtab corresponds to. This information is private to the
Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.8
diff -u -p -r1.8 target.c
--- target.c 2000/05/28 01:12:30 1.8
+++ target.c 2000/05/31 19:31:51
@@ -2126,7 +2126,7 @@ Use \"info signals\" for a list of symbo
}
\f
/* Returns zero to leave the inferior alone, one to interrupt it. */
-int (*target_activity_function) PARAMS ((void));
+int (*target_activity_function) (void);
int target_activity_fd;
\f
/* Convert a normal process ID to a string. Returns the string in a static
Index: target.h
===================================================================
RCS file: /cvs/src/src/gdb/target.h,v
retrieving revision 1.5
diff -u -p -r1.5 target.h
--- target.h 2000/05/28 01:12:30 1.5
+++ target.h 2000/05/31 19:31:53
@@ -316,7 +316,7 @@ enum target_signal target_signal_from_na
on TARGET_ACTIVITY_FD. */
extern int target_activity_fd;
/* Returns zero to leave the inferior alone, one to interrupt it. */
-extern int (*target_activity_function) PARAMS ((void));
+extern int (*target_activity_function) (void);
\f
struct thread_info; /* fwd decl for parameter list below: */
@@ -327,19 +327,19 @@ struct target_ops
char *to_doc; /* Documentation. Does not include trailing
newline, and starts with a one-line descrip-
tion (probably similar to to_longname). */
- void (*to_open) PARAMS ((char *, int));
- void (*to_close) PARAMS ((int));
- void (*to_attach) PARAMS ((char *, int));
- void (*to_post_attach) PARAMS ((int));
- void (*to_require_attach) PARAMS ((char *, int));
- void (*to_detach) PARAMS ((char *, int));
- void (*to_require_detach) PARAMS ((int, char *, int));
- void (*to_resume) PARAMS ((int, int, enum target_signal));
- int (*to_wait) PARAMS ((int, struct target_waitstatus *));
- void (*to_post_wait) PARAMS ((int, int));
- void (*to_fetch_registers) PARAMS ((int));
- void (*to_store_registers) PARAMS ((int));
- void (*to_prepare_to_store) PARAMS ((void));
+ void (*to_open) (char *, int);
+ void (*to_close) (int);
+ void (*to_attach) (char *, int);
+ void (*to_post_attach) (int);
+ void (*to_require_attach) (char *, int);
+ void (*to_detach) (char *, int);
+ void (*to_require_detach) (int, char *, int);
+ void (*to_resume) (int, int, enum target_signal);
+ int (*to_wait) (int, struct target_waitstatus *);
+ void (*to_post_wait) (int, int);
+ void (*to_fetch_registers) (int);
+ void (*to_store_registers) (int);
+ void (*to_prepare_to_store) (void);
/* Transfer LEN bytes of memory between GDB address MYADDR and
target address MEMADDR. If WRITE, transfer them to the target, else
@@ -359,9 +359,8 @@ struct target_ops
transfer right at MEMADDR, but we could transfer at least
something at MEMADDR + N. */
- int (*to_xfer_memory) PARAMS ((CORE_ADDR memaddr, char *myaddr,
- int len, int write,
- struct target_ops * target));
+ int (*to_xfer_memory) (CORE_ADDR memaddr, char *myaddr,
+ int len, int write, struct target_ops * target);
#if 0
/* Enable this after 4.12. */
@@ -376,60 +375,62 @@ struct target_ops
If we don't find anything, set *ADDR_FOUND to (CORE_ADDR)0 and
return. */
- void (*to_search) PARAMS ((int len, char *data, char *mask,
- CORE_ADDR startaddr, int increment,
- CORE_ADDR lorange, CORE_ADDR hirange,
- CORE_ADDR * addr_found, char *data_found));
+ void (*to_search) (int len, char *data, char *mask,
+ CORE_ADDR startaddr, int increment,
+ CORE_ADDR lorange, CORE_ADDR hirange,
+ CORE_ADDR * addr_found, char *data_found);
#define target_search(len, data, mask, startaddr, increment, lorange, hirange, addr_found, data_found) \
(*current_target.to_search) (len, data, mask, startaddr, increment, \
lorange, hirange, addr_found, data_found)
#endif /* 0 */
- void (*to_files_info) PARAMS ((struct target_ops *));
- int (*to_insert_breakpoint) PARAMS ((CORE_ADDR, char *));
- int (*to_remove_breakpoint) PARAMS ((CORE_ADDR, char *));
- void (*to_terminal_init) PARAMS ((void));
- void (*to_terminal_inferior) PARAMS ((void));
- void (*to_terminal_ours_for_output) PARAMS ((void));
- void (*to_terminal_ours) PARAMS ((void));
- void (*to_terminal_info) PARAMS ((char *, int));
- void (*to_kill) PARAMS ((void));
- void (*to_load) PARAMS ((char *, int));
- int (*to_lookup_symbol) PARAMS ((char *, CORE_ADDR *));
- void (*to_create_inferior) PARAMS ((char *, char *, char **));
- void (*to_post_startup_inferior) PARAMS ((int));
- void (*to_acknowledge_created_inferior) PARAMS ((int));
- void (*to_clone_and_follow_inferior) PARAMS ((int, int *));
- void (*to_post_follow_inferior_by_clone) PARAMS ((void));
- int (*to_insert_fork_catchpoint) PARAMS ((int));
- int (*to_remove_fork_catchpoint) PARAMS ((int));
- int (*to_insert_vfork_catchpoint) PARAMS ((int));
- int (*to_remove_vfork_catchpoint) PARAMS ((int));
- int (*to_has_forked) PARAMS ((int, int *));
- int (*to_has_vforked) PARAMS ((int, int *));
- int (*to_can_follow_vfork_prior_to_exec) PARAMS ((void));
- void (*to_post_follow_vfork) PARAMS ((int, int, int, int));
- int (*to_insert_exec_catchpoint) PARAMS ((int));
- int (*to_remove_exec_catchpoint) PARAMS ((int));
- int (*to_has_execd) PARAMS ((int, char **));
- int (*to_reported_exec_events_per_exec_call) PARAMS ((void));
- int (*to_has_syscall_event) PARAMS ((int, enum target_waitkind *, int *));
- int (*to_has_exited) PARAMS ((int, int, int *));
- void (*to_mourn_inferior) PARAMS ((void));
- int (*to_can_run) PARAMS ((void));
- void (*to_notice_signals) PARAMS ((int pid));
- int (*to_thread_alive) PARAMS ((int pid));
- void (*to_find_new_threads) PARAMS ((void));
- char *(*to_pid_to_str) PARAMS ((int));
- char *(*to_extra_thread_info) PARAMS ((struct thread_info *));
- void (*to_stop) PARAMS ((void));
- int (*to_query) PARAMS ((int /*char */ , char *, char *, int *));
+ void (*to_files_info) (struct target_ops *);
+ int (*to_insert_breakpoint) (CORE_ADDR, char *);
+ int (*to_remove_breakpoint) (CORE_ADDR, char *);
+ void (*to_terminal_init) (void);
+ void (*to_terminal_inferior) (void);
+ void (*to_terminal_ours_for_output) (void);
+ void (*to_terminal_ours) (void);
+ void (*to_terminal_info) (char *, int);
+ void (*to_kill) (void);
+ void (*to_load) (char *, int);
+ int (*to_lookup_symbol) (char *, CORE_ADDR *);
+ void (*to_create_inferior) (char *, char *, char **);
+ void (*to_post_startup_inferior) (int);
+ void (*to_acknowledge_created_inferior) (int);
+ void (*to_clone_and_follow_inferior) (int, int *);
+ void (*to_post_follow_inferior_by_clone) (void);
+ int (*to_insert_fork_catchpoint) (int);
+ int (*to_remove_fork_catchpoint) (int);
+ int (*to_insert_vfork_catchpoint) (int);
+ int (*to_remove_vfork_catchpoint) (int);
+ int (*to_has_forked) (int, int *);
+ int (*to_has_vforked) (int, int *);
+ int (*to_can_follow_vfork_prior_to_exec) (void);
+ void (*to_post_follow_vfork) (int, int, int, int);
+ int (*to_insert_exec_catchpoint) (int);
+ int (*to_remove_exec_catchpoint) (int);
+ int (*to_has_execd) (int, char **);
+ int (*to_reported_exec_events_per_exec_call) (void);
+ int (*to_has_syscall_event) (int, enum target_waitkind *, int *);
+ int (*to_has_exited) (int, int, int *);
+ void (*to_mourn_inferior) (void);
+ int (*to_can_run) (void);
+ void (*to_notice_signals) (int pid);
+ int (*to_thread_alive) (int pid);
+ void (*to_find_new_threads) (void);
+ char *(*to_pid_to_str) (int);
+ char *(*to_extra_thread_info) (struct thread_info *);
+ void (*to_stop) (void);
+ int (*to_query) (int /*char */ , char *, char *, int *);
void (*to_rcmd) (char *command, struct ui_file *output);
- struct symtab_and_line *(*to_enable_exception_callback) PARAMS ((enum exception_event_kind, int));
- struct exception_event_record *(*to_get_current_exception_event) PARAMS ((void));
- char *(*to_pid_to_exec_file) PARAMS ((int pid));
- char *(*to_core_file_to_sym_file) PARAMS ((char *));
+ struct symtab_and_line *(*to_enable_exception_callback) (enum
+ exception_event_kind,
+ int);
+ struct exception_event_record *(*to_get_current_exception_event) (void);
+ char *(*to_pid_to_exec_file) (int pid);
+ char *(*to_core_file_to_sym_file) (char *);
enum strata to_stratum;
struct target_ops
*DONT_USE; /* formerly to_next */
@@ -1101,7 +1102,7 @@ extern char *normal_pid_to_str (int pid)
* can receive this notification (something like with signal handlers).
*/
-extern void (*target_new_objfile_hook) PARAMS ((struct objfile *));
+extern void (*target_new_objfile_hook) (struct objfile *);
#ifndef target_pid_or_tid_to_str
#define target_pid_or_tid_to_str(ID) \
Index: top.c
===================================================================
RCS file: /cvs/src/src/gdb/top.c,v
retrieving revision 1.13
diff -u -p -r1.13 top.c
--- top.c 2000/05/28 01:12:32 1.13
+++ top.c 2000/05/31 19:31:59
@@ -285,7 +285,7 @@ char gdb_dirbuf[1024];
The function receives two args: an input stream,
and a prompt string. */
-void (*window_hook) PARAMS ((FILE *, char *));
+void (*window_hook) (FILE *, char *);
int epoch_interface;
int xgdb_verbose;
@@ -392,31 +392,31 @@ static void stop_sig (int);
/* Called after most modules have been initialized, but before taking users
command file. */
-void (*init_ui_hook) PARAMS ((char *argv0));
+void (*init_ui_hook) (char *argv0);
/* This hook is called from within gdb's many mini-event loops which could
steal control from a real user interface's event loop. It returns
non-zero if the user is requesting a detach, zero otherwise. */
-int (*ui_loop_hook) PARAMS ((int));
+int (*ui_loop_hook) (int);
/* Called instead of command_loop at top level. Can be invoked via
return_to_top_level. */
-void (*command_loop_hook) PARAMS ((void));
+void (*command_loop_hook) (void);
/* Called from print_frame_info to list the line we stopped in. */
-void (*print_frame_info_listing_hook) PARAMS ((struct symtab * s, int line,
- int stopline, int noerror));
+void (*print_frame_info_listing_hook) (struct symtab * s, int line,
+ int stopline, int noerror);
/* Replaces most of query. */
-int (*query_hook) PARAMS ((const char *, va_list));
+int (*query_hook) (const char *, va_list);
/* Replaces most of warning. */
-void (*warning_hook) PARAMS ((const char *, va_list));
+void (*warning_hook) (const char *, va_list);
/* These three functions support getting lines of text from the user. They
are used in sequence. First readline_begin_hook is called with a text
@@ -429,51 +429,51 @@ void (*warning_hook) PARAMS ((const char
to notify the GUI that we are done with the interaction window and it
can close it. */
-void (*readline_begin_hook) PARAMS ((char *,...));
-char *(*readline_hook) PARAMS ((char *));
-void (*readline_end_hook) PARAMS ((void));
+void (*readline_begin_hook) (char *, ...);
+char *(*readline_hook) (char *);
+void (*readline_end_hook) (void);
/* Called as appropriate to notify the interface of the specified breakpoint
conditions. */
-void (*create_breakpoint_hook) PARAMS ((struct breakpoint * bpt));
-void (*delete_breakpoint_hook) PARAMS ((struct breakpoint * bpt));
-void (*modify_breakpoint_hook) PARAMS ((struct breakpoint * bpt));
+void (*create_breakpoint_hook) (struct breakpoint * bpt);
+void (*delete_breakpoint_hook) (struct breakpoint * bpt);
+void (*modify_breakpoint_hook) (struct breakpoint * bpt);
/* Called as appropriate to notify the interface that we have attached
to or detached from an already running process. */
-void (*attach_hook) PARAMS ((void));
-void (*detach_hook) PARAMS ((void));
+void (*attach_hook) (void);
+void (*detach_hook) (void);
/* Called during long calculations to allow GUI to repair window damage, and to
check for stop buttons, etc... */
-void (*interactive_hook) PARAMS ((void));
+void (*interactive_hook) (void);
/* Called when the registers have changed, as a hint to a GUI
to minimize window update. */
-void (*registers_changed_hook) PARAMS ((void));
+void (*registers_changed_hook) (void);
/* Tell the GUI someone changed the register REGNO. -1 means
that the caller does not know which register changed or
that several registers have changed (see value_assign). */
-void (*register_changed_hook) PARAMS ((int regno));
+void (*register_changed_hook) (int regno);
/* Tell the GUI someone changed LEN bytes of memory at ADDR */
-void (*memory_changed_hook) PARAMS ((CORE_ADDR addr, int len));
+void (*memory_changed_hook) (CORE_ADDR addr, int len);
/* Called when going to wait for the target. Usually allows the GUI to run
while waiting for target events. */
-int (*target_wait_hook) PARAMS ((int pid, struct target_waitstatus * status));
+int (*target_wait_hook) (int pid, struct target_waitstatus * status);
/* Used by UI as a wrapper around command execution. May do various things
like enabling/disabling buttons, etc... */
-void (*call_command_hook) PARAMS ((struct cmd_list_element * c, char *cmd,
- int from_tty));
+void (*call_command_hook) (struct cmd_list_element * c, char *cmd,
+ int from_tty);
/* Called after a `set' command has finished. Is only run if the
`set' command succeeded. */
@@ -482,7 +482,7 @@ void (*set_hook) (struct cmd_list_elemen
/* Called when the current thread changes. Argument is thread id. */
-void (*context_hook) PARAMS ((int id));
+void (*context_hook) (int id);
/* Takes control from error (). Typically used to prevent longjmps out of the
middle of the GUI. Usually used in conjunction with a catch routine. */
@@ -782,7 +782,7 @@ read_command_file (stream)
\f
extern void init_proc (void);
-void (*pre_init_ui_hook) PARAMS ((void));
+void (*pre_init_ui_hook) (void);
#ifdef __MSDOS__
void
@@ -2939,7 +2939,7 @@ make_cleanup_free_command_lines (struct
struct cmd_list_element *
add_info (name, fun, doc)
char *name;
- void (*fun) PARAMS ((char *, int));
+ void (*fun) (char *, int);
char *doc;
{
return add_cmd (name, no_class, fun, doc, &infolist);
@@ -3013,7 +3013,7 @@ struct cmd_list_element *
add_com (name, class, fun, doc)
char *name;
enum command_class class;
- void (*fun) PARAMS ((char *, int));
+ void (*fun) (char *, int);
char *doc;
{
return add_cmd (name, class, fun, doc, &cmdlist);
Index: tracepoint.c
===================================================================
RCS file: /cvs/src/src/gdb/tracepoint.c,v
retrieving revision 1.6
diff -u -p -r1.6 tracepoint.c
--- tracepoint.c 2000/05/28 01:12:32 1.6
+++ tracepoint.c 2000/05/31 19:32:02
@@ -58,9 +58,9 @@
extern int info_verbose;
-extern void (*readline_begin_hook) PARAMS ((char *,...));
-extern char *(*readline_hook) PARAMS ((char *));
-extern void (*readline_end_hook) PARAMS ((void));
+extern void (*readline_begin_hook) (char *, ...);
+extern char *(*readline_hook) (char *);
+extern void (*readline_end_hook) (void);
extern void x_command (char *, int);
extern int addressprint; /* Print machine addresses? */
Index: tracepoint.h
===================================================================
RCS file: /cvs/src/src/gdb/tracepoint.h,v
retrieving revision 1.2
diff -u -p -r1.2 tracepoint.h
--- tracepoint.h 2000/05/28 01:12:32 1.2
+++ tracepoint.h 2000/05/31 19:32:02
@@ -115,11 +115,11 @@ extern unsigned long trace_running_p;
/* A hook used to notify the UI of tracepoint operations */
-void (*create_tracepoint_hook) PARAMS ((struct tracepoint *));
-void (*delete_tracepoint_hook) PARAMS ((struct tracepoint *));
-void (*modify_tracepoint_hook) PARAMS ((struct tracepoint *));
-void (*trace_find_hook) PARAMS ((char *arg, int from_tty));
-void (*trace_start_stop_hook) PARAMS ((int start, int from_tty));
+void (*create_tracepoint_hook) (struct tracepoint *);
+void (*delete_tracepoint_hook) (struct tracepoint *);
+void (*modify_tracepoint_hook) (struct tracepoint *);
+void (*trace_find_hook) (char *arg, int from_tty);
+void (*trace_start_stop_hook) (int start, int from_tty);
struct tracepoint *get_tracepoint_by_number (char **, int, int);
int get_traceframe_number (void);
Index: utils.c
===================================================================
RCS file: /cvs/src/src/gdb/utils.c,v
retrieving revision 1.14
diff -u -p -r1.14 utils.c
--- utils.c 2000/05/28 01:12:33 1.14
+++ utils.c 2000/05/31 19:32:08
@@ -58,7 +58,7 @@
/* readline defines this. */
#undef savestring
-void (*error_begin_hook) PARAMS ((void));
+void (*error_begin_hook) (void);
/* Holds the last error message issued by gdb */
@@ -426,7 +426,7 @@ null_cleanup (void *arg)
cmd_continuation. The new continuation will be added at the front.*/
void
add_continuation (continuation_hook, arg_list)
- void (*continuation_hook) PARAMS ((struct continuation_arg *));
+ void (*continuation_hook) (struct continuation_arg *);
struct continuation_arg *arg_list;
{
struct continuation *continuation_ptr;
@@ -488,7 +488,7 @@ discard_all_continuations ()
intermediate_continuation. The new continuation will be added at the front.*/
void
add_intermediate_continuation (continuation_hook, arg_list)
- void (*continuation_hook) PARAMS ((struct continuation_arg *));
+ void (*continuation_hook) (struct continuation_arg *);
struct continuation_arg *arg_list;
{
struct continuation *continuation_ptr;
@@ -1421,8 +1421,8 @@ static void printchar (int c, void (*do_
static void
printchar (c, do_fputs, do_fprintf, stream, quoter)
int c;
- void (*do_fputs) PARAMS ((const char *, struct ui_file*));
- void (*do_fprintf) PARAMS ((struct ui_file*, const char *, ...));
+ void (*do_fputs) (const char *, struct ui_file *);
+ void (*do_fprintf) (struct ui_file *, const char *, ...);
struct ui_file *stream;
int quoter;
{
Index: v850ice.c
===================================================================
RCS file: /cvs/src/src/gdb/v850ice.c,v
retrieving revision 1.2
diff -u -p -r1.2 v850ice.c
--- v850ice.c 2000/05/28 01:12:33 1.2
+++ v850ice.c 2000/05/31 19:32:11
@@ -54,7 +54,7 @@ extern void nexti_command (char *, int);
extern void continue_command (char *, int);
-extern int (*ui_loop_hook) PARAMS ((int));
+extern int (*ui_loop_hook) (int);
/* Prototypes for local functions */
static int init_hidden_window (void);
@@ -855,7 +855,7 @@ static void
do_gdb (cmd, str, func, count)
char *cmd;
char *str;
- void (*func) PARAMS ((char *, int));
+ void (*func) (char *, int);
int count;
{
ReplyMessage ((LRESULT) 1);
Index: varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/varobj.c,v
retrieving revision 1.5
diff -u -p -r1.5 varobj.c
--- varobj.c 2000/05/28 01:12:33 1.5
+++ varobj.c 2000/05/31 19:32:24
@@ -287,28 +287,28 @@ struct language_specific
enum varobj_languages language;
/* The number of children of PARENT. */
- int (*number_of_children) PARAMS ((struct varobj * parent));
+ int (*number_of_children) (struct varobj * parent);
/* The name (expression) of a root varobj. */
- char *(*name_of_variable) PARAMS ((struct varobj * parent));
+ char *(*name_of_variable) (struct varobj * parent);
/* The name of the INDEX'th child of PARENT. */
- char *(*name_of_child) PARAMS ((struct varobj * parent, int index));
+ char *(*name_of_child) (struct varobj * parent, int index);
/* The value_ptr of the root variable ROOT. */
- value_ptr (*value_of_root) PARAMS ((struct varobj ** root_handle));
+ value_ptr (*value_of_root) (struct varobj ** root_handle);
/* The value_ptr of the INDEX'th child of PARENT. */
- value_ptr (*value_of_child) PARAMS ((struct varobj * parent, int index));
+ value_ptr (*value_of_child) (struct varobj * parent, int index);
/* The type of the INDEX'th child of PARENT. */
- struct type *(*type_of_child) PARAMS ((struct varobj * parent, int index));
+ struct type *(*type_of_child) (struct varobj * parent, int index);
/* Is VAR editable? */
- int (*variable_editable) PARAMS ((struct varobj * var));
+ int (*variable_editable) (struct varobj * var);
/* The current value of VAR. */
- char *(*value_of_variable) PARAMS ((struct varobj * var));
+ char *(*value_of_variable) (struct varobj * var);
};
/* Array of known source language routines. */
Index: win32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.8
diff -u -p -r1.8 win32-nat.c
--- win32-nat.c 2000/05/28 01:12:33 1.8
+++ win32-nat.c 2000/05/31 19:32:27
@@ -52,7 +52,7 @@
#include <unistd.h>
/* The ui's event loop. */
-extern int (*ui_loop_hook) PARAMS ((int signo));
+extern int (*ui_loop_hook) (int signo);
/* If we're not using the old Cygwin header file set, define the
following which never should have been in the generic Win32 API
Index: wince.c
===================================================================
RCS file: /cvs/src/src/gdb/wince.c,v
retrieving revision 1.6
diff -u -p -r1.6 wince.c
--- wince.c 2000/05/28 01:12:33 1.6
+++ wince.c 2000/05/31 19:32:30
@@ -58,7 +58,7 @@
#include <time.h>
/* The ui's event loop. */
-extern int (*ui_loop_hook) PARAMS ((int signo));
+extern int (*ui_loop_hook) (int signo);
/* If we're not using the old Cygwin header file set, define the
following which never should have been in the generic Win32 API
Index: xcoffsolib.c
===================================================================
RCS file: /cvs/src/src/gdb/xcoffsolib.c,v
retrieving revision 1.3
diff -u -p -r1.3 xcoffsolib.c
--- xcoffsolib.c 2000/05/28 01:12:33 1.3
+++ xcoffsolib.c 2000/05/31 19:32:34
@@ -34,7 +34,7 @@
hook is initialized in by rs6000-nat.c. If not, it is currently left
NULL and never called. */
-void (*xcoff_relocate_symtab_hook) PARAMS ((unsigned int)) = NULL;
+void (*xcoff_relocate_symtab_hook) (unsigned int) = NULL;
#ifdef SOLIB_SYMBOLS_MANUAL
Index: xcoffsolib.h
===================================================================
RCS file: /cvs/src/src/gdb/xcoffsolib.h,v
retrieving revision 1.1.1.2
diff -u -p -r1.1.1.2 xcoffsolib.h
--- xcoffsolib.h 1999/07/07 20:11:18 1.1.1.2
+++ xcoffsolib.h 2000/05/31 19:32:34
@@ -58,4 +58,4 @@ extern struct vmap *vmap;
/* Hook for symbol table relocation at runtime. */
-extern void (*xcoff_relocate_symtab_hook) PARAMS ((unsigned int));
+extern void (*xcoff_relocate_symtab_hook) (unsigned int);
Index: config/rs6000/tm-rs6000.h
===================================================================
RCS file: /cvs/src/src/gdb/config/rs6000/tm-rs6000.h,v
retrieving revision 1.4
diff -u -p -r1.4 tm-rs6000.h
--- tm-rs6000.h 2000/05/28 01:12:39 1.4
+++ tm-rs6000.h 2000/05/31 19:33:06
@@ -512,7 +512,7 @@ extern void rs6000_fix_call_dummy (char
/* Hook in rs6000-tdep.c for determining the TOC address when
calling functions in the inferior. */
extern
-CORE_ADDR (*find_toc_address_hook) PARAMS ((CORE_ADDR));
+CORE_ADDR (*find_toc_address_hook) (CORE_ADDR);
/* xcoffread.c provides a function to determine the TOC offset
for a given object file.
Index: tui/tui.h
===================================================================
RCS file: /cvs/src/src/gdb/tui/tui.h,v
retrieving revision 1.3
diff -u -p -r1.3 tui.h
--- tui.h 2000/05/28 01:12:42 1.3
+++ tui.h 2000/05/31 19:33:58
@@ -26,15 +26,15 @@
/* Opaque data type */
typedef char *Opaque;
typedef
-Opaque (*OpaqueFuncPtr) PARAMS ((va_list));
+Opaque (*OpaqueFuncPtr) (va_list);
typedef char **OpaqueList;
typedef OpaqueList OpaquePtr;
/* Generic function pointer */
- typedef void (*TuiVoidFuncPtr) PARAMS ((va_list));
- typedef int (*TuiIntFuncPtr) PARAMS ((va_list));
+ typedef void (*TuiVoidFuncPtr) (va_list);
+ typedef int (*TuiIntFuncPtr) (va_list);
/*
- typedef Opaque (*TuiOpaqueFuncPtr) PARAMS ((va_list));
+ typedef Opaque (*TuiOpaqueFuncPtr) (va_list);
*/
typedef OpaqueFuncPtr TuiOpaqueFuncPtr;
Index: tui/tuiIO.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tuiIO.c,v
retrieving revision 1.2
diff -u -p -r1.2 tuiIO.c
--- tuiIO.c 2000/05/28 01:12:42 1.2
+++ tuiIO.c 2000/05/31 19:34:01
@@ -112,7 +112,7 @@ void
tui_tputs (str, affcnt, putfunc)
char *str;
int affcnt;
- int (*putfunc) PARAMS ((int));
+ int (*putfunc) (int);
{
extern char *rl_prompt; /* the prompt string */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [rfa] Add a name field to ``struct floatformat''
[not found] <9703.959716280@upchuck>
@ 2000-05-30 15:47 ` Andrew Cagney
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Cagney @ 2000-05-30 15:47 UTC (permalink / raw)
To: law; +Cc: DJ Delorie, nickc, gcc-patches, gdb-patches, binutils
Jeffrey A Law wrote:
>
> In message < 200005301856.OAA10673@envy.delorie.com >you write:
> >
> > > : ! Copyright (C) 1991, 1994, 1999-2000 Free Software Foundation, Inc.
> > >
> > > I believe that the FSF lawyer has said that we should avoid date
> > > ranges in copyright statements, since it may not be clear if the range
> > > is inclusive, exclusive or somehting else. Instead, each year should
> > > be specified explicitly.
> >
> > I've heard this also; apparently a year range isn't legal. Only a
> > list of years are legal. More info in the GNU maintainer's manual
> > (although this point isn't mentioned) or at this url in particular:
> More correctly, there's questions about its legality. Thus using ranges
> is considered inappropriate for FSF code. I had to go through all of the
> gcc sources and fix them. Ugh.
An guess who gets to fix all the GDB code (when I'd just ``fixed it'').
Andew
From ac131313@cygnus.com Tue May 30 15:49:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: Kevin Buettner <kevinb@cygnus.com>
Cc: GDB Patches <gdb-patches@sourceware.cygnus.com>
Subject: Re: [rfa] Add a name field to ``struct floatformat''
Date: Tue, 30 May 2000 15:49:00 -0000
Message-id: <3934454E.AAB68F28@cygnus.com>
References: <3933676F.676D861C@cygnus.com> <1000530153706.ZM32196@ocotillo.lan>
X-SW-Source: 2000-05/msg00472.html
Content-length: 821
[pruned to just GDB :-)]
Kevin Buettner wrote:
>
> On May 30, 5:02pm, Andrew Cagney wrote:
>
> > The attached adds a name field to ``struct floatformat''. It would be
> > going into both the binutils+gdb and gcc repositories. Since GDB likes
> > to change its floatingpoint format on the fly, being about to print the
> > format's name out (for debugging) is very helpful.
> >
> > Any problems? (This code was once GDB's anyway :-).
>
> In doing the IA-64 gdb port, I added floatformat_ia64_ext to
> ia64-tdep.c (in the gdb sources). We'll need to add a name to this
> struct and it probably should be moved from ia64-tdep.c to the
> appropriate files in libiberty.
Yes.
Did you like how GDB added floatformat_to_double() to libiberty and then
replaced that with a local floatformat_to_doublest() ;-/
Andrew
From kevinb@cygnus.com Tue May 30 16:24:00 2000
From: Kevin Buettner <kevinb@cygnus.com>
To: gdb-patches@sourceware.cygnus.com
Subject: [PATCH RFC] PARAMS elimination - phase 2
Date: Tue, 30 May 2000 16:24:00 -0000
Message-id: <1000530232352.ZM5368@ocotillo.lan>
X-SW-Source: 2000-05/msg00473.html
Content-length: 74027
Below are changes representing phase 2 of the campaign to purge the use
of PARAMS from the gdb sources.
I made these changes with help from a script similar to the one that I
posted earlier. (It's identical but for one line.) After running the
script, the initial indent was incorrect for declarations appearing in
structs and within the old pre-ansi parameter declarations. I fixed
some of these initial indents by hand. For the others, I reindented
the struct declaration in which the declarations appeared. (I used
"indent -sbi2" since that seemed to be the convention for the brace
placement after the struct keyword.) If you look carefully, you'll
notice that there are a few places where other fields within a struct
declaration have been reformatted. I was torn between putting these
fields back the way they were prior to running indent and leaving them
in their newly indented state. In the end I chose the latter option
of leaving them in their newly indented state. If you have concerns
about this, please examine DONT_USE, to_sections, and to_sections_end
in the patch to target.h below.
After running the script there were still a few occurrences of PARAMS
left in the sources. I eliminated the remainder of these by hand,
again using ``indent'' on declarations which spanned multiple lines.
I have done a test build on an IA-32 machine running GNU/Linux and
have seen no problems. In addition, I've examined every change in the
patch at least once.
Andrew has recommended that I give a one day notice and then, unless
there are objections, commit the changes. So... unless I see objections
to this patch before then, I plan to commit these changes tomorrow
evening at around 5:00pm MST (which is midnight GMT of Thursday, June 1).
Once this patch is applied, there should be no occurrences of
PARAMS left in the gdb sources aside from the ChangeLog entries
and gnu-regex.c. The latter file is supposed to track the glibc
version and I will probably need to revert my changes of last
weekend for this file.
Also, note that I haven't touched the insight sources yet, so if you
think of the gdb sources as gdb+insight, you'll likely still seem
some occurrences of PARAMS.
* annotate.c, annotate.h, breakpoint.c, command.c, command.h,
copying.awk, corefile.c, d10v-tdep.c, d30v-tdep.c, dbxread.c,
dcache.c, dcache.h, dsrec.c, dve3900-rom.c, exec.c,
fork-child.c, gdbcore.h, hpux-thread.c, language.h,
linux-thread.c, mdebugread.c, monitor.h, ocd.c, procfs.c,
ptx4-nat.c, remote-sim.c, remote-utils.h, remote.c,
rs6000-tdep.c, ser-ocd.c, sol-thread.c, sparcl-tdep.c,
stabsread.h, stack.c, symfile.c, symfile.h, symtab.c,
symtab.h, target.c, target.h, top.c, tracepoint.c,
tracepoint.h, utils.c, v850ice.c, varobj.c, win32-nat.c,
wince.c, xcoffsolib.c, xcoffsolib.h,
config/rs6000/tm-rs6000.h, testsuite/gdb.base/callfuncs.c,
testsuite/gdb.base/callfwmall.c,
testsuite/gdb.base/overlays.c, testsuite/gdb.base/ovlymgr.h,
tui/tui.h, tui/tuiIO.c, tui/tuiLayout.c, tui/tuiSourceWin.h:
Eliminate PARAMS.
Index: annotate.c
===================================================================
RCS file: /cvs/src/src/gdb/annotate.c,v
retrieving revision 1.2
diff -u -p -r1.2 annotate.c
--- annotate.c 2000/05/28 01:12:26 1.2
+++ annotate.c 2000/05/30 22:08:27
@@ -34,11 +34,11 @@ static void print_value_flags (struct ty
static void breakpoint_changed (struct breakpoint *);
-void (*annotate_starting_hook) PARAMS ((void));
-void (*annotate_stopped_hook) PARAMS ((void));
-void (*annotate_signalled_hook) PARAMS ((void));
-void (*annotate_signal_hook) PARAMS ((void));
-void (*annotate_exited_hook) PARAMS ((void));
+void (*annotate_starting_hook) (void);
+void (*annotate_stopped_hook) (void);
+void (*annotate_signalled_hook) (void);
+void (*annotate_signal_hook) (void);
+void (*annotate_exited_hook) (void);
static int ignore_count_changed = 0;
Index: annotate.h
===================================================================
RCS file: /cvs/src/src/gdb/annotate.h,v
retrieving revision 1.2
diff -u -p -r1.2 annotate.h
--- annotate.h 2000/05/28 01:12:26 1.2
+++ annotate.h 2000/05/30 22:08:27
@@ -98,8 +98,8 @@ extern void annotate_elt_rep_end (void);
extern void annotate_elt (void);
extern void annotate_array_section_end (void);
-extern void (*annotate_starting_hook) PARAMS ((void));
-extern void (*annotate_stopped_hook) PARAMS ((void));
-extern void (*annotate_signalled_hook) PARAMS ((void));
-extern void (*annotate_signal_hook) PARAMS ((void));
-extern void (*annotate_exited_hook) PARAMS ((void));
+extern void (*annotate_starting_hook) (void);
+extern void (*annotate_stopped_hook) (void);
+extern void (*annotate_signalled_hook) (void);
+extern void (*annotate_signal_hook) (void);
+extern void (*annotate_exited_hook) (void);
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.11
diff -u -p -r1.11 breakpoint.c
--- breakpoint.c 2000/05/28 01:12:26 1.11
+++ breakpoint.c 2000/05/30 22:08:48
@@ -7396,7 +7396,7 @@ ignore_command (args, from_tty)
static void
map_breakpoint_numbers (args, function)
char *args;
- void (*function) PARAMS ((struct breakpoint *));
+ void (*function) (struct breakpoint *);
{
register char *p = args;
char *p1;
Index: command.c
===================================================================
RCS file: /cvs/src/src/gdb/command.c,v
retrieving revision 1.10
diff -u -p -r1.10 command.c
--- command.c 2000/05/28 01:12:26 1.10
+++ command.c 2000/05/30 22:09:07
@@ -84,7 +84,7 @@ struct cmd_list_element *
add_cmd (name, class, fun, doc, list)
char *name;
enum command_class class;
- void (*fun) PARAMS ((char *, int));
+ void (*fun) (char *, int);
char *doc;
struct cmd_list_element **list;
{
@@ -168,7 +168,7 @@ struct cmd_list_element *
add_abbrev_cmd (name, class, fun, doc, list)
char *name;
enum command_class class;
- void (*fun) PARAMS ((char *, int));
+ void (*fun) (char *, int);
char *doc;
struct cmd_list_element **list;
{
@@ -222,7 +222,7 @@ add_prefix_cmd (name, class, fun, doc, p
allow_unknown, list)
char *name;
enum command_class class;
- void (*fun) PARAMS ((char *, int));
+ void (*fun) (char *, int);
char *doc;
struct cmd_list_element **prefixlist;
char *prefixname;
@@ -243,7 +243,7 @@ add_abbrev_prefix_cmd (name, class, fun,
allow_unknown, list)
char *name;
enum command_class class;
- void (*fun) PARAMS ((char *, int));
+ void (*fun) (char *, int);
char *doc;
struct cmd_list_element **prefixlist;
char *prefixname;
Index: command.h
===================================================================
RCS file: /cvs/src/src/gdb/command.h,v
retrieving revision 1.8
diff -u -p -r1.8 command.h
--- command.h 2000/05/28 01:12:26 1.8
+++ command.h 2000/05/30 22:09:07
@@ -108,15 +108,14 @@ struct cmd_list_element
union
{
/* If type is not_set_cmd, call it like this: */
- void (*cfunc) PARAMS ((char *args, int from_tty));
+ void (*cfunc) (char *args, int from_tty);
/* If type is cmd_set or show_cmd, first set the variables, and
then call this. */
- void (*sfunc) PARAMS ((char *args, int from_tty,
- struct cmd_list_element * c));
+ void (*sfunc) (char *args, int from_tty, struct cmd_list_element * c);
}
function;
-#define NO_FUNCTION ((void (*) PARAMS((char *args, int from_tty))) 0)
+#define NO_FUNCTION ((void (*) (char *args, int from_tty)) 0)
/* Documentation of this command (or help topic).
First line is brief documentation; remaining lines form, with it,
@@ -186,7 +185,7 @@ struct cmd_list_element
returned relative to this position. For example, suppose TEXT is "foo"
and we want to complete to "foobar". If WORD is "oo", return
"oobar"; if WORD is "baz/foo", return "baz/foobar". */
- char **(*completer) PARAMS ((char *text, char *word));
+ char **(*completer) (char *text, char *word);
/* Type of "set" or "show" command (or SET_NOT_SET if not "set"
or "show"). */
Index: copying.awk
===================================================================
RCS file: /cvs/src/src/gdb/copying.awk,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 copying.awk
--- copying.awk 1999/04/16 01:33:59 1.1.1.1
+++ copying.awk 2000/05/30 22:09:10
@@ -7,11 +7,11 @@ BEGIN {
print "#include \"command.h\""
print "#include \"gdbcmd.h\""
print ""
- print "static void show_copying_command PARAMS ((char *, int));"
+ print "static void show_copying_command (char *, int);"
print ""
- print "static void show_warranty_command PARAMS ((char *, int));"
+ print "static void show_warranty_command (char *, int);"
print ""
- print "void _initialize_copying PARAMS ((void));"
+ print "void _initialize_copying (void);"
print ""
print "extern int immediate_quit;";
print "static void";
Index: corefile.c
===================================================================
RCS file: /cvs/src/src/gdb/corefile.c,v
retrieving revision 1.4
diff -u -p -r1.4 corefile.c
--- corefile.c 2000/05/28 01:12:26 1.4
+++ corefile.c 2000/05/30 22:09:12
@@ -51,7 +51,7 @@ static void call_extra_exec_file_hooks (
old code that assumed that only one hook could be set, and which called
exec_file_display_hook directly. */
-typedef void (*hook_type) PARAMS ((char *));
+typedef void (*hook_type) (char *);
hook_type exec_file_display_hook; /* the original hook */
static hook_type *exec_file_extra_hooks; /* array of additional hooks */
@@ -124,7 +124,7 @@ call_extra_exec_file_hooks (filename)
void
specify_exec_file_hook (hook)
- void (*hook) PARAMS ((char *));
+ void (*hook) (char *);
{
hook_type *new_array;
Index: d10v-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/d10v-tdep.c,v
retrieving revision 1.5
diff -u -p -r1.5 d10v-tdep.c
--- d10v-tdep.c 2000/05/28 01:12:26 1.5
+++ d10v-tdep.c 2000/05/30 22:09:16
@@ -1664,8 +1664,8 @@ d10v_gdbarch_init (info, arches)
}
-extern void (*target_resume_hook) PARAMS ((void));
-extern void (*target_wait_loop_hook) PARAMS ((void));
+extern void (*target_resume_hook) (void);
+extern void (*target_wait_loop_hook) (void);
void
_initialize_d10v_tdep ()
Index: d30v-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/d30v-tdep.c,v
retrieving revision 1.2
diff -u -p -r1.2 d30v-tdep.c
--- d30v-tdep.c 2000/05/28 01:12:26 1.2
+++ d30v-tdep.c 2000/05/30 22:09:17
@@ -1365,8 +1365,8 @@ display_trace (low, high)
}
}
-extern void (*target_resume_hook) PARAMS ((void));
-extern void (*target_wait_loop_hook) PARAMS ((void));
+extern void (*target_resume_hook) (void);
+extern void (*target_wait_loop_hook) (void);
void
_initialize_d30v_tdep ()
Index: dbxread.c
===================================================================
RCS file: /cvs/src/src/gdb/dbxread.c,v
retrieving revision 1.5
diff -u -p -r1.5 dbxread.c
--- dbxread.c 2000/05/28 01:12:26 1.5
+++ dbxread.c 2000/05/30 22:09:21
@@ -809,7 +809,7 @@ struct cont_elem
int sym_idx;
int sym_end;
int symnum;
- int (*func) PARAMS ((struct objfile *, struct symbol *, char *));
+ int (*func) (struct objfile *, struct symbol *, char *);
/* other state dependancies include:
(assumption is that these will not change since process_now FIXME!!)
stringtab_global
@@ -828,7 +828,7 @@ void
process_later (sym, p, f)
struct symbol *sym;
char *p;
- int (*f) PARAMS ((struct objfile *, struct symbol *, char *));
+ int (*f) (struct objfile *, struct symbol *, char *);
{
/* Allocate more space for the deferred list. */
@@ -867,7 +867,7 @@ process_now (objfile)
struct symbol *sym;
char *stabs;
int err;
- int (*func) PARAMS ((struct objfile *, struct symbol *, char *));
+ int (*func) (struct objfile *, struct symbol *, char *);
/* Save the state of our caller, we'll want to restore it before
returning. */
Index: dcache.c
===================================================================
RCS file: /cvs/src/src/gdb/dcache.c,v
retrieving revision 1.2
diff -u -p -r1.2 dcache.c
--- dcache.c 2000/05/28 01:12:26 1.2
+++ dcache.c 2000/05/30 22:09:22
@@ -478,7 +478,7 @@ dcache_xfer_memory (dcache, memaddr, mya
if (dcache_enabled_p)
{
- int (*xfunc) PARAMS ((DCACHE * dcache, CORE_ADDR addr, char *ptr));
+ int (*xfunc) (DCACHE * dcache, CORE_ADDR addr, char *ptr);
xfunc = should_write ? dcache_poke_byte : dcache_peek_byte;
for (i = 0; i < len; i++)
Index: dcache.h
===================================================================
RCS file: /cvs/src/src/gdb/dcache.h,v
retrieving revision 1.2
diff -u -p -r1.2 dcache.h
--- dcache.h 2000/05/28 01:12:26 1.2
+++ dcache.h 2000/05/30 22:09:22
@@ -23,9 +23,7 @@
#ifndef DCACHE_H
#define DCACHE_H
-typedef int (*memxferfunc) PARAMS ((CORE_ADDR memaddr,
- char *myaddr,
- int len));
+typedef int (*memxferfunc) (CORE_ADDR memaddr, char *myaddr, int len);
typedef struct dcache_struct DCACHE;
Index: dsrec.c
===================================================================
RCS file: /cvs/src/src/gdb/dsrec.c,v
retrieving revision 1.2
diff -u -p -r1.2 dsrec.c
--- dsrec.c 2000/05/28 01:12:26 1.2
+++ dsrec.c 2000/05/30 22:09:25
@@ -51,7 +51,7 @@ load_srec (desc, file, load_offset, maxr
int maxrecsize;
int flags;
int hashmark;
- int (*waitack) PARAMS ((void));
+ int (*waitack) (void);
{
bfd *abfd;
asection *s;
Index: dve3900-rom.c
===================================================================
RCS file: /cvs/src/src/gdb/dve3900-rom.c,v
retrieving revision 1.2
diff -u -p -r1.2 dve3900-rom.c
--- dve3900-rom.c 2000/05/28 01:12:26 1.2
+++ dve3900-rom.c 2000/05/30 22:09:30
@@ -31,7 +31,7 @@
/* Type of function passed to bfd_map_over_sections. */
-typedef void (*section_map_func) PARAMS ((bfd * abfd, asection * sect, PTR obj));
+typedef void (*section_map_func) (bfd * abfd, asection * sect, PTR obj);
/* Packet escape character used by Densan monitor. */
@@ -95,13 +95,13 @@ static void r3900_open (char *args, int
format, and those that can't be modified at all. In those cases
we have to use our own functions to fetch and store their values. */
-static void (*orig_monitor_fetch_registers) PARAMS ((int regno));
-static void (*orig_monitor_store_registers) PARAMS ((int regno));
+static void (*orig_monitor_fetch_registers) (int regno);
+static void (*orig_monitor_store_registers) (int regno);
/* Pointer to static function in monitor. for loading programs.
We use this function for loading S-records via the serial link. */
-static void (*orig_monitor_load) PARAMS ((char *file, int from_tty));
+static void (*orig_monitor_load) (char *file, int from_tty);
/* This flag is set if a fast ethernet download should be used. */
Index: exec.c
===================================================================
RCS file: /cvs/src/src/gdb/exec.c,v
retrieving revision 1.3
diff -u -p -r1.3 exec.c
--- exec.c 2000/05/28 01:12:27 1.3
+++ exec.c 2000/05/30 22:09:48
@@ -47,7 +47,7 @@
struct vmap *map_vmap (bfd *, bfd *);
-void (*file_changed_hook) PARAMS ((char *));
+void (*file_changed_hook) (char *);
/* Prototypes for local functions */
@@ -473,7 +473,7 @@ xfer_memory (memaddr, myaddr, len, write
boolean res;
struct section_table *p;
CORE_ADDR nextsectaddr, memend;
- boolean (*xfer_fn) PARAMS ((bfd *, sec_ptr, PTR, file_ptr, bfd_size_type));
+ boolean (*xfer_fn) (bfd *, sec_ptr, PTR, file_ptr, bfd_size_type);
asection *section;
if (len <= 0)
Index: fork-child.c
===================================================================
RCS file: /cvs/src/src/gdb/fork-child.c,v
retrieving revision 1.2
diff -u -p -r1.2 fork-child.c
--- fork-child.c 2000/02/09 08:52:45 1.2
+++ fork-child.c 2000/05/30 22:09:55
@@ -103,9 +103,9 @@ fork_inferior (exec_file, allargs, env,
char *exec_file;
char *allargs;
char **env;
- void (*traceme_fun) PARAMS ((void));
- void (*init_trace_fun) PARAMS ((int));
- void (*pre_trace_fun) PARAMS ((void));
+ void (*traceme_fun) (void);
+ void (*init_trace_fun) (int);
+ void (*pre_trace_fun) (void);
char *shell_file;
{
int pid;
Index: gdbcore.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbcore.h,v
retrieving revision 1.3
diff -u -p -r1.3 gdbcore.h
--- gdbcore.h 2000/05/28 01:12:27 1.3
+++ gdbcore.h 2000/05/30 22:10:02
@@ -78,12 +78,12 @@ extern void generic_search (int len, cha
\f
/* Hook for `exec_file_command' command to call. */
-extern void (*exec_file_display_hook) PARAMS ((char *filename));
+extern void (*exec_file_display_hook) (char *filename);
/* Hook for "file_command", which is more useful than above
(because it is invoked AFTER symbols are read, not before) */
-extern void (*file_changed_hook) PARAMS ((char *filename));
+extern void (*file_changed_hook) (char *filename);
extern void specify_exec_file_hook (void (*hook) (char *filename));
@@ -143,13 +143,13 @@ struct core_fns
another file). Returns nonzero if the handler recognizes the
format, zero otherwise. */
- int (*check_format) PARAMS ((bfd *));
+ int (*check_format) (bfd *);
/* Core file handler function to call to ask if it can handle a
given core file format or not. Returns zero if it can't,
nonzero otherwise. */
- int (*core_sniffer) PARAMS ((struct core_fns *, bfd *));
+ int (*core_sniffer) (struct core_fns *, bfd *);
/* Extract the register values out of the core file and store them where
`read_register' will find them.
@@ -172,9 +172,9 @@ struct core_fns
registers in a large upage-plus-stack ".reg" section. Original upage
address X is at location core_reg_sect+x+reg_addr. */
- void (*core_read_registers) PARAMS ((char *core_reg_sect,
- unsigned core_reg_size,
- int which, CORE_ADDR reg_addr));
+ void (*core_read_registers) (char *core_reg_sect,
+ unsigned core_reg_size,
+ int which, CORE_ADDR reg_addr);
/* Finds the next struct core_fns. They are allocated and initialized
in whatever module implements the functions pointed to; an
Index: hpux-thread.c
===================================================================
RCS file: /cvs/src/src/gdb/hpux-thread.c,v
retrieving revision 1.2
diff -u -p -r1.2 hpux-thread.c
--- hpux-thread.c 2000/05/28 01:12:27 1.2
+++ hpux-thread.c 2000/05/30 22:10:44
@@ -524,7 +524,7 @@ hpux_thread_create_inferior (exec_file,
*/
/* Saved pointer to previous owner of the new_objfile event. */
-static void (*target_new_objfile_chain) PARAMS ((struct objfile *));
+static void (*target_new_objfile_chain) (struct objfile *);
void
hpux_thread_new_objfile (objfile)
Index: language.h
===================================================================
RCS file: /cvs/src/src/gdb/language.h,v
retrieving revision 1.3
diff -u -p -r1.3 language.h
--- language.h 2000/05/28 01:12:28 1.3
+++ language.h 2000/05/30 22:11:20
@@ -141,15 +141,15 @@ struct language_defn
/* Parser function. */
- int (*la_parser) PARAMS ((void));
+ int (*la_parser) (void);
/* Parser error function */
- void (*la_error) PARAMS ((char *));
+ void (*la_error) (char *);
/* Evaluate an expression. */
- struct value *(*evaluate_exp) PARAMS ((struct type *, struct expression *,
- int *, enum noside));
+ struct value *(*evaluate_exp) (struct type *, struct expression *,
+ int *, enum noside);
void (*la_printchar) (int ch, struct ui_file * stream);
@@ -159,7 +159,7 @@ struct language_defn
void (*la_emitchar) (int ch, struct ui_file * stream, int quoter);
- struct type *(*la_fund_type) PARAMS ((struct objfile *, int));
+ struct type *(*la_fund_type) (struct objfile *, int);
/* Print a type using syntax appropriate for this language. */
Index: linux-thread.c
===================================================================
RCS file: /cvs/src/src/gdb/linux-thread.c,v
retrieving revision 1.6
diff -u -p -r1.6 linux-thread.c
--- linux-thread.c 2000/03/24 21:07:17 1.6
+++ linux-thread.c 2000/05/30 22:11:25
@@ -902,7 +902,7 @@ update_stop_threads (test_pid)
*/
/* Saved pointer to previous owner of the new_objfile event. */
-static void (*target_new_objfile_chain) PARAMS ((struct objfile *));
+static void (*target_new_objfile_chain) (struct objfile *);
void
linuxthreads_new_objfile (objfile)
Index: mdebugread.c
===================================================================
RCS file: /cvs/src/src/gdb/mdebugread.c,v
retrieving revision 1.4
diff -u -p -r1.4 mdebugread.c
--- mdebugread.c 2000/05/28 01:12:28 1.4
+++ mdebugread.c 2000/05/30 22:11:51
@@ -699,8 +699,7 @@ parse_symbol (sh, ax, ext_sh, bigend, se
struct objfile *objfile;
{
const bfd_size_type external_sym_size = debug_swap->external_sym_size;
- void (*const swap_sym_in) PARAMS ((bfd *, PTR, SYMR *)) =
- debug_swap->swap_sym_in;
+ void (*const swap_sym_in) (bfd *, PTR, SYMR *) = debug_swap->swap_sym_in;
char *name;
struct symbol *s;
struct block *b;
@@ -2254,12 +2253,9 @@ parse_partial_symbols (objfile)
const bfd_size_type external_sym_size = debug_swap->external_sym_size;
const bfd_size_type external_rfd_size = debug_swap->external_rfd_size;
const bfd_size_type external_ext_size = debug_swap->external_ext_size;
- void (*const swap_ext_in) PARAMS ((bfd *, PTR, EXTR *))
- = debug_swap->swap_ext_in;
- void (*const swap_sym_in) PARAMS ((bfd *, PTR, SYMR *))
- = debug_swap->swap_sym_in;
- void (*const swap_rfd_in) PARAMS ((bfd *, PTR, RFDT *))
- = debug_swap->swap_rfd_in;
+ void (*const swap_ext_in) (bfd *, PTR, EXTR *) = debug_swap->swap_ext_in;
+ void (*const swap_sym_in) (bfd *, PTR, SYMR *) = debug_swap->swap_sym_in;
+ void (*const swap_rfd_in) (bfd *, PTR, RFDT *) = debug_swap->swap_rfd_in;
int f_idx, s_idx;
HDRR *hdr = &debug_info->symbolic_header;
/* Running pointers */
@@ -3167,8 +3163,7 @@ handle_psymbol_enumerators (objfile, fh,
CORE_ADDR svalue;
{
const bfd_size_type external_sym_size = debug_swap->external_sym_size;
- void (*const swap_sym_in) PARAMS ((bfd *, PTR, SYMR *))
- = debug_swap->swap_sym_in;
+ void (*const swap_sym_in) (bfd *, PTR, SYMR *) = debug_swap->swap_sym_in;
char *ext_sym = ((char *) debug_info->external_sym
+ ((fh->isymBase + cur_sdx + 1) * external_sym_size));
SYMR sh;
@@ -3260,8 +3255,8 @@ psymtab_to_symtab_1 (pst, filename)
{
bfd_size_type external_sym_size;
bfd_size_type external_pdr_size;
- void (*swap_sym_in) PARAMS ((bfd *, PTR, SYMR *));
- void (*swap_pdr_in) PARAMS ((bfd *, PTR, PDR *));
+ void (*swap_sym_in) (bfd *, PTR, SYMR *);
+ void (*swap_pdr_in) (bfd *, PTR, PDR *);
int i;
struct symtab *st;
FDR *fh;
Index: monitor.h
===================================================================
RCS file: /cvs/src/src/gdb/monitor.h,v
retrieving revision 1.2
diff -u -p -r1.2 monitor.h
--- monitor.h 2000/05/28 01:12:28 1.2
+++ monitor.h 2000/05/30 22:12:05
@@ -95,16 +95,14 @@ struct monitor_ops
GDB with the value of a register. */
char *dump_registers; /* Command to dump all regs at once */
char *register_pattern; /* Pattern that picks out register from reg dump */
- void (*supply_register) PARAMS ((char *name, int namelen,
- char *val, int vallen));
- void (*load_routine) PARAMS ((serial_t desc, char *file,
- int hashmark)); /* Download routine */
- int (*dumpregs) PARAMS ((void)); /* routine to dump all registers */
- int (*continue_hook) PARAMS ((void)); /* Emit the continue command */
- int (*wait_filter) PARAMS ((char *buf, /* Maybe contains registers */
- int bufmax,
- int *response_length,
- struct target_waitstatus * status));
+ void (*supply_register) (char *name, int namelen, char *val, int vallen);
+ void (*load_routine) (serial_t desc, char *file, int hashmark); /* Download routine */
+ int (*dumpregs) (void); /* routine to dump all registers */
+ int (*continue_hook) (void); /* Emit the continue command */
+ int (*wait_filter) (char *buf, /* Maybe contains registers */
+ int bufmax,
+ int *response_length,
+ struct target_waitstatus * status);
char *load; /* load command */
char *loadresp; /* Response to load command */
char *prompt; /* monitor command prompt */
Index: ocd.c
===================================================================
RCS file: /cvs/src/src/gdb/ocd.c,v
retrieving revision 1.3
diff -u -p -r1.3 ocd.c
--- ocd.c 2000/05/28 01:12:28 1.3
+++ ocd.c 2000/05/30 22:12:11
@@ -1409,7 +1409,7 @@ bdm_update_flash_command (args, from_tty
{
int status, pktlen;
struct cleanup *old_chain;
- void (*store_registers_tmp) PARAMS ((int));
+ void (*store_registers_tmp) (int);
if (!ocd_desc)
error ("Not connected to OCD device.");
Index: procfs.c
===================================================================
RCS file: /cvs/src/src/gdb/procfs.c,v
retrieving revision 1.15
diff -u -p -r1.15 procfs.c
--- procfs.c 2000/05/28 01:12:29 1.15
+++ procfs.c 2000/05/30 22:12:32
@@ -98,7 +98,7 @@ Inc., 59 Temple Place - Suite 330, Bosto
* This module defines the GDB target vector and its methods.
*/
-static void procfs_open PARAMS((char *, int));
+static void procfs_open (char *, int);
static void procfs_attach (char *, int);
static void procfs_detach (char *, int);
static void procfs_resume (int, int, enum target_signal);
@@ -754,9 +754,8 @@ int proc_set_traced_signals (procinfo *
int proc_update_threads (procinfo * pi);
int proc_iterate_over_threads (procinfo * pi,
- int (*func) PARAMS ((procinfo *,
- procinfo *,
- void *)), void *ptr);
+ int (*func) (procinfo *, procinfo *, void *),
+ void *ptr);
gdb_gregset_t *proc_get_gregs (procinfo * pi);
gdb_fpregset_t *proc_get_fpregs (procinfo * pi);
@@ -2598,7 +2597,7 @@ proc_set_watchpoint (pi, addr, len, wfla
every time, I don't need to lseek it. */
int
proc_iterate_over_mappings (func)
- int (*func) PARAMS ((int, CORE_ADDR));
+ int (*func) (int, CORE_ADDR);
{
struct prmap *map;
procinfo *pi;
@@ -3140,7 +3139,7 @@ proc_update_threads (pi)
int
proc_iterate_over_threads (pi, func, ptr)
procinfo *pi;
- int (*func) PARAMS ((procinfo *, procinfo *, void *));
+ int (*func) (procinfo *, procinfo *, void *);
void *ptr;
{
procinfo *thread, *next;
Index: ptx4-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/ptx4-nat.c,v
retrieving revision 1.3
diff -u -p -r1.3 ptx4-nat.c
--- ptx4-nat.c 2000/05/26 23:22:41 1.3
+++ ptx4-nat.c 2000/05/30 22:12:32
@@ -101,7 +101,7 @@ fill_fpregset (fpregsetp, regno)
/* this could use elf_interpreter() from elfread.c */
int
proc_iterate_over_mappings (func)
- int (*func) PARAMS ((int, CORE_ADDR));
+ int (*func) (int, CORE_ADDR);
{
vaddr_t curseg, memptr;
pt_vseg_t pv;
Index: remote-sim.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sim.c,v
retrieving revision 1.4
diff -u -p -r1.4 remote-sim.c
--- remote-sim.c 2000/05/28 01:12:29 1.4
+++ remote-sim.c 2000/05/30 22:12:58
@@ -42,7 +42,7 @@
extern void _initialize_remote_sim (void);
-extern int (*ui_loop_hook) PARAMS ((int signo));
+extern int (*ui_loop_hook) (int signo);
static void dump_mem (char *buf, int len);
Index: remote-utils.h
===================================================================
RCS file: /cvs/src/src/gdb/remote-utils.h,v
retrieving revision 1.2
diff -u -p -r1.2 remote-utils.h
--- remote-utils.h 2000/05/28 01:12:29 1.2
+++ remote-utils.h 2000/05/30 22:13:02
@@ -77,10 +77,10 @@ struct gr_settings
DCACHE *dcache;
char *prompt;
struct target_ops *ops;
- int (*clear_all_breakpoints) PARAMS ((void));
+ int (*clear_all_breakpoints) (void);
memxferfunc readfunc;
memxferfunc writefunc;
- void (*checkin) PARAMS ((void));
+ void (*checkin) (void);
};
extern struct gr_settings *gr_settings;
Index: remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.11
diff -u -p -r1.11 remote.c
--- remote.c 2000/05/28 01:12:29 1.11
+++ remote.c 2000/05/30 22:13:10
@@ -603,9 +603,8 @@ add_packet_config_cmd (config, name, tit
struct packet_config *config;
char *name;
char *title;
- void (*set_func) PARAMS ((char *args, int from_tty,
- struct cmd_list_element * c));
- void (*show_func) PARAMS ((char *name, int from_tty));
+ void (*set_func) (char *args, int from_tty, struct cmd_list_element * c);
+ void (*show_func) (char *name, int from_tty);
struct cmd_list_element **setlist;
struct cmd_list_element **showlist;
{
@@ -731,8 +730,8 @@ PTR sigint_remote_token;
/* These are pointers to hook functions that may be set in order to
modify resume/wait behavior for a particular architecture. */
-void (*target_resume_hook) PARAMS ((void));
-void (*target_wait_loop_hook) PARAMS ((void));
+void (*target_resume_hook) (void);
+void (*target_wait_loop_hook) (void);
\f
@@ -2445,7 +2444,7 @@ cleanup_sigint_signal_handler (void *dum
/* Send ^C to target to halt it. Target will respond, and send us a
packet. */
-static void (*ofunc) PARAMS ((int));
+static void (*ofunc) (int);
/* The command line interface's stop routine. This function is installed
as a signal handler for SIGINT. The first time a user requests a
@@ -5163,8 +5162,7 @@ remote_cisco_close (int quitting)
}
static void
- remote_cisco_mourn
-PARAMS ((void))
+remote_cisco_mourn (void)
{
remote_mourn_1 (&remote_cisco_ops);
}
Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.6
diff -u -p -r1.6 rs6000-tdep.c
--- rs6000-tdep.c 2000/05/28 01:12:29 1.6
+++ rs6000-tdep.c 2000/05/30 22:13:14
@@ -47,7 +47,7 @@ stepBreaks[2];
inferior under AIX. The initialization code in rs6000-nat.c sets
this hook to point to find_toc_address. */
-CORE_ADDR (*find_toc_address_hook) PARAMS ((CORE_ADDR)) = NULL;
+CORE_ADDR (*find_toc_address_hook) (CORE_ADDR) = NULL;
/* Static function prototypes */
Index: ser-ocd.c
===================================================================
RCS file: /cvs/src/src/gdb/ser-ocd.c,v
retrieving revision 1.1.1.4
diff -u -p -r1.1.1.4 ser-ocd.c
--- ser-ocd.c 2000/02/02 00:21:10 1.1.1.4
+++ ser-ocd.c 2000/05/30 22:13:17
@@ -30,7 +30,7 @@
#ifdef _WIN32
/* On Windows, this function pointer is initialized to a function in
the wiggler DLL. */
-static int (*dll_do_command) PARAMS ((const char *, char *));
+static int (*dll_do_command) (const char *, char *);
#endif
static int
@@ -49,7 +49,7 @@ ocd_open (scb, name)
if (handle == NULL)
error ("Can't load Wigglers.dll");
- dll_do_command = ((int (*)PARAMS ((const char *, char *)))
+ dll_do_command = ((int (*) (const char *, char *))
GetProcAddress (handle, "do_command"));
if (dll_do_command == NULL)
error ("Can't find do_command function in Wigglers.dll");
Index: sol-thread.c
===================================================================
RCS file: /cvs/src/src/gdb/sol-thread.c,v
retrieving revision 1.9
diff -u -p -r1.9 sol-thread.c
--- sol-thread.c 2000/05/28 01:12:29 1.9
+++ sol-thread.c 2000/05/30 22:13:25
@@ -857,7 +857,7 @@ sol_thread_create_inferior (exec_file, a
*/
/* Saved pointer to previous owner of the new_objfile event. */
-static void (*target_new_objfile_chain) PARAMS ((struct objfile *));
+static void (*target_new_objfile_chain) (struct objfile *);
void
sol_thread_new_objfile (objfile)
Index: sparcl-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sparcl-tdep.c,v
retrieving revision 1.4
diff -u -p -r1.4 sparcl-tdep.c
--- sparcl-tdep.c 2000/05/28 01:12:29 1.4
+++ sparcl-tdep.c 2000/05/30 22:13:41
@@ -560,9 +560,9 @@ download (target_name, args, from_tty, w
char *target_name;
char *args;
int from_tty;
- void (*write_routine) PARAMS ((bfd * from_bfd, asection * from_sec,
- file_ptr from_addr, bfd_vma to_addr, int len));
- void (*start_routine) PARAMS ((bfd_vma entry));
+ void (*write_routine) (bfd * from_bfd, asection * from_sec,
+ file_ptr from_addr, bfd_vma to_addr, int len);
+ void (*start_routine) (bfd_vma entry);
{
struct cleanup *old_chain;
asection *section;
Index: stabsread.h
===================================================================
RCS file: /cvs/src/src/gdb/stabsread.h,v
retrieving revision 1.2
diff -u -p -r1.2 stabsread.h
--- stabsread.h 2000/05/28 01:12:29 1.2
+++ stabsread.h 2000/05/30 22:13:50
@@ -213,7 +213,7 @@ extern void elfstab_offset_sections (str
extern void process_later
(struct symbol *, char *,
- int (*f) PARAMS ((struct objfile *, struct symbol *, char *)));
+ int (*f) (struct objfile *, struct symbol *, char *));
extern int symbol_reference_defined (char **);
Index: stack.c
===================================================================
RCS file: /cvs/src/src/gdb/stack.c,v
retrieving revision 1.5
diff -u -p -r1.5 stack.c
--- stack.c 2000/05/28 01:12:29 1.5
+++ stack.c 2000/05/30 22:13:52
@@ -46,7 +46,7 @@ void args_info (char *, int);
void locals_info (char *, int);
-void (*selected_frame_level_changed_hook) PARAMS ((int));
+void (*selected_frame_level_changed_hook) (int);
void _initialize_stack (void);
Index: symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.11
diff -u -p -r1.11 symfile.c
--- symfile.c 2000/05/28 01:12:29 1.11
+++ symfile.c 2000/05/30 22:13:58
@@ -68,9 +68,9 @@ void (*show_load_progress) (const char *
unsigned long section_size,
unsigned long total_sent,
unsigned long total_size);
-void (*pre_add_symbol_hook) PARAMS ((char *));
-void (*post_add_symbol_hook) PARAMS ((void));
-void (*target_new_objfile_hook) PARAMS ((struct objfile *));
+void (*pre_add_symbol_hook) (char *);
+void (*post_add_symbol_hook) (void);
+void (*target_new_objfile_hook) (struct objfile *);
static void clear_symtab_users_cleanup (void *ignore);
@@ -2554,8 +2554,7 @@ int overlay_cache_invalid = 0; /* True i
/* Target vector for refreshing overlay mapped state */
static void simple_overlay_update (struct obj_section *);
-void (*target_overlay_update) PARAMS ((struct obj_section *))
-= simple_overlay_update;
+void (*target_overlay_update) (struct obj_section *) = simple_overlay_update;
/* Function: section_is_overlay (SECTION)
Returns true if SECTION has VMA not equal to LMA, ie.
Index: symfile.h
===================================================================
RCS file: /cvs/src/src/gdb/symfile.h,v
retrieving revision 1.4
diff -u -p -r1.4 symfile.h
--- symfile.h 2000/05/28 01:12:29 1.4
+++ symfile.h 2000/05/30 22:13:59
@@ -88,13 +88,13 @@ struct sym_fns
called during symbol_file_add, when we begin debugging an entirely new
program. */
- void (*sym_new_init) PARAMS ((struct objfile *));
+ void (*sym_new_init) (struct objfile *);
/* Reads any initial information from a symbol file, and initializes the
struct sym_fns SF in preparation for sym_read(). It is called every
time we read a symbol file for any reason. */
- void (*sym_init) PARAMS ((struct objfile *));
+ void (*sym_init) (struct objfile *);
/* sym_read (objfile, mainline)
Reads a symbol file into a psymtab (or possibly a symtab).
@@ -104,12 +104,12 @@ struct sym_fns
symbol file (e.g. shared library or dynamically loaded file)
is being read. */
- void (*sym_read) PARAMS ((struct objfile *, int));
+ void (*sym_read) (struct objfile *, int);
/* Called when we are finished with an objfile. Should do all cleanup
that is specific to the object file format for the particular objfile. */
- void (*sym_finish) PARAMS ((struct objfile *));
+ void (*sym_finish) (struct objfile *);
/* This function produces a file-dependent section_offsets structure,
allocated in the objfile's storage, and based on the parameter.
@@ -118,7 +118,7 @@ struct sym_fns
a string, where NULL means the default, and others are parsed in a file
dependent way. */
- void (*sym_offsets) PARAMS ((struct objfile *, struct section_addr_info *));
+ void (*sym_offsets) (struct objfile *, struct section_addr_info *);
/* Finds the next struct sym_fns. They are allocated and initialized
in whatever module implements the functions pointed to; an
Index: symtab.c
===================================================================
RCS file: /cvs/src/src/gdb/symtab.c,v
retrieving revision 1.6
diff -u -p -r1.6 symtab.c
--- symtab.c 2000/05/29 13:18:15 1.6
+++ symtab.c 2000/05/30 22:14:06
@@ -77,9 +77,8 @@ char *operator_chars (char *, char **);
static int find_line_common (struct linetable *, int, int *);
-static struct partial_symbol *lookup_partial_symbol PARAMS
- ((struct partial_symtab *, const char *,
- int, namespace_enum));
+static struct partial_symbol *lookup_partial_symbol
+ (struct partial_symtab *, const char *, int, namespace_enum);
static struct partial_symbol *fixup_psymbol_section (struct
partial_symbol *,
Index: symtab.h
===================================================================
RCS file: /cvs/src/src/gdb/symtab.h,v
retrieving revision 1.9
diff -u -p -r1.9 symtab.h
--- symtab.h 2000/05/29 13:18:15 1.9
+++ symtab.h 2000/05/30 22:14:08
@@ -1011,7 +1011,7 @@ struct partial_symtab
/* Pointer to function which will read in the symtab corresponding to
this psymtab. */
- void (*read_symtab) PARAMS ((struct partial_symtab *));
+ void (*read_symtab) (struct partial_symtab *);
/* Information that lets read_symtab() locate the part of the symbol table
that this psymtab corresponds to. This information is private to the
Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.8
diff -u -p -r1.8 target.c
--- target.c 2000/05/28 01:12:30 1.8
+++ target.c 2000/05/30 22:14:11
@@ -2126,7 +2126,7 @@ Use \"info signals\" for a list of symbo
}
\f
/* Returns zero to leave the inferior alone, one to interrupt it. */
-int (*target_activity_function) PARAMS ((void));
+int (*target_activity_function) (void);
int target_activity_fd;
\f
/* Convert a normal process ID to a string. Returns the string in a static
Index: target.h
===================================================================
RCS file: /cvs/src/src/gdb/target.h,v
retrieving revision 1.5
diff -u -p -r1.5 target.h
--- target.h 2000/05/28 01:12:30 1.5
+++ target.h 2000/05/30 22:14:14
@@ -316,7 +316,7 @@ enum target_signal target_signal_from_na
on TARGET_ACTIVITY_FD. */
extern int target_activity_fd;
/* Returns zero to leave the inferior alone, one to interrupt it. */
-extern int (*target_activity_function) PARAMS ((void));
+extern int (*target_activity_function) (void);
\f
struct thread_info; /* fwd decl for parameter list below: */
@@ -327,19 +327,19 @@ struct target_ops
char *to_doc; /* Documentation. Does not include trailing
newline, and starts with a one-line descrip-
tion (probably similar to to_longname). */
- void (*to_open) PARAMS ((char *, int));
- void (*to_close) PARAMS ((int));
- void (*to_attach) PARAMS ((char *, int));
- void (*to_post_attach) PARAMS ((int));
- void (*to_require_attach) PARAMS ((char *, int));
- void (*to_detach) PARAMS ((char *, int));
- void (*to_require_detach) PARAMS ((int, char *, int));
- void (*to_resume) PARAMS ((int, int, enum target_signal));
- int (*to_wait) PARAMS ((int, struct target_waitstatus *));
- void (*to_post_wait) PARAMS ((int, int));
- void (*to_fetch_registers) PARAMS ((int));
- void (*to_store_registers) PARAMS ((int));
- void (*to_prepare_to_store) PARAMS ((void));
+ void (*to_open) (char *, int);
+ void (*to_close) (int);
+ void (*to_attach) (char *, int);
+ void (*to_post_attach) (int);
+ void (*to_require_attach) (char *, int);
+ void (*to_detach) (char *, int);
+ void (*to_require_detach) (int, char *, int);
+ void (*to_resume) (int, int, enum target_signal);
+ int (*to_wait) (int, struct target_waitstatus *);
+ void (*to_post_wait) (int, int);
+ void (*to_fetch_registers) (int);
+ void (*to_store_registers) (int);
+ void (*to_prepare_to_store) (void);
/* Transfer LEN bytes of memory between GDB address MYADDR and
target address MEMADDR. If WRITE, transfer them to the target, else
@@ -359,9 +359,8 @@ struct target_ops
transfer right at MEMADDR, but we could transfer at least
something at MEMADDR + N. */
- int (*to_xfer_memory) PARAMS ((CORE_ADDR memaddr, char *myaddr,
- int len, int write,
- struct target_ops * target));
+ int (*to_xfer_memory) (CORE_ADDR memaddr, char *myaddr,
+ int len, int write, struct target_ops * target);
#if 0
/* Enable this after 4.12. */
@@ -376,73 +375,72 @@ struct target_ops
If we don't find anything, set *ADDR_FOUND to (CORE_ADDR)0 and
return. */
- void (*to_search) PARAMS ((int len, char *data, char *mask,
- CORE_ADDR startaddr, int increment,
- CORE_ADDR lorange, CORE_ADDR hirange,
- CORE_ADDR * addr_found, char *data_found));
+ void (*to_search) (int len, char *data, char *mask,
+ CORE_ADDR startaddr, int increment,
+ CORE_ADDR lorange, CORE_ADDR hirange,
+ CORE_ADDR * addr_found, char *data_found);
#define target_search(len, data, mask, startaddr, increment, lorange, hirange, addr_found, data_found) \
(*current_target.to_search) (len, data, mask, startaddr, increment, \
lorange, hirange, addr_found, data_found)
#endif /* 0 */
- void (*to_files_info) PARAMS ((struct target_ops *));
- int (*to_insert_breakpoint) PARAMS ((CORE_ADDR, char *));
- int (*to_remove_breakpoint) PARAMS ((CORE_ADDR, char *));
- void (*to_terminal_init) PARAMS ((void));
- void (*to_terminal_inferior) PARAMS ((void));
- void (*to_terminal_ours_for_output) PARAMS ((void));
- void (*to_terminal_ours) PARAMS ((void));
- void (*to_terminal_info) PARAMS ((char *, int));
- void (*to_kill) PARAMS ((void));
- void (*to_load) PARAMS ((char *, int));
- int (*to_lookup_symbol) PARAMS ((char *, CORE_ADDR *));
- void (*to_create_inferior) PARAMS ((char *, char *, char **));
- void (*to_post_startup_inferior) PARAMS ((int));
- void (*to_acknowledge_created_inferior) PARAMS ((int));
- void (*to_clone_and_follow_inferior) PARAMS ((int, int *));
- void (*to_post_follow_inferior_by_clone) PARAMS ((void));
- int (*to_insert_fork_catchpoint) PARAMS ((int));
- int (*to_remove_fork_catchpoint) PARAMS ((int));
- int (*to_insert_vfork_catchpoint) PARAMS ((int));
- int (*to_remove_vfork_catchpoint) PARAMS ((int));
- int (*to_has_forked) PARAMS ((int, int *));
- int (*to_has_vforked) PARAMS ((int, int *));
- int (*to_can_follow_vfork_prior_to_exec) PARAMS ((void));
- void (*to_post_follow_vfork) PARAMS ((int, int, int, int));
- int (*to_insert_exec_catchpoint) PARAMS ((int));
- int (*to_remove_exec_catchpoint) PARAMS ((int));
- int (*to_has_execd) PARAMS ((int, char **));
- int (*to_reported_exec_events_per_exec_call) PARAMS ((void));
- int (*to_has_syscall_event) PARAMS ((int, enum target_waitkind *, int *));
- int (*to_has_exited) PARAMS ((int, int, int *));
- void (*to_mourn_inferior) PARAMS ((void));
- int (*to_can_run) PARAMS ((void));
- void (*to_notice_signals) PARAMS ((int pid));
- int (*to_thread_alive) PARAMS ((int pid));
- void (*to_find_new_threads) PARAMS ((void));
- char *(*to_pid_to_str) PARAMS ((int));
- char *(*to_extra_thread_info) PARAMS ((struct thread_info *));
- void (*to_stop) PARAMS ((void));
- int (*to_query) PARAMS ((int /*char */ , char *, char *, int *));
- void (*to_rcmd) (char *command, struct ui_file *output);
- struct symtab_and_line *(*to_enable_exception_callback) PARAMS ((enum exception_event_kind, int));
- struct exception_event_record *(*to_get_current_exception_event) PARAMS ((void));
- char *(*to_pid_to_exec_file) PARAMS ((int pid));
- char *(*to_core_file_to_sym_file) PARAMS ((char *));
+ void (*to_files_info) (struct target_ops *);
+ int (*to_insert_breakpoint) (CORE_ADDR, char *);
+ int (*to_remove_breakpoint) (CORE_ADDR, char *);
+ void (*to_terminal_init) (void);
+ void (*to_terminal_inferior) (void);
+ void (*to_terminal_ours_for_output) (void);
+ void (*to_terminal_ours) (void);
+ void (*to_terminal_info) (char *, int);
+ void (*to_kill) (void);
+ void (*to_load) (char *, int);
+ int (*to_lookup_symbol) (char *, CORE_ADDR *);
+ void (*to_create_inferior) (char *, char *, char **);
+ void (*to_post_startup_inferior) (int);
+ void (*to_acknowledge_created_inferior) (int);
+ void (*to_clone_and_follow_inferior) (int, int *);
+ void (*to_post_follow_inferior_by_clone) (void);
+ int (*to_insert_fork_catchpoint) (int);
+ int (*to_remove_fork_catchpoint) (int);
+ int (*to_insert_vfork_catchpoint) (int);
+ int (*to_remove_vfork_catchpoint) (int);
+ int (*to_has_forked) (int, int *);
+ int (*to_has_vforked) (int, int *);
+ int (*to_can_follow_vfork_prior_to_exec) (void);
+ void (*to_post_follow_vfork) (int, int, int, int);
+ int (*to_insert_exec_catchpoint) (int);
+ int (*to_remove_exec_catchpoint) (int);
+ int (*to_has_execd) (int, char **);
+ int (*to_reported_exec_events_per_exec_call) (void);
+ int (*to_has_syscall_event) (int, enum target_waitkind *, int *);
+ int (*to_has_exited) (int, int, int *);
+ void (*to_mourn_inferior) (void);
+ int (*to_can_run) (void);
+ void (*to_notice_signals) (int pid);
+ int (*to_thread_alive) (int pid);
+ void (*to_find_new_threads) (void);
+ char *(*to_pid_to_str) (int);
+ char *(*to_extra_thread_info) (struct thread_info *);
+ void (*to_stop) (void);
+ int (*to_query) (int /*char */ , char *, char *, int *);
+ void (*to_rcmd) (char *command, struct ui_file * output);
+ struct symtab_and_line *(*to_enable_exception_callback) (enum
+ exception_event_kind,
+ int);
+ struct exception_event_record *(*to_get_current_exception_event) (void);
+ char *(*to_pid_to_exec_file) (int pid);
+ char *(*to_core_file_to_sym_file) (char *);
enum strata to_stratum;
- struct target_ops
- *DONT_USE; /* formerly to_next */
+ struct target_ops *DONT_USE; /* formerly to_next */
int to_has_all_memory;
int to_has_memory;
int to_has_stack;
int to_has_registers;
int to_has_execution;
int to_has_thread_control; /* control thread execution */
- struct section_table
- *to_sections;
- struct section_table
- *to_sections_end;
+ struct section_table *to_sections;
+ struct section_table *to_sections_end;
/* ASYNC target controls */
int (*to_can_async_p) (void);
int (*to_is_async_p) (void);
@@ -1101,7 +1099,7 @@ extern char *normal_pid_to_str (int pid)
* can receive this notification (something like with signal handlers).
*/
-extern void (*target_new_objfile_hook) PARAMS ((struct objfile *));
+extern void (*target_new_objfile_hook) (struct objfile *);
#ifndef target_pid_or_tid_to_str
#define target_pid_or_tid_to_str(ID) \
Index: top.c
===================================================================
RCS file: /cvs/src/src/gdb/top.c,v
retrieving revision 1.13
diff -u -p -r1.13 top.c
--- top.c 2000/05/28 01:12:32 1.13
+++ top.c 2000/05/30 22:14:21
@@ -285,7 +285,7 @@ char gdb_dirbuf[1024];
The function receives two args: an input stream,
and a prompt string. */
-void (*window_hook) PARAMS ((FILE *, char *));
+void (*window_hook) (FILE *, char *);
int epoch_interface;
int xgdb_verbose;
@@ -392,31 +392,31 @@ static void stop_sig (int);
/* Called after most modules have been initialized, but before taking users
command file. */
-void (*init_ui_hook) PARAMS ((char *argv0));
+void (*init_ui_hook) (char *argv0);
/* This hook is called from within gdb's many mini-event loops which could
steal control from a real user interface's event loop. It returns
non-zero if the user is requesting a detach, zero otherwise. */
-int (*ui_loop_hook) PARAMS ((int));
+int (*ui_loop_hook) (int);
/* Called instead of command_loop at top level. Can be invoked via
return_to_top_level. */
-void (*command_loop_hook) PARAMS ((void));
+void (*command_loop_hook) (void);
/* Called from print_frame_info to list the line we stopped in. */
-void (*print_frame_info_listing_hook) PARAMS ((struct symtab * s, int line,
- int stopline, int noerror));
+void (*print_frame_info_listing_hook) (struct symtab * s, int line,
+ int stopline, int noerror);
/* Replaces most of query. */
-int (*query_hook) PARAMS ((const char *, va_list));
+int (*query_hook) (const char *, va_list);
/* Replaces most of warning. */
-void (*warning_hook) PARAMS ((const char *, va_list));
+void (*warning_hook) (const char *, va_list);
/* These three functions support getting lines of text from the user. They
are used in sequence. First readline_begin_hook is called with a text
@@ -429,51 +429,51 @@ void (*warning_hook) PARAMS ((const char
to notify the GUI that we are done with the interaction window and it
can close it. */
-void (*readline_begin_hook) PARAMS ((char *,...));
-char *(*readline_hook) PARAMS ((char *));
-void (*readline_end_hook) PARAMS ((void));
+void (*readline_begin_hook) (char *, ...);
+char *(*readline_hook) (char *);
+void (*readline_end_hook) (void);
/* Called as appropriate to notify the interface of the specified breakpoint
conditions. */
-void (*create_breakpoint_hook) PARAMS ((struct breakpoint * bpt));
-void (*delete_breakpoint_hook) PARAMS ((struct breakpoint * bpt));
-void (*modify_breakpoint_hook) PARAMS ((struct breakpoint * bpt));
+void (*create_breakpoint_hook) (struct breakpoint * bpt);
+void (*delete_breakpoint_hook) (struct breakpoint * bpt);
+void (*modify_breakpoint_hook) (struct breakpoint * bpt);
/* Called as appropriate to notify the interface that we have attached
to or detached from an already running process. */
-void (*attach_hook) PARAMS ((void));
-void (*detach_hook) PARAMS ((void));
+void (*attach_hook) (void);
+void (*detach_hook) (void);
/* Called during long calculations to allow GUI to repair window damage, and to
check for stop buttons, etc... */
-void (*interactive_hook) PARAMS ((void));
+void (*interactive_hook) (void);
/* Called when the registers have changed, as a hint to a GUI
to minimize window update. */
-void (*registers_changed_hook) PARAMS ((void));
+void (*registers_changed_hook) (void);
/* Tell the GUI someone changed the register REGNO. -1 means
that the caller does not know which register changed or
that several registers have changed (see value_assign). */
-void (*register_changed_hook) PARAMS ((int regno));
+void (*register_changed_hook) (int regno);
/* Tell the GUI someone changed LEN bytes of memory at ADDR */
-void (*memory_changed_hook) PARAMS ((CORE_ADDR addr, int len));
+void (*memory_changed_hook) (CORE_ADDR addr, int len);
/* Called when going to wait for the target. Usually allows the GUI to run
while waiting for target events. */
-int (*target_wait_hook) PARAMS ((int pid, struct target_waitstatus * status));
+int (*target_wait_hook) (int pid, struct target_waitstatus * status);
/* Used by UI as a wrapper around command execution. May do various things
like enabling/disabling buttons, etc... */
-void (*call_command_hook) PARAMS ((struct cmd_list_element * c, char *cmd,
- int from_tty));
+void (*call_command_hook) (struct cmd_list_element * c, char *cmd,
+ int from_tty);
/* Called after a `set' command has finished. Is only run if the
`set' command succeeded. */
@@ -482,7 +482,7 @@ void (*set_hook) (struct cmd_list_elemen
/* Called when the current thread changes. Argument is thread id. */
-void (*context_hook) PARAMS ((int id));
+void (*context_hook) (int id);
/* Takes control from error (). Typically used to prevent longjmps out of the
middle of the GUI. Usually used in conjunction with a catch routine. */
@@ -782,7 +782,7 @@ read_command_file (stream)
\f
extern void init_proc (void);
-void (*pre_init_ui_hook) PARAMS ((void));
+void (*pre_init_ui_hook) (void);
#ifdef __MSDOS__
void
@@ -2939,7 +2939,7 @@ make_cleanup_free_command_lines (struct
struct cmd_list_element *
add_info (name, fun, doc)
char *name;
- void (*fun) PARAMS ((char *, int));
+ void (*fun) (char *, int);
char *doc;
{
return add_cmd (name, no_class, fun, doc, &infolist);
@@ -3013,7 +3013,7 @@ struct cmd_list_element *
add_com (name, class, fun, doc)
char *name;
enum command_class class;
- void (*fun) PARAMS ((char *, int));
+ void (*fun) (char *, int);
char *doc;
{
return add_cmd (name, class, fun, doc, &cmdlist);
Index: tracepoint.c
===================================================================
RCS file: /cvs/src/src/gdb/tracepoint.c,v
retrieving revision 1.6
diff -u -p -r1.6 tracepoint.c
--- tracepoint.c 2000/05/28 01:12:32 1.6
+++ tracepoint.c 2000/05/30 22:14:25
@@ -58,9 +58,9 @@
extern int info_verbose;
-extern void (*readline_begin_hook) PARAMS ((char *,...));
-extern char *(*readline_hook) PARAMS ((char *));
-extern void (*readline_end_hook) PARAMS ((void));
+extern void (*readline_begin_hook) (char *, ...);
+extern char *(*readline_hook) (char *);
+extern void (*readline_end_hook) (void);
extern void x_command (char *, int);
extern int addressprint; /* Print machine addresses? */
Index: tracepoint.h
===================================================================
RCS file: /cvs/src/src/gdb/tracepoint.h,v
retrieving revision 1.2
diff -u -p -r1.2 tracepoint.h
--- tracepoint.h 2000/05/28 01:12:32 1.2
+++ tracepoint.h 2000/05/30 22:14:25
@@ -115,11 +115,11 @@ extern unsigned long trace_running_p;
/* A hook used to notify the UI of tracepoint operations */
-void (*create_tracepoint_hook) PARAMS ((struct tracepoint *));
-void (*delete_tracepoint_hook) PARAMS ((struct tracepoint *));
-void (*modify_tracepoint_hook) PARAMS ((struct tracepoint *));
-void (*trace_find_hook) PARAMS ((char *arg, int from_tty));
-void (*trace_start_stop_hook) PARAMS ((int start, int from_tty));
+void (*create_tracepoint_hook) (struct tracepoint *);
+void (*delete_tracepoint_hook) (struct tracepoint *);
+void (*modify_tracepoint_hook) (struct tracepoint *);
+void (*trace_find_hook) (char *arg, int from_tty);
+void (*trace_start_stop_hook) (int start, int from_tty);
struct tracepoint *get_tracepoint_by_number (char **, int, int);
int get_traceframe_number (void);
Index: utils.c
===================================================================
RCS file: /cvs/src/src/gdb/utils.c,v
retrieving revision 1.14
diff -u -p -r1.14 utils.c
--- utils.c 2000/05/28 01:12:33 1.14
+++ utils.c 2000/05/30 22:14:31
@@ -58,7 +58,7 @@
/* readline defines this. */
#undef savestring
-void (*error_begin_hook) PARAMS ((void));
+void (*error_begin_hook) (void);
/* Holds the last error message issued by gdb */
@@ -426,7 +426,7 @@ null_cleanup (void *arg)
cmd_continuation. The new continuation will be added at the front.*/
void
add_continuation (continuation_hook, arg_list)
- void (*continuation_hook) PARAMS ((struct continuation_arg *));
+ void (*continuation_hook) (struct continuation_arg *);
struct continuation_arg *arg_list;
{
struct continuation *continuation_ptr;
@@ -488,7 +488,7 @@ discard_all_continuations ()
intermediate_continuation. The new continuation will be added at the front.*/
void
add_intermediate_continuation (continuation_hook, arg_list)
- void (*continuation_hook) PARAMS ((struct continuation_arg *));
+ void (*continuation_hook) (struct continuation_arg *);
struct continuation_arg *arg_list;
{
struct continuation *continuation_ptr;
@@ -1421,8 +1421,8 @@ static void printchar (int c, void (*do_
static void
printchar (c, do_fputs, do_fprintf, stream, quoter)
int c;
- void (*do_fputs) PARAMS ((const char *, struct ui_file*));
- void (*do_fprintf) PARAMS ((struct ui_file*, const char *, ...));
+ void (*do_fputs) (const char *, struct ui_file *);
+ void (*do_fprintf) (struct ui_file *, const char *, ...);
struct ui_file *stream;
int quoter;
{
Index: v850ice.c
===================================================================
RCS file: /cvs/src/src/gdb/v850ice.c,v
retrieving revision 1.2
diff -u -p -r1.2 v850ice.c
--- v850ice.c 2000/05/28 01:12:33 1.2
+++ v850ice.c 2000/05/30 22:14:34
@@ -54,7 +54,7 @@ extern void nexti_command (char *, int);
extern void continue_command (char *, int);
-extern int (*ui_loop_hook) PARAMS ((int));
+extern int (*ui_loop_hook) (int);
/* Prototypes for local functions */
static int init_hidden_window (void);
@@ -121,17 +121,17 @@ static void togdb_force_update (void);
static void view_source (CORE_ADDR);
-static void do_gdb (char *, char *, void (*func) PARAMS ((char *, int)), int);
+static void do_gdb (char *, char *, void (*func) (char *, int), int);
/* Globals */
static HWND hidden_hwnd; /* HWND for messages */
-long (__stdcall * ExeAppReq) PARAMS ((char *, long, char *, struct MessageIO *));
+long (__stdcall * ExeAppReq) (char *, long, char *, struct MessageIO *);
-long (__stdcall * RegisterClient) PARAMS ((HWND));
+long (__stdcall * RegisterClient) (HWND);
-long (__stdcall * UnregisterClient) PARAMS ((void));
+long (__stdcall * UnregisterClient) (void);
extern Tcl_Interp *gdbtk_interp;
@@ -346,11 +346,11 @@ v850ice_open (name, from_tty)
if (handle == NULL)
error ("Cannot load necmsg.dll");
- ExeAppReq = (long (*)PARAMS ((char *, long, char *, struct MessageIO *)))
+ ExeAppReq = (long (*) (char *, long, char *, struct MessageIO *))
GetProcAddress (handle, "ExeAppReq");
- RegisterClient = (long (*)PARAMS ((HWND)))
+ RegisterClient = (long (*) (HWND))
GetProcAddress (handle, "RegisterClient");
- UnregisterClient = (long (*)PARAMS ((void)))
+ UnregisterClient = (long (*) (void))
GetProcAddress (handle, "UnregisterClient");
if (ExeAppReq == NULL || RegisterClient == NULL || UnregisterClient == NULL)
@@ -855,7 +855,7 @@ static void
do_gdb (cmd, str, func, count)
char *cmd;
char *str;
- void (*func) PARAMS ((char *, int));
+ void (*func) (char *, int);
int count;
{
ReplyMessage ((LRESULT) 1);
Index: varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/varobj.c,v
retrieving revision 1.5
diff -u -p -r1.5 varobj.c
--- varobj.c 2000/05/28 01:12:33 1.5
+++ varobj.c 2000/05/30 22:14:47
@@ -287,28 +287,28 @@ struct language_specific
enum varobj_languages language;
/* The number of children of PARENT. */
- int (*number_of_children) PARAMS ((struct varobj * parent));
+ int (*number_of_children) (struct varobj * parent);
/* The name (expression) of a root varobj. */
- char *(*name_of_variable) PARAMS ((struct varobj * parent));
+ char *(*name_of_variable) (struct varobj * parent);
/* The name of the INDEX'th child of PARENT. */
- char *(*name_of_child) PARAMS ((struct varobj * parent, int index));
+ char *(*name_of_child) (struct varobj * parent, int index);
/* The value_ptr of the root variable ROOT. */
- value_ptr (*value_of_root) PARAMS ((struct varobj ** root_handle));
+ value_ptr (*value_of_root) (struct varobj ** root_handle);
/* The value_ptr of the INDEX'th child of PARENT. */
- value_ptr (*value_of_child) PARAMS ((struct varobj * parent, int index));
+ value_ptr (*value_of_child) (struct varobj * parent, int index);
/* The type of the INDEX'th child of PARENT. */
- struct type *(*type_of_child) PARAMS ((struct varobj * parent, int index));
+ struct type *(*type_of_child) (struct varobj * parent, int index);
/* Is VAR editable? */
- int (*variable_editable) PARAMS ((struct varobj * var));
+ int (*variable_editable) (struct varobj * var);
/* The current value of VAR. */
- char *(*value_of_variable) PARAMS ((struct varobj * var));
+ char *(*value_of_variable) (struct varobj * var);
};
/* Array of known source language routines. */
Index: win32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.8
diff -u -p -r1.8 win32-nat.c
--- win32-nat.c 2000/05/28 01:12:33 1.8
+++ win32-nat.c 2000/05/30 22:14:50
@@ -52,7 +52,7 @@
#include <unistd.h>
/* The ui's event loop. */
-extern int (*ui_loop_hook) PARAMS ((int signo));
+extern int (*ui_loop_hook) (int signo);
/* If we're not using the old Cygwin header file set, define the
following which never should have been in the generic Win32 API
Index: wince.c
===================================================================
RCS file: /cvs/src/src/gdb/wince.c,v
retrieving revision 1.6
diff -u -p -r1.6 wince.c
--- wince.c 2000/05/28 01:12:33 1.6
+++ wince.c 2000/05/30 22:14:52
@@ -58,7 +58,7 @@
#include <time.h>
/* The ui's event loop. */
-extern int (*ui_loop_hook) PARAMS ((int signo));
+extern int (*ui_loop_hook) (int signo);
/* If we're not using the old Cygwin header file set, define the
following which never should have been in the generic Win32 API
Index: xcoffsolib.c
===================================================================
RCS file: /cvs/src/src/gdb/xcoffsolib.c,v
retrieving revision 1.3
diff -u -p -r1.3 xcoffsolib.c
--- xcoffsolib.c 2000/05/28 01:12:33 1.3
+++ xcoffsolib.c 2000/05/30 22:14:56
@@ -34,7 +34,7 @@
hook is initialized in by rs6000-nat.c. If not, it is currently left
NULL and never called. */
-void (*xcoff_relocate_symtab_hook) PARAMS ((unsigned int)) = NULL;
+void (*xcoff_relocate_symtab_hook) (unsigned int) = NULL;
#ifdef SOLIB_SYMBOLS_MANUAL
Index: xcoffsolib.h
===================================================================
RCS file: /cvs/src/src/gdb/xcoffsolib.h,v
retrieving revision 1.1.1.2
diff -u -p -r1.1.1.2 xcoffsolib.h
--- xcoffsolib.h 1999/07/07 20:11:18 1.1.1.2
+++ xcoffsolib.h 2000/05/30 22:14:56
@@ -58,4 +58,4 @@ extern struct vmap *vmap;
/* Hook for symbol table relocation at runtime. */
-extern void (*xcoff_relocate_symtab_hook) PARAMS ((unsigned int));
+extern void (*xcoff_relocate_symtab_hook) (unsigned int);
Index: config/rs6000/tm-rs6000.h
===================================================================
RCS file: /cvs/src/src/gdb/config/rs6000/tm-rs6000.h,v
retrieving revision 1.4
diff -u -p -r1.4 tm-rs6000.h
--- tm-rs6000.h 2000/05/28 01:12:39 1.4
+++ tm-rs6000.h 2000/05/30 22:15:29
@@ -512,7 +512,7 @@ extern void rs6000_fix_call_dummy (char
/* Hook in rs6000-tdep.c for determining the TOC address when
calling functions in the inferior. */
extern
-CORE_ADDR (*find_toc_address_hook) PARAMS ((CORE_ADDR));
+CORE_ADDR (*find_toc_address_hook) (CORE_ADDR);
/* xcoffread.c provides a function to determine the TOC offset
for a given object file.
Index: testsuite/gdb.base/callfuncs.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/callfuncs.c,v
retrieving revision 1.1.1.2
diff -u -p -r1.1.1.2 callfuncs.c
--- callfuncs.c 1999/06/28 16:02:51 1.1.1.2
+++ callfuncs.c 2000/05/30 22:16:21
@@ -2,12 +2,6 @@
in the inferior, pass appropriate arguments to those functions,
and get the returned result. */
-#ifdef NO_PROTOTYPES
-#define PARAMS(paramlist) ()
-#else
-#define PARAMS(paramlist) paramlist
-#endif
-
# include <stdlib.h>
# include <string.h>
@@ -67,8 +61,8 @@ int doubleit (a) int a;
return (a + a);
}
-int (*func_val1) PARAMS((int,int)) = add;
-int (*func_val2) PARAMS((int)) = doubleit;
+int (*func_val1) (int,int) = add;
+int (*func_val2) (int) = doubleit;
/* An enumeration and functions that test for specific values. */
@@ -339,8 +333,8 @@ char char_array_arg1[], char_array_arg2[
int t_func_values (int (*func_arg1)(int, int), int (*func_arg2)(int))
#else
int t_func_values (func_arg1, func_arg2)
-int (*func_arg1) PARAMS ((int, int));
-int (*func_arg2) PARAMS ((int));
+int (*func_arg1) (int, int);
+int (*func_arg2) (int);
#endif
{
return ((*func_arg1) (5,5) == (*func_val1) (5,5)
@@ -351,7 +345,7 @@ int (*func_arg2) PARAMS ((int));
int t_call_add (int (*func_arg1)(int, int), int a, int b)
#else
int t_call_add (func_arg1, a, b)
-int (*func_arg1) PARAMS ((int, int));
+int (*func_arg1) (int, int);
int a, b;
#endif
{
Index: testsuite/gdb.base/callfwmall.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/callfwmall.c,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 callfwmall.c
--- callfwmall.c 1999/07/12 18:08:43 1.1.1.1
+++ callfwmall.c 2000/05/30 22:16:21
@@ -2,12 +2,6 @@
in an inferior which doesn't itself call malloc, pass appropriate
arguments to those functions, and get the returned result. */
-#ifdef NO_PROTOTYPES
-#define PARAMS(paramlist) ()
-#else
-#define PARAMS(paramlist) paramlist
-#endif
-
# include <string.h>
char char_val1 = 'a';
@@ -67,8 +61,8 @@ int a;
return (a + a);
}
-int (*func_val1) PARAMS((int,int)) = add;
-int (*func_val2) PARAMS((int)) = doubleit;
+int (*func_val1) (int,int) = add;
+int (*func_val2) (int) = doubleit;
/* An enumeration and functions that test for specific values. */
@@ -331,8 +325,8 @@ char char_array_arg1[], char_array_arg2[
int t_func_values (int (*func_arg1)(int, int), int (*func_arg2)(int))
#else
int t_func_values (func_arg1, func_arg2)
-int (*func_arg1) PARAMS ((int, int));
-int (*func_arg2) PARAMS ((int));
+int (*func_arg1) (int, int);
+int (*func_arg2) (int);
#endif
{
return ((*func_arg1) (5,5) == (*func_val1) (5,5)
@@ -343,7 +337,7 @@ int (*func_arg2) PARAMS ((int));
int t_call_add (int (*func_arg1)(int, int), int a, int b)
#else
int t_call_add (func_arg1, a, b)
-int (*func_arg1) PARAMS ((int, int));
+int (*func_arg1) (int, int);
int a, b;
#endif
{
Index: testsuite/gdb.base/overlays.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/overlays.c,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 overlays.c
--- overlays.c 1999/04/16 01:34:31 1.1.1.1
+++ overlays.c 2000/05/30 22:16:24
@@ -3,10 +3,10 @@
#include "ovlymgr.h"
-extern int foo PARAMS((int));
-extern int bar PARAMS((int));
-extern int baz PARAMS((int));
-extern int grbx PARAMS((int));
+extern int foo (int);
+extern int bar (int);
+extern int baz (int);
+extern int grbx(int);
int main ()
{
Index: testsuite/gdb.base/ovlymgr.h
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/ovlymgr.h,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 ovlymgr.h
--- ovlymgr.h 1999/04/16 01:34:31 1.1.1.1
+++ ovlymgr.h 2000/05/30 22:16:24
@@ -2,16 +2,10 @@
* Sample runtime overlay manager.
*/
-#ifdef NO_PROTOTYPES
-#define PARAMS(paramlist) ()
-#else
-#define PARAMS(paramlist) paramlist
-#endif
-
typedef enum { FALSE, TRUE } bool;
/* Entry Points: */
-bool OverlayLoad PARAMS((unsigned long ovlyno));
-bool OverlayUnload PARAMS((unsigned long ovlyno));
+bool OverlayLoad (unsigned long ovlyno);
+bool OverlayUnload (unsigned long ovlyno);
Index: tui/tui.h
===================================================================
RCS file: /cvs/src/src/gdb/tui/tui.h,v
retrieving revision 1.3
diff -u -p -r1.3 tui.h
--- tui.h 2000/05/28 01:12:42 1.3
+++ tui.h 2000/05/30 22:16:49
@@ -26,15 +26,15 @@
/* Opaque data type */
typedef char *Opaque;
typedef
-Opaque (*OpaqueFuncPtr) PARAMS ((va_list));
+Opaque (*OpaqueFuncPtr) (va_list);
typedef char **OpaqueList;
typedef OpaqueList OpaquePtr;
/* Generic function pointer */
- typedef void (*TuiVoidFuncPtr) PARAMS ((va_list));
- typedef int (*TuiIntFuncPtr) PARAMS ((va_list));
+typedef void (*TuiVoidFuncPtr) (va_list);
+typedef int (*TuiIntFuncPtr) (va_list);
/*
- typedef Opaque (*TuiOpaqueFuncPtr) PARAMS ((va_list));
+typedef Opaque (*TuiOpaqueFuncPtr) (va_list);
*/
typedef OpaqueFuncPtr TuiOpaqueFuncPtr;
Index: tui/tuiIO.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tuiIO.c,v
retrieving revision 1.2
diff -u -p -r1.2 tuiIO.c
--- tuiIO.c 2000/05/28 01:12:42 1.2
+++ tuiIO.c 2000/05/30 22:16:52
@@ -112,7 +112,7 @@ void
tui_tputs (str, affcnt, putfunc)
char *str;
int affcnt;
- int (*putfunc) PARAMS ((int));
+ int (*putfunc) (int);
{
extern char *rl_prompt; /* the prompt string */
@@ -602,7 +602,7 @@ tuiTermSetup (turn_off_echo)
{
/* Un-do the effect of the memory lock in terminal_inferior() */
- tputs (term_memory_unlock, 1, (int (*)PARAMS ((int))) putchar);
+ tputs (term_memory_unlock, 1, (int (*) (int)) putchar);
fflush (stdout);
}
@@ -618,7 +618,7 @@ tuiTermSetup (turn_off_echo)
/* Set scroll region to be 0..end */
buffer = (char *) tgoto (term_scroll_region, end, 0);
- tputs (buffer, 1, (int (*)PARAMS ((int))) putchar);
+ tputs (buffer, 1, (int (*) (int)) putchar);
} /* else we're out of luck */
@@ -708,8 +708,8 @@ tuiTermUnsetup (turn_on_echo, to_column)
* So first position the cursor, then call memory lock.
*/
buffer = tgoto (term_cursor_move, 0, start);
- tputs (buffer, 1, (int (*)PARAMS ((int))) putchar);
- tputs (term_memory_lock, 1, (int (*)PARAMS ((int))) putchar);
+ tputs (buffer, 1, (int (*) (int)) putchar);
+ tputs (term_memory_lock, 1, (int (*) (int)) putchar);
}
else if (term_scroll_region)
@@ -717,17 +717,17 @@ tuiTermUnsetup (turn_on_echo, to_column)
/* Set the scroll region to the command window */
buffer = tgoto (term_scroll_region, end, start);
- tputs (buffer, 1, (int (*)PARAMS ((int))) putchar);
+ tputs (buffer, 1, (int (*) (int)) putchar);
} /* else we can't do anything about target I/O */
/* Also turn off standout mode, in case it is on */
if (term_se != NULL)
- tputs (term_se, 1, (int (*)PARAMS ((int))) putchar);
+ tputs (term_se, 1, (int (*) (int)) putchar);
/* Now go to the appropriate spot on the end line */
buffer = tgoto (term_cursor_move, to_column, end);
- tputs (buffer, 1, (int (*)PARAMS ((int))) putchar);
+ tputs (buffer, 1, (int (*) (int)) putchar);
fflush (stdout);
tui_owns_terminal = 0;
Index: tui/tuiLayout.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tuiLayout.c,v
retrieving revision 1.2
diff -u -p -r1.2 tuiLayout.c
--- tuiLayout.c 2000/05/28 01:12:42 1.2
+++ tuiLayout.c 2000/05/30 22:16:53
@@ -20,18 +20,15 @@
** Static Local Decls
********************************/
-static void _initGenWinInfo PARAMS
- ((TuiGenWinInfoPtr, TuiWinType, int, int, int, int));
-static void _initAndMakeWin PARAMS
- ((Opaque *, TuiWinType, int, int, int, int, int));
-static void _showSourceOrDisassemAndCommand PARAMS
- ((TuiLayoutType));
-static void _makeSourceOrDisassemWindow PARAMS
- ((TuiWinInfoPtr *, TuiWinType, int, int));
+static void _initGenWinInfo
+ (TuiGenWinInfoPtr, TuiWinType, int, int, int, int);
+static void _initAndMakeWin (Opaque *, TuiWinType, int, int, int, int, int);
+static void _showSourceOrDisassemAndCommand (TuiLayoutType);
+static void _makeSourceOrDisassemWindow
+ (TuiWinInfoPtr *, TuiWinType, int, int);
static void _makeCommandWindow (TuiWinInfoPtr *, int, int);
static void _makeSourceWindow (TuiWinInfoPtr *, int, int);
-static void _makeDisassemWindow PARAMS
- ((TuiWinInfoPtr *, int, int));
+static void _makeDisassemWindow (TuiWinInfoPtr *, int, int);
static void _makeDataWindow (TuiWinInfoPtr *, int, int);
static void _showSourceCommand (void);
static void _showDisassemCommand (void);
Index: tui/tuiSourceWin.h
===================================================================
RCS file: /cvs/src/src/gdb/tui/tuiSourceWin.h,v
retrieving revision 1.2
diff -u -p -r1.2 tuiSourceWin.h
--- tuiSourceWin.h 2000/05/28 01:12:42 1.2
+++ tuiSourceWin.h 2000/05/30 22:16:56
@@ -6,10 +6,10 @@
extern void tuiDisplayMainFunction (void);
-extern void tuiUpdateSourceWindow PARAMS
- ((TuiWinInfoPtr, struct symtab *, Opaque, int));
-extern void tuiUpdateSourceWindowAsIs PARAMS
- ((TuiWinInfoPtr, struct symtab *, Opaque, int));
+extern void tuiUpdateSourceWindow
+ (TuiWinInfoPtr, struct symtab *, Opaque, int);
+extern void tuiUpdateSourceWindowAsIs
+ (TuiWinInfoPtr, struct symtab *, Opaque, int);
extern void tuiUpdateSourceWindowsWithAddr (Opaque);
extern void tui_vUpdateSourceWindowsWithAddr (va_list);
extern void tuiUpdateSourceWindowsWithLine (struct symtab *, int);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2000-05-31 3:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <3933676F.676D861C@cygnus.com>
[not found] ` <1000530153706.ZM32196@ocotillo.lan>
[not found] ` <3934454E.AAB68F28@cygnus.com>
2000-05-30 16:42 ` [rfa] Add a name field to ``struct floatformat'' Kevin Buettner
2000-05-30 19:18 ` Andrew Cagney
[not found] ` <3933695B.6CE1380D@cygnus.com>
2000-05-31 3:58 ` Andrew Cagney
[not found] <9703.959716280@upchuck>
2000-05-30 15:47 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox