Re: [PATCH 1/2] gdb: add maintenance set/show gcore xml-target-description command

[Keith Seitz <keiths@redhat.com>]

Hi,

On 6/2/26 4:11 AM, Christina Schimpe wrote:
> From: Felix Willgerodt <felix.willgerodt@intel.com>
> 
> This command will allow to enable/disable creating the NT_GDB_TDESC note
> in corefiles.  While GDB writes and reads this node, there aren't really many
> other pieces of software that create this node (e.g. the Linux kernel doesn't).
> To be able to test the code path in GDB that is used when NT_GDB_TDESC is not
> there, add a maintenance command which tests can use to test both cases.

Thank you for working on supporting Intel APX. I just have a tiny nit
or two on this patch which otherwise LGTM.

> diff --git a/gdb/gcore.c b/gdb/gcore.c
> index e50115370c7..03876969ae9 100644
> --- a/gdb/gcore.c
> +++ b/gdb/gcore.c
> @@ -928,4 +947,25 @@ Usage: generate-core-file [FILENAME]\n\
>   Argument is optional filename.  Default filename is 'core.PROCESS_ID'."));
>   
>     add_com_alias ("gcore", generate_core_file_cmd, class_files, 1);
> +
> +  add_basic_prefix_cmd ("gcore", class_maintenance,
> +			_("gcore maintenance commands."),
> +			&maint_gcore_cmdlist, 0, &maintenancelist);
> +
> +  add_setshow_prefix_cmd ("gcore", class_maintenance,
> +			  _("Set gcore specific variables."),
> +			  _("Show gcore specific variables."),
> +			  &maint_gcore_set_cmdlist, &maint_gcore_show_cmdlist,
> +			  &maintenance_set_cmdlist, &maintenance_show_cmdlist);
> +
> +  add_setshow_boolean_cmd ("xml-target-description", class_obscure,
> +			    &maint_gcore_emit_xml_tdesc, _("\
> +Set whether gcore emits a xml-target-description."), _("\
> +Show whether gore emits a xml-target-description."), _("\
                 ^^^^

In case it hasn't been mentioned, this should be "gcore".
Super nit (sorry): please use "an xml-target-description".

> +By default, gcore emits the note NT_GDB_TDESC.\n\
> +Disabling this setting will cause gcore to no longer emit this note."),
> +			    nullptr,
> +			    show_gcore_xml_target_description,
> +			    &maint_gcore_set_cmdlist,
> +			    &maint_gcore_show_cmdlist);
>   }

Reviewed-By: Keith Seitz <keiths@redhat.com>

Keith