From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QX/1A3krNGrA1g0AWB0awg (envelope-from ) for ; Thu, 18 Jun 2026 13:31:37 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=enhYjuBe; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F03FC1E070; Thu, 18 Jun 2026 13:31:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 38C071E070 for ; Thu, 18 Jun 2026 13:31:36 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E775A4B9DB6F for ; Thu, 18 Jun 2026 17:31:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E775A4B9DB6F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=enhYjuBe Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id E5D694BA799B for ; Thu, 18 Jun 2026 17:31:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E5D694BA799B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E5D694BA799B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781803869; cv=none; b=Rp51bTNIQHYCf+7wBFbD4jhK6Bjl40uVpH9MLBxa3RlfKCYE2ml+HKtmfV5puTppnReB3PPDZ9YCMAieANkK390pi3rHQKCgEjpUgAyivFMvu1Lim/oVkqF07cqt3rRrsaPyOZJgySVWGnEuF8bGb6j/zS5ud3XeX0fHjtktfzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781803869; c=relaxed/simple; bh=4apnAYwHYrNbnXZs7iXYvYaE0QuZdmcvMIhvf3C8q40=; h=DKIM-Signature:Message-ID:Date:MIME-Version:From:Subject:To; b=keH8WPrAsRRd5fej6P5jp4I924ApP+LBeSWaY/LD/JRnrMPYgePTZsNHeC+V9VeJ8y50t2UjEjQRTMw45zdM0jixhFaaUMxjbzcDaDIXUR0BwU1U2BqViSEPzs0oFdO7xYbb0q3K+z7nSrD0uaT4dpXTsa5en858ooxvSIsCnF0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=enhYjuBe DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E5D694BA799B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781803868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+FaoEVx/XiNp7ovdizxIjBmCDvbARs8NNYoYNMcuv3k=; b=enhYjuBeKQlDWPIuvWQ8FZ0OtxFquz4JOM4KcBMgqOG9LpYXPPhp8vZE99P1CwWWTITTl/ 2DXDEyj34RCnBwpduPR0Y56O5v7uOhXc9H+HFF0lQe1V9mRo0xo+8A0CIAaPmDAovZTHgv o3MzPxLNClfaWLl/gBrcjtwDnRdkXZc= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-tdES3dqxMTaSZ-b04Ldm2Q-1; Thu, 18 Jun 2026 13:31:07 -0400 X-MC-Unique: tdES3dqxMTaSZ-b04Ldm2Q-1 X-Mimecast-MFC-AGG-ID: tdES3dqxMTaSZ-b04Ldm2Q_1781803866 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5177b8def69so23215941cf.2 for ; Thu, 18 Jun 2026 10:31:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781803866; x=1782408666; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+FaoEVx/XiNp7ovdizxIjBmCDvbARs8NNYoYNMcuv3k=; b=ScqljYEKzem8lGnBt2AVN7Xp9azz4/Bsu7shDPYL0L+NCkDW+AblwgqRMsWoJBoXv6 EGzfqbwpb5iCytpq652wEQNUSb3MRbGPUO93HfrnvEySB0CR/p//XOsuB9777FPQEMWM RP4ZwZ61IAtFNU4RYNAhtJWR2go4IJcWsuMM/XHmOn2fmqEgeVzAErsBP+k1fwd1C6Dk koZZWGa24IJn5cRl6Z6oV5l7AvUdrCihZ4/DsxHgkQR2bt/adosoWWPys84vcUtmT5fB oQoyBdhVuN2t3ZKhzqgKFM5+zOmc5nQBWsntjYWLcgtaR1RCToi3Kf8eX5KBKLUSFQYr JMdw== X-Forwarded-Encrypted: i=1; AFNElJ9Ku4IQf648I1HiYOzq6oGvOj1OS7qgox21Zft1yrPrDoBI2ZUst21pSvaPLgCo4MbJVnSyvZnBsEWumA==@sourceware.org X-Gm-Message-State: AOJu0YxCEDg088kGO2znz7a5CGlb9BUYZmuaIYWZQSJaqXNuY9cszlTp B9yZXDXoFc6ZiOwMJ3uUxrVg+eT8mtqDEbRRjy6HtX06PIKkG3G0mDbgyQ/U/I0SAKUsaRnGuAi lmY/9y8sNzdUfe+0FId+C559iDfDkEsguZxIv4vP2spvQsIktTo9wQlijYcq/xd4= X-Gm-Gg: AfdE7cliBTq0bpXlnaufQ0R+wUqOnMmz5hct/UkD4376FyOnUinnlvlW5SkF6kp4ijv ex3HuLH/Z0wMYlDYQ78epovbZGmDCh/BJB8lGxHpjNkOHqqiE3pVz+X07+mbu9SXi+A9BySxSWz urlQyZ6vBzBCUIUyXFVBYlvGyIGwu+SjbD1V5xCa3WmOqqiAM3FUBRKPCkOxw5Mn+l7U7mNeGe5 4dHOlZQOtovzrrIKeEQ3fOw6C+NfVC7dNiTeGUXb/B9OKG4wlsXT+x0hW/UOSnQCCPhir3KUVG3 u2SRX/kERKHcPmEtD4MnC2HiAWKTS+Oq/dS/ODzv2R0R6F7hio1cWXlxQcKZIwflOEPfaA5w021 mjZrB79dS9b1Y4pe9og== X-Received: by 2002:a05:622a:58c6:b0:516:e085:b76e with SMTP id d75a77b69052e-519e46ca57dmr3073571cf.0.1781803866214; Thu, 18 Jun 2026 10:31:06 -0700 (PDT) X-Received: by 2002:a05:622a:58c6:b0:516:e085:b76e with SMTP id d75a77b69052e-519e46ca57dmr3072961cf.0.1781803865565; Thu, 18 Jun 2026 10:31:05 -0700 (PDT) Received: from [150.1.200.157] ([172.56.105.224]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-519e4e61f2fsm390161cf.8.2026.06.18.10.31.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 10:31:05 -0700 (PDT) Message-ID: <39064284-dcaa-45ee-a504-1475803f66eb@redhat.com> Date: Thu, 18 Jun 2026 10:31:03 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Keith Seitz Subject: Re: [PATCH 1/2] gdb: add maintenance set/show gcore xml-target-description command To: Christina Schimpe , gdb-patches@sourceware.org Cc: hjl.tools@gmail.com References: <20260602111122.3187712-1-christina.schimpe@intel.com> <20260602111122.3187712-2-christina.schimpe@intel.com> In-Reply-To: <20260602111122.3187712-2-christina.schimpe@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xzjhMQDxAQlcLisJzokharOJfyKTDP-ySW9Bd-16PGI_1781803866 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 6/2/26 4:11 AM, Christina Schimpe wrote: > From: Felix Willgerodt > > This command will allow to enable/disable creating the NT_GDB_TDESC note > in corefiles. While GDB writes and reads this node, there aren't really many > other pieces of software that create this node (e.g. the Linux kernel doesn't). > To be able to test the code path in GDB that is used when NT_GDB_TDESC is not > there, add a maintenance command which tests can use to test both cases. Thank you for working on supporting Intel APX. I just have a tiny nit or two on this patch which otherwise LGTM. > diff --git a/gdb/gcore.c b/gdb/gcore.c > index e50115370c7..03876969ae9 100644 > --- a/gdb/gcore.c > +++ b/gdb/gcore.c > @@ -928,4 +947,25 @@ Usage: generate-core-file [FILENAME]\n\ > Argument is optional filename. Default filename is 'core.PROCESS_ID'.")); > > add_com_alias ("gcore", generate_core_file_cmd, class_files, 1); > + > + add_basic_prefix_cmd ("gcore", class_maintenance, > + _("gcore maintenance commands."), > + &maint_gcore_cmdlist, 0, &maintenancelist); > + > + add_setshow_prefix_cmd ("gcore", class_maintenance, > + _("Set gcore specific variables."), > + _("Show gcore specific variables."), > + &maint_gcore_set_cmdlist, &maint_gcore_show_cmdlist, > + &maintenance_set_cmdlist, &maintenance_show_cmdlist); > + > + add_setshow_boolean_cmd ("xml-target-description", class_obscure, > + &maint_gcore_emit_xml_tdesc, _("\ > +Set whether gcore emits a xml-target-description."), _("\ > +Show whether gore emits a xml-target-description."), _("\ ^^^^ In case it hasn't been mentioned, this should be "gcore". Super nit (sorry): please use "an xml-target-description". > +By default, gcore emits the note NT_GDB_TDESC.\n\ > +Disabling this setting will cause gcore to no longer emit this note."), > + nullptr, > + show_gcore_xml_target_description, > + &maint_gcore_set_cmdlist, > + &maint_gcore_show_cmdlist); > } Reviewed-By: Keith Seitz Keith