Re: RFA: symfile.c: Fix for GDB crash when rereading symbols

Re: RFA: symfile.c: Fix for GDB crash when rereading symbols

[Michael Snyder]

Peter.Schauer wrote:
> 
> symfile.c:reread_symbols does not clear the new msymbol hash tables
> in the objfile, causing stale pointers and a GDB crash during the
> reread.exp test on Solaris.
> 
> Here is a fix:

Great!  I was just noticing that failure last night.
Thanks!
From dima@Chg.RU Tue Mar 14 10:32:00 2000
From: Dmitry Sivachenko <dima@Chg.RU>
To: gdb-patches@sourceware.cygnus.com
Subject: Patch to gdb.texinfo
Date: Tue, 14 Mar 2000 10:32:00 -0000
Message-id: <200003141832.VAA09006@netserv1.chg.ru>
X-SW-Source: 2000-03/msg00253.html
Content-length: 470

Hello!
This patch should fix formatting with makeinfo --html.
Patch was made against revision 1.1.1.14.

--dima

--- gdb.texinfo	Tue Mar 14 18:24:59 2000
+++ gdb.1.1.1.14.texinfo	Tue Mar 14 18:25:36 2000
@@ -114,7 +114,7 @@
 @end titlepage
 @page
 
-@ifinfo
+@ifnottex
 @node Top
 @top Debugging with @value{GDBN}
 
@@ -156,7 +156,7 @@
 * Index::                       Index
 @end menu
 
-@end ifinfo
+@end ifnottex
 
 @node Summary
 @unnumbered Summary of @value{GDBN}
From dima@Chg.RU Tue Mar 14 11:30:00 2000
From: Dmitry Sivachenko <dima@Chg.RU>
To: gdb-patches@sourceware.cygnus.com
Subject: Yet another patch to gdb.texinfo
Date: Tue, 14 Mar 2000 11:30:00 -0000
Message-id: <200003141930.WAA10173@netserv1.chg.ru>
X-SW-Source: 2000-03/msg00254.html
Content-length: 722

I think this is better way to add new entry into dir-file:

Please apply this patch.

--dima


--- gdb.texinfo.old	Tue Mar 14 19:21:28 2000
+++ gdb.texinfo	Tue Mar 14 19:26:58 2000
@@ -32,17 +32,13 @@
 
 @c THIS MANUAL REQUIRES TEXINFO-2 macros and info-makers to format properly.
 
-@ifinfo
 @c This is a dir.info fragment to support semi-automated addition of
 @c manuals to an info tree.  zoo@cygnus.com is developing this facility.
-@format
-START-INFO-DIR-ENTRY
+@dircategory Programming & development tools.
+@direntry
 * Gdb: (gdb).                     The @sc{gnu} debugger.
-END-INFO-DIR-ENTRY
-@end format
-@end ifinfo
-@c
-@c
+@end direntry
+
 @ifinfo
 This file documents the @sc{gnu} debugger @value{GDBN}.
 
From scottb@netwinder.org Tue Mar 14 12:14:00 2000
From: Scott Bambrough <scottb@netwinder.org>
To: gdb-patches@sourceware.cygnus.com
Cc: fnasser@cygnus.com, jingham@cygnus.com
Subject: Patch for arm_push_arguments
Date: Tue, 14 Mar 2000 12:14:00 -0000
Message-id: <38CE9C8B.3EC5B7F1@netwinder.org>
X-SW-Source: 2000-03/msg00255.html
Content-type: multipart/mixed; boundary="----------=_1583534345-29877-3"

This is a multi-part message in MIME format...

------------=_1583534345-29877-3
Content-length: 401

Hi guys,

	* arm-tdep.c (arm_push_arguments): Correctly code for converting a 
	float argument from host format to a target double when preparing the 
	call frame for a function.

This works for me.  Can you try it out.  If it works, let me know and I'll check
it in.

Scott

-- 
Scott Bambrough - Software Engineer
REBEL.COM    http://www.rebel.com
NetWinder    http://www.netwinder.org
armgdb.diff


------------=_1583534345-29877-3
Content-Type: text/x-diff; charset=us-ascii; name="armgdb.diff"
Content-Disposition: inline; filename="armgdb.diff"
Content-Transfer-Encoding: base64
Content-Length: 4201

SW5kZXg6IGFybS10ZGVwLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJD
UyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2FybS10ZGVwLmMsdg0KcmV0cmll
dmluZyByZXZpc2lvbiAxLjQNCmRpZmYgLXUgLXAgLXIxLjQgYXJtLXRkZXAu
Yw0KLS0tIGFybS10ZGVwLmMJMjAwMC8wMi8yOSAwNzoyMzowMgkxLjQNCisr
KyBhcm0tdGRlcC5jCTIwMDAvMDMvMTQgMTg6NTg6NDYNCkBAIC0yNCw2ICsy
NCw3IEBADQogI2luY2x1ZGUgImluZmVyaW9yLmgiDQogI2luY2x1ZGUgImdk
YmNtZC5oIg0KICNpbmNsdWRlICJnZGJjb3JlLmgiDQorI2luY2x1ZGUgImZs
b2F0Zm9ybWF0LmgiDQogI2luY2x1ZGUgInN5bWZpbGUuaCINCiAjaW5jbHVk
ZSAiZ2RiX3N0cmluZy5oIg0KICNpbmNsdWRlICJjb2ZmL2ludGVybmFsLmgi
CS8qIEludGVybmFsIGZvcm1hdCBvZiBDT0ZGIHN5bWJvbHMgaW4gQkZEICov
DQpAQCAtODYsMjQgKzg3LDYgQEAgc3RydWN0IGZyYW1lX2V4dHJhX2luZm8N
CiAjZGVmaW5lIE1BS0VfVEhVTUJfQUREUihhZGRyKQkoKGFkZHIpIHwgMSkN
CiAjZGVmaW5lIFVOTUFLRV9USFVNQl9BRERSKGFkZHIpICgoYWRkcikgJiB+
MSkNCiANCi0jZGVmaW5lIFNXQVBfVEFSR0VUX0FORF9IT1NUKGJ1ZmZlcixs
ZW4pIAkJCQlcDQotICBkbwkJCQkJCQkJCVwNCi0gICAgewkJCQkJCQkJCVwN
Ci0gICAgICBpZiAoVEFSR0VUX0JZVEVfT1JERVIgIT0gSE9TVF9CWVRFX09S
REVSKQkJCQlcDQotCXsJCQkJCQkJCVwNCi0JICBjaGFyIHRtcDsJCQkJCQkJ
XA0KLQkgIGNoYXIgKnAgPSAoY2hhciAqKShidWZmZXIpOwkJCQkJXA0KLQkg
IGNoYXIgKnEgPSAoKGNoYXIgKikoYnVmZmVyKSkgKyBsZW4gLSAxOwkJICAg
CVwNCi0JICBmb3IgKDsgcCA8IHE7IHArKywgcS0tKQkJCQkgCVwNCi0JICAg
IHsJCQkJCQkJCVwNCi0JICAgICAgdG1wID0gKnE7CQkJCQkJCVwNCi0JICAg
ICAgKnEgPSAqcDsJCQkJCQkJXA0KLQkgICAgICAqcCA9IHRtcDsJCQkJCQkJ
XA0KLQkgICAgfQkJCQkJCQkJXA0KLQl9CQkJCQkJCQlcDQotICAgIH0JCQkJ
CQkJCQlcDQotICB3aGlsZSAoMCkNCi0NCiAvKiBXaWxsIGEgZnVuY3Rpb24g
cmV0dXJuIGFuIGFnZ3JlZ2F0ZSB0eXBlIGluIG1lbW9yeSBvciBpbiBhDQog
ICAgcmVnaXN0ZXI/ICBSZXR1cm4gMCBpZiBhbiBhZ2dyZWdhdGUgdHlwZSBj
YW4gYmUgcmV0dXJuZWQgaW4gYQ0KICAgIHJlZ2lzdGVyLCAxIGlmIGl0IG11
c3QgYmUgcmV0dXJuZWQgaW4gbWVtb3J5LiAgKi8NCkBAIC0xMjM1LDI3ICsx
MjE4LDE2IEBAIGFybV9wdXNoX2FyZ3VtZW50cyAoaW50IG5hcmdzLCB2YWx1
ZV9wdHINCiAgICAgICAgICBjYWxsaW5nIHRoZSBmdW5jdGlvbi4gICovDQog
ICAgICAgaWYgKFRZUEVfQ09ERV9GTFQgPT0gdHlwZWNvZGUgJiYgUkVHSVNU
RVJfU0laRSA9PSBsZW4pDQogCXsNCi0JICBmbG9hdCBmOw0KLQkgIGRvdWJs
ZSBkOw0KLQkgIGNoYXIgKiBidWZvID0gKGNoYXIgKikgJmQ7DQotCSAgY2hh
ciAqIGJ1ZmQgPSAoY2hhciAqKSAmZGJsX2FyZzsNCi0NCi0JICBsZW4gPSBz
aXplb2YgKGRvdWJsZSk7DQotCSAgZiA9ICooZmxvYXQgKikgdmFsOw0KLQkg
IFNXQVBfVEFSR0VUX0FORF9IT1NUICgmZiwgc2l6ZW9mIChmbG9hdCkpOyAg
LyogYWRqdXN0IGVuZGlhbmVzcyAqLw0KLQkgIGQgPSBmOw0KLQkgIC8qIFdl
IG11c3QgcmV2ZXJ0IHRoZSBsb25nd29yZHMgc28gdGhleSBnZXQgbG9hZGVk
IGludG8gdGhlDQotCSAgICAgdGhlIHJpZ2h0IHJlZ2lzdGVycy4gKi8NCi0J
ICBtZW1jcHkgKGJ1ZmQsIGJ1Zm8gKyBsZW4gLyAyLCBsZW4gLyAyKTsNCi0J
ICBTV0FQX1RBUkdFVF9BTkRfSE9TVCAoYnVmZCwgbGVuIC8gMik7ICAvKiBh
ZGp1c3QgZW5kaWFuZXNzICovDQotCSAgbWVtY3B5IChidWZkICsgbGVuIC8g
MiwgYnVmbywgbGVuIC8gMik7DQotCSAgU1dBUF9UQVJHRVRfQU5EX0hPU1Qg
KGJ1ZmQgKyBsZW4gLyAyLCBsZW4gLyAyKTsgLyogYWRqdXN0IGVuZGlhbmVz
cyAqLw0KKwkgIC8qIEZsb2F0IGFyZ3VtZW50IGluIGJ1ZmZlciBpcyBpbiBo
b3N0IGZvcm1hdC4gIFJlYWQgaXQgYW5kIA0KKwkgICAgIGNvbnZlcnQgdG8g
RE9VQkxFU1QsIGFuZCBzdG9yZSBpdCBpbiB0YXJnZXQgZG91YmxlLiAgKi8N
CisJICBET1VCTEVTVCBkYmx2YWw7DQorCSAgDQorCSAgbGVuID0gVEFSR0VU
X0RPVUJMRV9CSVQgLyBUQVJHRVRfQ0hBUl9CSVQ7DQorCSAgZmxvYXRmb3Jt
YXRfdG9fZG91Ymxlc3QgKEhPU1RfRkxPQVRfRk9STUFULCB2YWwsICZkYmx2
YWwpOw0KKwkgIHN0b3JlX2Zsb2F0aW5nICgmZGJsX2FyZywgbGVuLCBkYmx2
YWwpOw0KIAkgIHZhbCA9IChjaGFyICopICZkYmxfYXJnOw0KIAl9DQotI2lm
IDENCi0gICAgICAvKiBJIGRvbid0IGtub3cgd2h5IHRoaXMgY29kZSB3YXMg
ZGlzYWJsZS4gVGhlIG9ubHkgbG9naWNhbCB1c2UNCi0gICAgICAgICBmb3Ig
YSBmdW5jdGlvbiBwb2ludGVyIGlzIHRvIGNhbGwgdGhhdCBmdW5jdGlvbiwg
c28gc2V0dGluZw0KLSAgICAgICAgIHRoZSBtb2RlIGJpdCBpcyBwZXJmZWN0
bHkgZmluZS4gRk4gKi8NCisNCiAgICAgICAvKiBJZiB0aGUgYXJndW1lbnQg
aXMgYSBwb2ludGVyIHRvIGEgZnVuY3Rpb24sIGFuZCBpdCBpcyBhIFRodW1i
DQogICAgICAgICAgZnVuY3Rpb24sIHNldCB0aGUgbG93IGJpdCBvZiB0aGUg
cG9pbnRlci4gICovDQogICAgICAgaWYgKFRZUEVfQ09ERV9QVFIgPT0gdHlw
ZWNvZGUNCkBAIC0xMjY2LDcgKzEyMzgsNyBAQCBhcm1fcHVzaF9hcmd1bWVu
dHMgKGludCBuYXJncywgdmFsdWVfcHRyDQogCSAgaWYgKGFybV9wY19pc190
aHVtYiAocmVndmFsKSkNCiAJICAgIHN0b3JlX2FkZHJlc3MgKHZhbCwgbGVu
LCBNQUtFX1RIVU1CX0FERFIgKHJlZ3ZhbCkpOw0KIAl9DQotI2VuZGlmDQor
DQogICAgICAgLyogQ29weSB0aGUgYXJndW1lbnQgdG8gZ2VuZXJhbCByZWdp
c3RlcnMgb3IgdGhlIHN0YWNrIGluDQogICAgICAgICAgcmVnaXN0ZXItc2l6
ZWQgcGllY2VzLiAgTGFyZ2UgYXJndW1lbnRzIGFyZSBzcGxpdCBiZXR3ZWVu
DQogICAgICAgICAgcmVnaXN0ZXJzIGFuZCBzdGFjay4gICovDQo=

------------=_1583534345-29877-3--
From fnasser@cygnus.com Tue Mar 14 12:35:00 2000
From: Fernando Nasser <fnasser@cygnus.com>
To: Scott Bambrough <scottb@netwinder.org>
Cc: gdb-patches@sourceware.cygnus.com, jingham@cygnus.com
Subject: Re: Patch for arm_push_arguments
Date: Tue, 14 Mar 2000 12:35:00 -0000
Message-id: <38CEA1FF.CEA9553@cygnus.com>
References: <38CE9C8B.3EC5B7F1@netwinder.org>
X-SW-Source: 2000-03/msg00256.html
Content-length: 712

Scott,

I have to try it on a few targets, so I need a few days.  I will try to run all the tests this week though.

Thanks for doing this.

Fernando


Scott Bambrough wrote:
> 
> Hi guys,
> 
>         * arm-tdep.c (arm_push_arguments): Correctly code for converting a
>         float argument from host format to a target double when preparing the
>         call frame for a function.
> 
> This works for me.  Can you try it out.  If it works, let me know and I'll check
> it in.
> 
> Scott
> 


-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@cygnus.com
2323 Yonge Street, Suite #300           Tel:  416-482-2661 ext. 311
Toronto, Ontario   M4P 2C9              Fax:  416-482-6299
From jimb@zwingli.cygnus.com Tue Mar 14 12:38:00 2000
From: Jim Blandy <jimb@zwingli.cygnus.com>
To: "Peter.Schauer" <Peter.Schauer@regent.e-technik.tu-muenchen.de>
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: RFA: symfile.c: Fix for GDB crash when rereading symbols
Date: Tue, 14 Mar 2000 12:38:00 -0000
Message-id: <npu2i99tjw.fsf@zwingli.cygnus.com>
References: <200003141046.LAA08835@reisser.regent.e-technik.tu-muenchen.de>
X-SW-Source: 2000-03/msg00257.html
Content-length: 296

> symfile.c:reread_symbols does not clear the new msymbol hash tables in the
> objfile, causing stale pointers and a GDB crash during the reread.exp
> test on Solaris.
> 
> Here is a fix:
> 
> 	* symfile.c (reread_symbols):  Clear msymbol hash table.

You're absolutely right.  Thanks very much.
From jimb@zwingli.cygnus.com Tue Mar 14 13:35:00 2000
From: Jim Blandy <jimb@zwingli.cygnus.com>
To: "Peter.Schauer" <Peter.Schauer@regent.e-technik.tu-muenchen.de>
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: RFA: solib.c: Clean fix to get rid of severe Solaris 2.7 sparc regressions
Date: Tue, 14 Mar 2000 13:35:00 -0000
Message-id: <nppusx9qxs.fsf@zwingli.cygnus.com>
References: <200003090940.KAA32291@reisser.regent.e-technik.tu-muenchen.de>
X-SW-Source: 2000-03/msg00258.html
Content-length: 593

Okay, I've got this merged with my changes.

> 2000-03-09  Peter Schauer  <pes@regent.e-technik.tu-muenchen.de>
> 
> 	* solib.c (SOLIB_EXTRACT_ADDRESS):  New macro to extract addresses
> 	from solib structures. Use it throughout solib.c, get rid of all
> 	CORE_ADDR casts.
> 	(struct so_list):  Change type of lmaddr to CORE_ADDR.
> 	(first_link_map_member):  Change return value type to CORE_ADDR,
> 	update callers.
> 	(solib_add_common_symbols):  Change parameter type to CORE_ADDR,
> 	update callers.
> 	(open_symbol_file_object, find_solib):  Change type of lm variable
> 	to CORE_ADDR.

Re: RFA: symfile.c: Fix for GDB crash when rereading symbols

[Michael Snyder]

Peter.Schauer wrote:
> 
> symfile.c:reread_symbols does not clear the new msymbol hash tables in the
> objfile, causing stale pointers and a GDB crash during the reread.exp
> test on Solaris.
> 
> Here is a fix:
> 
>         * symfile.c (reread_symbols):  Clear msymbol hash table.

I've checked it in.  Thanks again.

			Michael
From eliz@delorie.com Sat Apr 01 00:00:00 2000
From: Eli Zaretskii <eliz@delorie.com>
To: gdb-patches@sourceware.cygnus.com
Subject: [PATCH] Some compiler warnings removed
Date: Sat, 01 Apr 2000 00:00:00 -0000
Message-id: <200002232235.RAA18817@indy.delorie.com>
X-SW-Source: 2000-q1/msg00344.html
Content-length: 6205

Here's my share of shutting up "gcc -Wall -W".  Is "foo = foo;" an
okay solution for unused argument foo?

These diffs are against Feb 17 snapshot.  I hope they are still
relevant and apply cleanly.

2000-02-23  Eli Zaretskii  <eliz@is.elta.co.il>

	* utils.c [__GO32__]: Include pc.h, for prototypes of ScreenCols
	and ScreenRows.

	* ser-go32.c: Include string.h, for prototype of strncasecmp.
	(dpmi_regs, dpmi_sregs): Remove unused variables.
	(dos_flush_input): Return a value, to prevent compiler warning.

	* main.c (captured_command_loop): Prevent gcc from complaining
	about unused argument.

	* gdbtypes.c (count_virtual_fns): Make sure vfuncs is initialized
	to zero.

	* expprint.c (dump_prefix_expression): Use %ld in format and cast
	sizeof(union exp_element) to long, to prevent GCC from complaining
	about format/argument mismatch.
	(dump_postfix_expression): Likewise.

	* blockframe.c (nonnull_frame_chain_valid)
	(pc_in_call_dummy_before_text_end)
	(pc_in_call_dummy_after_text_end) 
	(pc_in_call_dummy_at_entry_point, generic_pc_in_call_dummy):
	Prevent gcc from complaining about unused arguments.

--- gdb/blockframe.c~0	Wed Dec 22 21:45:02 1999
+++ gdb/blockframe.c	Wed Feb 23 16:51:44 2000
@@ -70,6 +70,7 @@ nonnull_frame_chain_valid (chain, thisfr
      CORE_ADDR chain;
      struct frame_info *thisframe;
 {
+  thisframe = thisframe;
   return ((chain) != 0);
 }
 
@@ -1035,6 +1036,7 @@ pc_in_call_dummy_before_text_end (pc, sp
      CORE_ADDR sp;
      CORE_ADDR frame_address;
 {
+  sp = frame_address;
   return ((pc) >= text_end - CALL_DUMMY_LENGTH
 	  && (pc) <= text_end + DECR_PC_AFTER_BREAK);
 }
@@ -1045,6 +1047,7 @@ pc_in_call_dummy_after_text_end (pc, sp,
      CORE_ADDR sp;
      CORE_ADDR frame_address;
 {
+  sp = frame_address;
   return ((pc) >= text_end
 	  && (pc) <= text_end + CALL_DUMMY_LENGTH + DECR_PC_AFTER_BREAK);
 }
@@ -1084,6 +1087,7 @@ pc_in_call_dummy_at_entry_point (pc, sp,
      CORE_ADDR sp;
      CORE_ADDR frame_address;
 {
+  sp = frame_address;
   return ((pc) >= CALL_DUMMY_ADDRESS ()
 	  && (pc) <= (CALL_DUMMY_ADDRESS () + DECR_PC_AFTER_BREAK));
 }
@@ -1158,6 +1162,7 @@ generic_pc_in_call_dummy (pc, sp, fp)
      CORE_ADDR sp;
      CORE_ADDR fp;
 {
+  fp = fp;
   /* if find_dummy_frame succeeds, then PC is in a call dummy */
   /* Note: SP and not FP is passed on. */
   return (generic_find_dummy_frame (pc, sp) != 0);
--- gdb/expprint.c~0	Wed Feb  2 00:21:06 2000
+++ gdb/expprint.c	Wed Feb 23 17:11:22 2000
@@ -710,9 +710,9 @@ dump_prefix_expression (exp, stream, not
     print_expression (exp, stream);
   else
     fprintf_filtered (stream, "Type printing not yet supported....");
-  fprintf_filtered (stream, "'\n\tLanguage %s, %d elements, %d bytes each.\n",
+  fprintf_filtered (stream, "'\n\tLanguage %s, %d elements, %ld bytes each.\n",
 		    exp->language_defn->la_name, exp->nelts,
-		    sizeof (union exp_element));
+		    (long) sizeof (union exp_element));
   fprintf_filtered (stream, "\t%5s  %20s  %16s  %s\n", "Index", "Opcode",
 		    "Hex Value", "String Value");
   for (elt = 0; elt < exp->nelts; elt++)
@@ -986,9 +986,9 @@ dump_postfix_expression (exp, stream, no
     print_expression (exp, stream);
   else
     fputs_filtered ("Type printing not yet supported....", stream);
-  fprintf_filtered (stream, "'\n\tLanguage %s, %d elements, %d bytes each.\n",
+  fprintf_filtered (stream, "'\n\tLanguage %s, %d elements, %ld bytes each.\n",
 		    exp->language_defn->la_name, exp->nelts,
-		    sizeof (union exp_element));
+		    (long) sizeof (union exp_element));
   fputs_filtered ("\n", stream);
 
   for (elt = 0; elt < exp->nelts;)
--- gdb/gdbtypes.c~0	Tue Dec 14 01:05:30 1999
+++ gdb/gdbtypes.c	Wed Feb 23 17:13:34 2000
@@ -2041,7 +2041,7 @@ count_virtual_fns (dclass)
      struct type *dclass;
 {
   int fn, oi;			/* function and overloaded instance indices */
-  int vfuncs;			/* count to return */
+  int vfuncs = 0;		/* count to return */
 
   /* recurse on bases that can share virtual table */
   struct type *pbc = primary_base_class (dclass);
--- gdb/i386-tdep.c~0	Tue Oct 19 02:46:36 1999
+++ gdb/i386-tdep.c	Wed Feb 23 12:17:20 2000
@@ -702,9 +702,9 @@ i386_extract_return_value (type, regbuf,
      char regbuf[REGISTER_BYTES];
      char *valbuf;
 {
-  /* On AIX and i386 GNU/Linux, floating point values are returned in
-     floating point registers.  */
-#if defined(I386_AIX_TARGET) || defined(I386_GNULINUX_TARGET)
+  /* On AIX, i386 GNU/Linux and DJGPP, floating point values are
+     returned in floating point registers.  */
+#if defined(I386_AIX_TARGET) || defined(I386_GNULINUX_TARGET) || defined(I386_DJGPP_TARGET)
   if (TYPE_CODE_FLT == TYPE_CODE (type))
     {
       double d;
@@ -720,7 +720,7 @@ i386_extract_return_value (type, regbuf,
       store_floating (valbuf, TYPE_LENGTH (type), d);
     }
   else
-#endif /* I386_AIX_TARGET || I386_GNULINUX_TARGET*/
+#endif /* I386_AIX_TARGET || I386_GNULINUX_TARGET || I386_DJGPP_TARGET */
     {
 #if defined(LOW_RETURN_REGNUM)
       int len = TYPE_LENGTH (type);
--- gdb/main.c~0	Mon Feb  7 00:19:34 2000
+++ gdb/main.c	Wed Feb 23 16:48:54 2000
@@ -93,6 +93,7 @@ extern char *external_editor_command;
 static int
 captured_command_loop (void *data)
 {
+  data = data;
   if (command_loop_hook == NULL)
     command_loop ();
   else
--- gdb/ser-go32.c~0	Wed Feb  2 00:21:10 2000
+++ gdb/ser-go32.c	Wed Feb 23 17:18:50 2000
@@ -127,15 +127,12 @@
 #define	MSR_DDSR	0x02
 #define	MSR_DCTS	0x01
 
+#include <string.h>
 #include <dos.h>
 #include <go32.h>
 #include <dpmi.h>
 typedef unsigned long u_long;
 
-/* DPMI Communication */
-static union REGS dpmi_regs;
-static struct SREGS dpmi_sregs;
-
 /* 16550 rx fifo trigger point */
 #define FIFO_TRIGGER	FIFO_TRIGGER_4
 
@@ -693,6 +690,7 @@ dos_flush_input (scb)
   if (port->fifo)
     outb (port, com_fifo, FIFO_ENABLE | FIFO_RCV_RST | FIFO_TRIGGER);
   enable ();
+  return 0;
 }
 
 static void
--- gdb/utils.c~0	Wed Feb  2 00:21:10 2000
+++ gdb/utils.c	Wed Feb 23 17:45:36 2000
@@ -31,6 +31,10 @@
 #include <term.h>
 #endif
 
+#ifdef __GO32__
+#include <pc.h>
+#endif
+
 /* SunOS's curses.h has a '#define reg register' in it.  Thank you Sun. */
 #ifdef reg
 #undef reg
From ac131313@cygnus.com Sat Apr 01 00:00:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: GDB Patches <gdb-patches@sourceware.cygnus.com>
Subject: Re: [PATCH] acconfig.h tweeks - HAVE_PTRACE_GETREGS
Date: Sat, 01 Apr 2000 00:00:00 -0000
Message-id: <38DFF791.56C5036F@cygnus.com>
References: <38DF0EDF.9927F6CC@cygnus.com>
X-SW-Source: 2000-q1/msg01070.html
Content-length: 1713

Andrew Cagney wrote:

> Index: acconfig.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/acconfig.h,v
> retrieving revision 1.1.1.5
> diff -p -r1.1.1.5 acconfig.h
> *** acconfig.h  2000/01/06 03:06:35     1.1.1.5
> --- acconfig.h  2000/03/27 07:24:20
> ***************
> *** 84,87 ****
> --- 84,90 ----
>   #undef HAVE_STRUCT_MEMBER_SS_WIDE
> 
>   /* Define if <sys/ptrace.h> defines the PTRACE_GETXFPREGS request.  */
> + #undef HAVE_PTRACE_GETREGS
> +
> + /* Define if <sys/ptrace.h> defines the PTRACE_GETXFPREGS request.  */
>   #undef HAVE_PTRACE_GETXFPREGS

The attatched fixes an obvious typo.  (Thanks Fernando.)

	Andrew
Tue Mar 28 09:59:00 2000  Andrew Cagney  <cagney@b1.cygnus.com>

	* acconfig.h: Fix typo in comment describing HAVE_PTRACE_GETREGS.
	* config.h: Regenerate.
	
Index: acconfig.h
===================================================================
RCS file: /cvs/src/src/gdb/acconfig.h,v
retrieving revision 1.2
diff -p -r1.2 acconfig.h
*** acconfig.h	2000/03/27 07:31:37	1.2
--- acconfig.h	2000/03/28 00:02:15
***************
*** 83,89 ****
  /* Set to true if the save_state_t structure has the ss_wide member */
  #undef HAVE_STRUCT_MEMBER_SS_WIDE
  
! /* Define if <sys/ptrace.h> defines the PTRACE_GETXFPREGS request.  */
  #undef HAVE_PTRACE_GETREGS
  
  /* Define if <sys/ptrace.h> defines the PTRACE_GETXFPREGS request.  */
--- 83,89 ----
  /* Set to true if the save_state_t structure has the ss_wide member */
  #undef HAVE_STRUCT_MEMBER_SS_WIDE
  
! /* Define if <sys/ptrace.h> defines the PTRACE_GETREGS request.  */
  #undef HAVE_PTRACE_GETREGS
  
  /* Define if <sys/ptrace.h> defines the PTRACE_GETXFPREGS request.  */
From cgf@cygnus.com Sat Apr 01 00:00:00 2000
From: Chris Faylor <cgf@cygnus.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: GDB Patches <gdb-patches@sourceware.cygnus.com>
Subject: Re: [PATCH] Include "gdb_wait.h"
Date: Sat, 01 Apr 2000 00:00:00 -0000
Message-id: <20000228010642.A14479@cygnus.com>
References: <38BA0111.C69DA62A@cygnus.com>
X-SW-Source: 2000-q1/msg00394.html
Content-length: 1133

Actually, it seems that the line should be completely eliminated.  It
has no meaning to Windows CE.

Also, shouldn't that be "gdb-wait.h"?  I thought there was a "no underscore
in filenames" rule in gdb.

cgf

On Mon, Feb 28, 2000 at 04:01:05PM +1100, Andrew Cagney wrote:
>Chris,
>
>Noticed this one.  It's been applied.
>
>	Andrew
>Mon Feb 28 13:34:54 2000  Andrew Cagney  <cagney@b1.cygnus.com>
>
>	* wince.c: Include "gdb_wait.h" and not "wait.h".
>
>Index: wince.c
>===================================================================
>RCS file: /cvs/src/src/gdb/wince.c,v
>retrieving revision 1.1
>diff -p -r1.1 wince.c
>*** wince.c	2000/02/24 21:39:15	1.1
>--- wince.c	2000/02/28 04:58:23
>***************
>*** 33,39 ****
>  #include "frame.h"		/* required by inferior.h */
>  #include "inferior.h"
>  #include "target.h"
>! #include "wait.h"
>  #include "gdbcore.h"
>  #include "command.h"
>  #include <signal.h>
>--- 33,39 ----
>  #include "frame.h"		/* required by inferior.h */
>  #include "inferior.h"
>  #include "target.h"
>! #include "gdb_wait.h"
>  #include "gdbcore.h"
>  #include "command.h"
>  #include <signal.h>

Re: RFA: symfile.c: Fix for GDB crash when rereading symbols

[Michael Snyder]

Peter.Schauer wrote:
> 
> symfile.c:reread_symbols does not clear the new msymbol hash tables
> in the objfile, causing stale pointers and a GDB crash during the
> reread.exp test on Solaris.
> 
> Here is a fix:

Great!  I was just noticing that failure last night.
Thanks!
From ac131313@cygnus.com Sat Apr 01 00:00:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: jtc@redback.com
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: RFA: i386/tm-nsbd.h, i386/nm-nbsd.h
Date: Sat, 01 Apr 2000 00:00:00 -0000
Message-id: <38D7F5FC.8D45CBAF@cygnus.com>
References: <5m66uggiur.fsf@jtc.redbacknetworks.com>
X-SW-Source: 2000-q1/msg00877.html
Content-length: 375

"J.T. Conklin" wrote:
> 
> I submit the enclosed patch for approval.  These changes enable
> floating point register support on NetBSD/i386.
> 
>         --jtc
> 
> 2000-03-21  J.T. Conklin  <jtc@redback.com>
> 
>         * i386/tm-nbsd.h (NUM_REGS): Removed.
>         (HAVE_I387_REGS): Defined.
>         * i386/nm-nbsd.h (FLOAT_INFO): Removed.

Approved (thanks).
	Andrew
From rearnsha@arm.com Sat Apr 01 00:00:00 2000
From: Richard Earnshaw <rearnsha@arm.com>
To: Fernando Nasser <fnasser@cygnus.com>
Cc: rearnsha@arm.com
Subject: Re: ARM patch -- extra info about cpsr register 
Date: Sat, 01 Apr 2000 00:00:00 -0000
Message-id: <200003281047.LAA02722@cam-mail2.cambridge.arm.com>
References: <38DFB300.B82108A@cygnus.com>
X-SW-Source: 2000-q1/msg01082.html
Content-length: 1041

> Hi Richard,
> 
> Thanks for the submission.  However, we are using something else to show register bits nowadays.  It uses the
> REGISTER_VIRTUAL_TYPE and we build a type for the register with bitfields so normal gdb processing (and the GUI) can
> show the bits and allow the user to set a specific bit by name (without having to know its position by heart).
> 
> I am sorting out some details and tracking down a bug in gdb before making it available.  My code is for another
> processor but it will be very easy to adapt it for ARM.  If you fell like helping, as soon as I have a final version I
> can point you to the right pieces of code.
> 
> Hope you are not too disappointed.

Not at all.  It's not the implementation that's important; it's that the 
information be decoded for the user.  Mapping a hex number to a set of 
mnemonics is something a computer is good and and a human is not.   If 
your version allows the user to set the register mnemonically as well, 
then all the better.

Please keep me posted on your patch.

R.