Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Blanc, Nicolas" <nicolas.blanc@intel.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	"dje@google.com" <dje@google.com>
Subject: RE: [PATCH v12 5/5] Test adding and removing a symbol file at runtime.
Date: Thu, 18 Jul 2013 12:52:00 -0000	[thread overview]
Message-ID: <388084C8C1E6A64FA36AD1D656E485661A7B11F5@IRSMSX106.ger.corp.intel.com> (raw)
In-Reply-To: <201307171852.r6HIquNI026465@glazunov.sibelius.xs4all.nl>

>> +#include <elf.h>
>
>The <elf.h> header isn't standardized at all.  So this testcase probably only compile on systems that use glibc as their C library.
>Might not even work on a significant fraction of systems that use a Linux kernel.
>
>Perhaps it is possible to use the headers from include/elf in the src tree instead?

Thanks Mark of looking into this patch. I can change the include, no big deal, but  <elf.h> looks
more portable to me than </usr/include/elf.h> for the following reasons:

* The man pages for Linux and FreeBSD both mention <elf.h> but not </usr/include/elf.h>:
	 http://man7.org/linux/man-pages/man5/elf.5.html 
	http://www.freebsd.org/cgi/man.cgi?query=elf&sektion=5&apropos=0&manpath=FreeBSD+9.1-RELEASE

  I could compile the test on following distros: Fedora 15, Red Hat 6.2, Ubuntu 12.4, and SUSE 11.1.  And <elf.h> is even available on Cygwin.

* My understanding is that <elf.h> provides at least the definitions that are relevant for the target system, which is what matter here, and does not
  hardcode any path.

* The following GDB tests include <elf.h>:
	./gdb.arch/ppc-dfp.c:#include <elf.h>
	./gdb.base/jit-main.c:#include <elf.h>

   There is not test including any other elf header.

Can you comment on this?

Thank you,

Nicolas





Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052


  reply	other threads:[~2013-07-18 12:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 16:28 [PATCH v12 0/5] remove-symbol-file & add-symbol-file Nicolas Blanc
2013-07-17 16:27 ` [PATCH v12 4/5] Function is_elf_target Nicolas Blanc
2013-07-17 18:43   ` Mark Kettenis
2013-07-17 19:47     ` Doug Evans
2013-07-17 16:27 ` [PATCH v12 1/5] New remove-symbol-file command Nicolas Blanc
2013-07-17 16:27 ` [PATCH v12 2/5] Documentation for the " Nicolas Blanc
2013-07-17 17:02   ` Eli Zaretskii
2013-07-17 16:28 ` [PATCH v12 3/5] 'add-symbol-file' should update the current target sections Nicolas Blanc
2013-07-26 19:10   ` Luis Machado
2013-07-17 16:28 ` [PATCH v12 5/5] Test adding and removing a symbol file at runtime Nicolas Blanc
2013-07-17 18:53   ` Mark Kettenis
2013-07-18 12:52     ` Blanc, Nicolas [this message]
2013-07-18 13:28       ` Mark Kettenis
2013-07-18 16:05         ` Blanc, Nicolas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=388084C8C1E6A64FA36AD1D656E485661A7B11F5@IRSMSX106.ger.corp.intel.com \
    --to=nicolas.blanc@intel.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox