From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5969 invoked by alias); 18 Jul 2013 12:52:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5954 invoked by uid 89); 18 Jul 2013 12:52:26 -0000 X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_50,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mga03.intel.com) (143.182.124.21) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 18 Jul 2013 12:52:25 +0000 Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga101.ch.intel.com with ESMTP; 18 Jul 2013 05:52:15 -0700 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by AZSMGA002.ch.intel.com with ESMTP; 18 Jul 2013 05:51:52 -0700 Received: from irsmsx105.ger.corp.intel.com (163.33.3.28) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 18 Jul 2013 13:51:48 +0100 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.91]) by IRSMSX105.ger.corp.intel.com ([169.254.7.52]) with mapi id 14.03.0123.003; Thu, 18 Jul 2013 13:51:48 +0100 From: "Blanc, Nicolas" To: Mark Kettenis CC: "gdb-patches@sourceware.org" , "dje@google.com" Subject: RE: [PATCH v12 5/5] Test adding and removing a symbol file at runtime. Date: Thu, 18 Jul 2013 12:52:00 -0000 Message-ID: <388084C8C1E6A64FA36AD1D656E485661A7B11F5@IRSMSX106.ger.corp.intel.com> References: <1374078455-906-1-git-send-email-nicolas.blanc@intel.com> <1374078455-906-6-git-send-email-nicolas.blanc@intel.com> <201307171852.r6HIquNI026465@glazunov.sibelius.xs4all.nl> In-Reply-To: <201307171852.r6HIquNI026465@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-07/txt/msg00445.txt.bz2 >> +#include > >The header isn't standardized at all. So this testcase probably o= nly compile on systems that use glibc as their C library. >Might not even work on a significant fraction of systems that use a Linux = kernel. > >Perhaps it is possible to use the headers from include/elf in the src tree= instead? Thanks Mark of looking into this patch. I can change the include, no big de= al, but looks more portable to me than for the following reasons: * The man pages for Linux and FreeBSD both mention but not : http://man7.org/linux/man-pages/man5/elf.5.html=20 http://www.freebsd.org/cgi/man.cgi?query=3Delf&sektion=3D5&apropos=3D0&man= path=3DFreeBSD+9.1-RELEASE I could compile the test on following distros: Fedora 15, Red Hat 6.2, Ub= untu 12.4, and SUSE 11.1. And is even available on Cygwin. * My understanding is that provides at least the definitions that a= re relevant for the target system, which is what matter here, and does not hardcode any path. * The following GDB tests include : ./gdb.arch/ppc-dfp.c:#include ./gdb.base/jit-main.c:#include There is not test including any other elf header. Can you comment on this? Thank you, Nicolas Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052