From: Pedro Alves <palves@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Add rdrand/rdseed record/replay tests
Date: Wed, 01 Feb 2017 11:09:00 -0000 [thread overview]
Message-ID: <38210a5e-14b5-23f6-456c-1ec1b900caf5@redhat.com> (raw)
In-Reply-To: <1485451129-16439-1-git-send-email-lgustavo@codesourcery.com>
On 01/26/2017 05:18 PM, Luis Machado wrote:
> +/* Fetches information from cpuid and sets flags indicating supported
> + features. */
What flags?
> +
> +static unsigned int
> +check_cpu_support (void)
> +{
> + unsigned int rdrand_mask = (1 << 30);
> + unsigned int eax, ebx, ecx, edx;
> +
> + __get_cpuid(1, &eax, &ebx, &ecx, &edx);
Space before parens.
> + return ((ecx & rdrand_mask) == rdrand_mask);
> +}
> +
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-02-01 11:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 17:19 Luis Machado
2017-01-26 17:19 ` [PATCH 2/2] [BZ 21005] Add support for Intel 64 rdrand and rdseed record/replay Luis Machado
2017-01-26 19:36 ` Eli Zaretskii
2017-02-01 11:11 ` Pedro Alves
2017-01-26 17:23 ` [PATCH 1/2] Add rdrand/rdseed record/replay tests Luis Machado
2017-02-01 11:11 ` Pedro Alves
2017-02-01 11:09 ` Pedro Alves [this message]
[not found] ` <d5eb13e9-07a7-f266-965b-8eeb4aa3f339@codesourcery.com>
2017-02-01 12:55 ` Luis Machado
2017-02-01 15:38 ` Pedro Alves
2017-02-06 9:16 ` Luis Machado
2017-02-23 16:23 ` Yao Qi
2017-02-23 17:20 ` Luis Machado
2017-02-23 17:26 ` Luis Machado
2017-02-23 21:42 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38210a5e-14b5-23f6-456c-1ec1b900caf5@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox