From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-136637-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22806 invoked by alias); 1 Feb 2017 11:09:12 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 22790 invoked by uid 89); 1 Feb 2017 11:09:11 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Feb 2017 11:09:10 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 8726E5146E;	Wed,  1 Feb 2017 11:09:10 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v11B998d019944;	Wed, 1 Feb 2017 06:09:09 -0500
Subject: Re: [PATCH 1/2] Add rdrand/rdseed record/replay tests
To: Luis Machado <lgustavo@codesourcery.com>, gdb-patches@sourceware.org
References: <1485451129-16439-1-git-send-email-lgustavo@codesourcery.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <38210a5e-14b5-23f6-456c-1ec1b900caf5@redhat.com>
Date: Wed, 01 Feb 2017 11:09:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1485451129-16439-1-git-send-email-lgustavo@codesourcery.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-02/txt/msg00014.txt.bz2

On 01/26/2017 05:18 PM, Luis Machado wrote:

> +/* Fetches information from cpuid and sets flags indicating supported
> +   features.  */

What flags?

> +
> +static unsigned int
> +check_cpu_support (void)
> +{
> +  unsigned int rdrand_mask = (1 << 30);
> +  unsigned int eax, ebx, ecx, edx;
> +
> +  __get_cpuid(1, &eax, &ebx, &ecx, &edx);

Space before parens.

> +  return ((ecx & rdrand_mask) == rdrand_mask);
> +}
> +

Thanks,
Pedro Alves