Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jonas Maebe <jonas@freepascal.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Pierre Muller" <muller@ics.u-strasbg.fr>, 	gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix PR pascal/2283
Date: Wed, 26 Sep 2007 14:02:00 -0000	[thread overview]
Message-ID: <36AA51D7-8F6A-41D6-82F2-5E837D169AB9@freepascal.org> (raw)
In-Reply-To: <uzlz95yg7.fsf@gnu.org>


On 26 Sep 2007, at 15:49, Eli Zaretskii wrote:

>> From: "Pierre Muller" <muller@ics.u-strasbg.fr>
>> Cc: "'Jonas Maebe'" <jonas@freepascal.org>
>> Date: Wed, 26 Sep 2007 14:25:38 +0200
>>
>> -              || ((current_language->la_language == language_m2)
>> +              || ((current_language->la_language == language_pascal)
>
> Why is it TRT to remove Modula-2 here?

Because the that code resides in pascal_val_print() in p-valprint.c,  
and not in m2_val_print() in m2-valprint.c (the former was based on  
the latter, and the leftover language_m2 was simply a copy/paste  
error afaics).

In fact, I have no idea why that code (in both the Pascal and  
Modula-2 cases) even checks the current language, as those routines  
are obviously language-specific. Maybe the Modula-2 code originally  
came from a generic routine, and the check was never removed (and  
then copied over to the Pascal version when that one was written)?


Jonas


  reply	other threads:[~2007-09-26 14:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-26 12:25 Pierre Muller
2007-09-26 13:49 ` Eli Zaretskii
2007-09-26 14:02   ` Jonas Maebe [this message]
2007-09-26 14:08     ` Eli Zaretskii
2007-09-26 14:12       ` Jonas Maebe
2007-09-26 14:26       ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36AA51D7-8F6A-41D6-82F2-5E837D169AB9@freepascal.org \
    --to=jonas@freepascal.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=muller@ics.u-strasbg.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox