From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28551 invoked by alias); 26 Sep 2007 14:02:00 -0000 Received: (qmail 28530 invoked by uid 22791); 26 Sep 2007 14:01:58 -0000 X-Spam-Check-By: sourceware.org Received: from cedar.ugent.be (HELO cedar.ugent.be) (157.193.49.14) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 26 Sep 2007 14:01:51 +0000 Received: from gorilla.ugent.be (HELO localhost) ([157.193.49.20]) by cedar.ugent.be with ESMTP; 26 Sep 2007 16:01:48 +0200 Received: from cedar.ugent.be ([157.193.49.14]) by localhost (gorilla.UGent.be [157.193.43.11]) (amavisd-new, port 10024) with ESMTP id 06188-01-8; Wed, 26 Sep 2007 16:01:48 +0200 (CEST) Received: from mail.elis.ugent.be ([157.193.206.48]) by cedar.ugent.be with ESMTP; 26 Sep 2007 16:01:48 +0200 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao8CAJ4B+kadwc4w/2dsb2JhbAA Received: from localhost (localhost [127.0.0.1]) by mail.elis.UGent.be (Postfix) with ESMTP id EBD012BAD66; Wed, 26 Sep 2007 16:01:46 +0200 (CEST) Received: from [157.193.206.33] (bigmac.elis.UGent.be [157.193.206.33]) by mail.elis.UGent.be (Postfix) with ESMTP id E4EA82BAD61; Wed, 26 Sep 2007 16:01:46 +0200 (CEST) In-Reply-To: References: <002f01c80038$5881a880$0984f980$@u-strasbg.fr> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <36AA51D7-8F6A-41D6-82F2-5E837D169AB9@freepascal.org> Cc: "Pierre Muller" , gdb-patches@sourceware.org Content-Transfer-Encoding: 7bit From: Jonas Maebe Subject: Re: [PATCH] Fix PR pascal/2283 Date: Wed, 26 Sep 2007 14:02:00 -0000 To: Eli Zaretskii X-Mailer: Apple Mail (2.752.2) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00364.txt.bz2 On 26 Sep 2007, at 15:49, Eli Zaretskii wrote: >> From: "Pierre Muller" >> Cc: "'Jonas Maebe'" >> Date: Wed, 26 Sep 2007 14:25:38 +0200 >> >> - || ((current_language->la_language == language_m2) >> + || ((current_language->la_language == language_pascal) > > Why is it TRT to remove Modula-2 here? Because the that code resides in pascal_val_print() in p-valprint.c, and not in m2_val_print() in m2-valprint.c (the former was based on the latter, and the leftover language_m2 was simply a copy/paste error afaics). In fact, I have no idea why that code (in both the Pascal and Modula-2 cases) even checks the current language, as those routines are obviously language-specific. Maybe the Modula-2 code originally came from a generic routine, and the check was never removed (and then copied over to the Pascal version when that one was written)? Jonas