From: Torbjorn SVENSSON <torbjorn.svensson@foss.st.com>
To: Alan Modra <amodra@gmail.com>
Cc: <binutils@sourceware.org>, <gdb-patches@sourceware.org>,
<simark@simark.ca>
Subject: Re: [PATCH v3] configure: Sync zstd detection with GCC
Date: Wed, 21 Oct 2026 10:13:16 +0200 [thread overview]
Message-ID: <35af970f-1e62-43a5-82b9-3b53ff9a5d3c@foss.st.com> (raw)
In-Reply-To: <athiAf0jf10WDd3k@squeak.grove.modra.org>
On 2026-10-21 08:56, Alan Modra wrote:
> On Tue, Oct 20, 2026 at 07:40:58PM +0200, Torbjörn SVENSSON wrote:
>> Sync config/zstd.m4 with GCC to support compiler-based detection and
>> configurable zstd search paths.
>>
>> Add ZSTD_LIBS to binutils link commands for tools using zstd through
>> BFD. Base gold's zstd test conditional on the final detection result
>> rather than pkg-config flags.
>>
>> Regenerate the affected configure scripts and binutils Makefile.in.
>
> The regen missed some files, and didn't apply cleanly. I've taken the
> substance of your patch, ie. binutils/Makefile.am, config/zstd.m4 and
> gold/configure.ac changes, and regenerated the rest.
Thank you Alan for fixing. For next time, what command did you run to
generate all the resources that were missed?
Kind regards,
Torbjörn
>
> binutils/Makefile.in testsuite_gentestdlls_DEPENDENCIES looks odd but
> harmless. I don't intend to go down that rabbit hole trying to
> figure out why.
>
next prev parent reply other threads:[~2026-10-21 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 5:30 [PATCH v2] configure: Support --with-zstd=PATH Torbjörn SVENSSON
2026-09-29 2:00 ` Simon Marchi
2026-10-20 17:40 ` [PATCH v3] configure: Sync zstd detection with GCC Torbjörn SVENSSON
2026-10-21 6:56 ` Alan Modra
2026-10-21 8:13 ` Torbjorn SVENSSON [this message]
2026-10-21 11:23 ` Alan Modra
2026-10-21 11:24 ` Torbjorn SVENSSON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35af970f-1e62-43a5-82b9-3b53ff9a5d3c@foss.st.com \
--to=torbjorn.svensson@foss.st.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox