Re: [PATCH v5 00/14] Fix BZ 25631 - core file memory access problem

[Pedro Alves <pedro@palves.net>]

On 7/22/20 1:58 AM, Kevin Buettner via Gdb-patches wrote:
> This series fixes several core file related bugs.  The bug which
> started this work can be viewed here:
> 
>     https://sourceware.org/bugzilla/show_bug.cgi?id=25631
> 
> Other problems were found either during review or during development. 
> I discuss these in my commit log remarks.
> 
> This v5 series has only minor changes from v4.  Unless noted
> otherwise, these changes all address Pedro's concerns:
> 
> o Patch #5, Test ability to access unwritten-to mmap data in core file:
> 
>   - Add setup_xfail for non-Linux OSes.  (I spotted this while testing
>     on FreeBSD.)
> 
> o Patch #8, Use NT_FILE note section for reading core target memory:
> 
>   - Formatting fixes.
>   - Close bfd after failed bfd_check_format_check.
>   - Fix SECNAME leak.
> 
> o Patch #11, Adjust coredump-filter.exp to account for NT_FILE note handling:
> 
>   - Instead of XFAILing test, use Mihails Strasuns's suggestion
>     instead.
> 
> o Patch #12, Add new command "maint print core-file-backed-mappings":
> 
>   - Formatting fixes.
>   - Don't crash GDB with gdb_assert().
>   - Add comments (in both code and commit log) regarding utility
>     of this new command.
> 
> o Patch #14, New core file tests with mappings over existing program memory:
> 
>   - Formatting fixes.
>   - Add another "maint print core-file-backed-mappings" test requested
>     by Pedro in patch #12 review.  This one makes sure that we don't
>     crash GDB when NOT debugging a core file.
> 
> I believe that all patches not listed above have been approved. 
> Actually, I think that #5 is still approved too; I doubt that adding
> an XFAIL changes that.

I sent a minor comment to patch #11.  Everything else looks great to me.

Thanks for doing all this.  Great job.

Pedro Alves