From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by sourceware.org (Postfix) with ESMTPS id 4A5553857032 for ; Wed, 22 Jul 2020 18:59:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4A5553857032 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f68.google.com with SMTP id f2so2904478wrp.7 for ; Wed, 22 Jul 2020 11:59:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WN+SA75Chg8AAs6UOQpz5PD9FjnU8hEC8UHEU88sS74=; b=C6f5MDebXxZRBOtDG48E7BbRIZ2sGWQjBbvdMqf40x8CFc/RXjZZo6+DxBqojqRYm0 0TMLrtdgmW8OACQSNzeOebXncKP0uJM+cMTPZ6JwJR5Nm3H6A7zol2Uh83Fvcugfknav I+YwFgTVTmlgtrHATRMGqrHoH1ShpIqP8B+cWfYyJxYAh6XBZY4ca+e4af1nwUKnjtnE xy+Gl/jwQbvSaDZLU5yMTZEvLhvqAA3PhX80u//KdV5xRRyDKtAVrtC7SMrLaXJjXzg9 xxEOHmnl25ddTIdzvDvMw1/KZywHmQhNSyua5kd2kusPBzwW2lpXUoNfSuAvswQ8EYUD bGYA== X-Gm-Message-State: AOAM531Qcsoimx9/yLTe7j216XNPWHsxrAqzdLp/b9uhrB449U2g5fpt CF8yFXEJevyUmfyqbS7l46gKeRfP4Ns= X-Google-Smtp-Source: ABdhPJyV6s3+pYkldGHxfpGlN/qWH8V2FB1tUEQtw5JeUKDwe2KXCYGj1aU/5K2kv5tHiQZvjEY5ZQ== X-Received: by 2002:a5d:48c8:: with SMTP id p8mr840660wrs.84.1595444343282; Wed, 22 Jul 2020 11:59:03 -0700 (PDT) Received: from ?IPv6:2001:8a0:f91a:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f91a:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id u16sm636511wmn.11.2020.07.22.11.59.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2020 11:59:02 -0700 (PDT) Subject: Re: [PATCH v5 00/14] Fix BZ 25631 - core file memory access problem To: Kevin Buettner , gdb-patches@sourceware.org References: <20200722005832.863276-1-kevinb@redhat.com> From: Pedro Alves Message-ID: <35982031-7050-c45b-8940-0b770c4d9803@palves.net> Date: Wed, 22 Jul 2020 19:58:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200722005832.863276-1-kevinb@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 18:59:06 -0000 On 7/22/20 1:58 AM, Kevin Buettner via Gdb-patches wrote: > This series fixes several core file related bugs. The bug which > started this work can be viewed here: > > https://sourceware.org/bugzilla/show_bug.cgi?id=25631 > > Other problems were found either during review or during development. > I discuss these in my commit log remarks. > > This v5 series has only minor changes from v4. Unless noted > otherwise, these changes all address Pedro's concerns: > > o Patch #5, Test ability to access unwritten-to mmap data in core file: > > - Add setup_xfail for non-Linux OSes. (I spotted this while testing > on FreeBSD.) > > o Patch #8, Use NT_FILE note section for reading core target memory: > > - Formatting fixes. > - Close bfd after failed bfd_check_format_check. > - Fix SECNAME leak. > > o Patch #11, Adjust coredump-filter.exp to account for NT_FILE note handling: > > - Instead of XFAILing test, use Mihails Strasuns's suggestion > instead. > > o Patch #12, Add new command "maint print core-file-backed-mappings": > > - Formatting fixes. > - Don't crash GDB with gdb_assert(). > - Add comments (in both code and commit log) regarding utility > of this new command. > > o Patch #14, New core file tests with mappings over existing program memory: > > - Formatting fixes. > - Add another "maint print core-file-backed-mappings" test requested > by Pedro in patch #12 review. This one makes sure that we don't > crash GDB when NOT debugging a core file. > > I believe that all patches not listed above have been approved. > Actually, I think that #5 is still approved too; I doubt that adding > an XFAIL changes that. I sent a minor comment to patch #11. Everything else looks great to me. Thanks for doing all this. Great job. Pedro Alves