From: "Eli Zaretskii" <eliz@is.elta.co.il>
To: tromey@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: Patch: completion -vs- duplicates
Date: Sat, 05 Jan 2002 00:25:00 -0000 [thread overview]
Message-ID: <3596-Sat05Jan2002102225+0200-eliz@is.elta.co.il> (raw)
In-Reply-To: <877kqx7j8o.fsf@creche.redhat.com> (message from Tom Tromey on 04 Jan 2002 17:07:51 -0700)
> From: Tom Tromey <tromey@redhat.com>
> Date: 04 Jan 2002 17:07:51 -0700
>
> Right now the `complete' command can print duplicates. readline seems
> to filter these, so you don't see this using Tab in the CLI, but you
> can see it in Insight or by using the complete command.
Hm... shouldn't Insight do the same as readline?
In my mind, GDB doesn't do any completion at all. Completion is a
feature of the UI; GDB just helps the UI by providing a function to
call to get all the completion candidates. The rest--how to display
the candidates, whether to filter out duplicates, etc.--is up to the
UI's completion machinery. So conceptually, in my mind, the
filtering doesn't belong in GDB.
Concepts aside, the change you suggest has also practical
disadvantages: filtering duplicates in GDB's completion function would
mean a performance hit in the CLI version, since readline will try to
filter again.
next prev parent reply other threads:[~2002-01-05 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-04 15:55 Tom Tromey
2002-01-05 0:25 ` Eli Zaretskii [this message]
2002-01-05 7:44 ` Daniel Berlin
2002-01-05 10:20 ` Tom Tromey
2002-01-05 10:34 ` Andrew Cagney
2002-01-05 12:37 ` Tom Tromey
2002-01-05 10:30 ` Daniel Jacobowitz
2002-01-05 10:37 ` Daniel Berlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3596-Sat05Jan2002102225+0200-eliz@is.elta.co.il \
--to=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox