From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2861 invoked by alias); 5 Jan 2002 08:25:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2834 invoked from network); 5 Jan 2002 08:25:29 -0000 Received: from unknown (HELO balder.inter.net.il) (192.114.186.15) by sources.redhat.com with SMTP; 5 Jan 2002 08:25:29 -0000 Received: from zaretsky ([192.116.55.139]) by balder.inter.net.il (Mirapoint) with ESMTP id BDC52642; Sat, 5 Jan 2002 10:25:19 +0200 (IST) Date: Sat, 05 Jan 2002 00:25:00 -0000 From: "Eli Zaretskii" To: tromey@redhat.com Message-Id: <3596-Sat05Jan2002102225+0200-eliz@is.elta.co.il> X-Mailer: emacs 21.1.50 (via feedmail 8 I) and Blat ver 1.8.9 CC: gdb-patches@sources.redhat.com In-reply-to: <877kqx7j8o.fsf@creche.redhat.com> (message from Tom Tromey on 04 Jan 2002 17:07:51 -0700) Subject: Re: Patch: completion -vs- duplicates Reply-to: Eli Zaretskii References: <877kqx7j8o.fsf@creche.redhat.com> X-SW-Source: 2002-01/txt/msg00067.txt.bz2 > From: Tom Tromey > Date: 04 Jan 2002 17:07:51 -0700 > > Right now the `complete' command can print duplicates. readline seems > to filter these, so you don't see this using Tab in the CLI, but you > can see it in Insight or by using the complete command. Hm... shouldn't Insight do the same as readline? In my mind, GDB doesn't do any completion at all. Completion is a feature of the UI; GDB just helps the UI by providing a function to call to get all the completion candidates. The rest--how to display the candidates, whether to filter out duplicates, etc.--is up to the UI's completion machinery. So conceptually, in my mind, the filtering doesn't belong in GDB. Concepts aside, the change you suggest has also practical disadvantages: filtering duplicates in GDB's completion function would mean a performance hit in the CLI version, since readline will try to filter again.