Re: [PATCH v2 2/2] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver

[James Clarke <jrtc27@jrtc27.com>]

On 19 Jan 2018, at 18:39, Pedro Alves <palves@redhat.com> wrote:
> On 01/19/2018 05:22 PM, James Clarke wrote:
>> gdb/ChangeLog:
>> 	* gdbserver/linux-low.c (handle_extended_wait): Surround call to
>> 	thread_db_notice_clone with #ifdef USE_THREAD_DB, otherwise
>> 	linking fails with "undefined reference to
>> 	`thread_db_notice_clone(thread_info*, ptid_t)'" on architectures
>> 	without thread_db.
> 
> Note, we put the "why" info on the git commit log, not in the ChangeLog.

Ah, I think in the past I've ended up following that by chance, but it's useful
to know that as a rule.

> Also, gdb/ChangeLog -> gdb/gdbserver/ChangeLog.

Right, I should have noticed the extra ChangeLog file.

> I've amended those nits and pushed both patches in.

Thanks!

> AFAICT, you have a copyright assignment on file for other projects,
> but not for GDB.  The patches are small enough for that to not be
> an issue, but if you're planning on contributing more, it'll be
> good to take care of that.

Yeah, sure, I hope that I don't need to make any future fixes but who knows.

Thanks,
James