From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7759 invoked by alias); 19 Jan 2018 22:35:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7608 invoked by uid 89); 19 Jan 2018 22:35:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Google-Smtp-Source:sk:AH8x226, HX-Received:10.223.146.164 X-HELO: mail-wr0-f182.google.com Received: from mail-wr0-f182.google.com (HELO mail-wr0-f182.google.com) (209.85.128.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Jan 2018 22:35:45 +0000 Received: by mail-wr0-f182.google.com with SMTP id x1so2872858wrb.5 for ; Fri, 19 Jan 2018 14:35:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=5SqRBwbX2NLVi6TBaYS5c0Y5cDNwmXysP/DD/C/tTPM=; b=qXqi2DIemycqBlutaFwe4qkbSGimyW+jn/WYDIqPmDogTda6brvxqH//VNRgkZ+x8N bWxZG2vgoAJsAw/DUzBfbqu8KEQBG7w0THRJC7yrbxX6j65yHAV4LBsWbSm+Re2Zn4lq pWwiCVRso8f8KD8ujsspQPQUfxXQLsofE+i/NyUqXqDM+doNDdH8LdE+Fow0W5H6Lx++ 625k+xXC58upofWcr7lgmoGUzHBsrdZM7kZyvlbsie4KihoXCACrliucHIz3+au28u8/ bJG9HAz/D8aUin7rKcaAj6IqJz1Kv+OnRrfBXvmCBjrkMm0BpMYyuLb7jZd9wro2Hk7e Ge0Q== X-Gm-Message-State: AKwxytdBX3HlMvFYiWW3ROVCxD6+aioEYEFP7RRurlwDYCXMdtD2sbev bEtVZkCrV/hbz2+PKC420Untvr3RXx0= X-Google-Smtp-Source: AH8x226odMXdjdJmgv75/kbK38k5fUu6ov0/RzQ3+QSVMiUomD2XAoPYPlSpcoEQUIjP0ZLXISwpUQ== X-Received: by 10.223.146.164 with SMTP id 33mr1883wrn.27.1516401343809; Fri, 19 Jan 2018 14:35:43 -0800 (PST) Received: from eduroam-jrtc4-35d43e-2.trin.private.cam.ac.uk (global-184-7.nat-1.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id t24sm11076163wra.5.2018.01.19.14.35.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jan 2018 14:35:42 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: [PATCH v2 2/2] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver From: James Clarke In-Reply-To: <63cbe53a-de3d-4413-b79b-ef6b34a951aa@redhat.com> Date: Fri, 19 Jan 2018 22:35:00 -0000 Cc: gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <351ACE0F-4C78-425C-B5C2-1025596942C1@jrtc27.com> References: <20180119172250.91520-1-jrtc27@jrtc27.com> <20180119172250.91520-2-jrtc27@jrtc27.com> <63cbe53a-de3d-4413-b79b-ef6b34a951aa@redhat.com> To: Pedro Alves X-SW-Source: 2018-01/txt/msg00419.txt.bz2 On 19 Jan 2018, at 18:39, Pedro Alves wrote: > On 01/19/2018 05:22 PM, James Clarke wrote: >> gdb/ChangeLog: >> * gdbserver/linux-low.c (handle_extended_wait): Surround call to >> thread_db_notice_clone with #ifdef USE_THREAD_DB, otherwise >> linking fails with "undefined reference to >> `thread_db_notice_clone(thread_info*, ptid_t)'" on architectures >> without thread_db. >=20 > Note, we put the "why" info on the git commit log, not in the ChangeLog. Ah, I think in the past I've ended up following that by chance, but it's us= eful to know that as a rule. > Also, gdb/ChangeLog -> gdb/gdbserver/ChangeLog. Right, I should have noticed the extra ChangeLog file. > I've amended those nits and pushed both patches in. Thanks! > AFAICT, you have a copyright assignment on file for other projects, > but not for GDB. The patches are small enough for that to not be > an issue, but if you're planning on contributing more, it'll be > good to take care of that. Yeah, sure, I hope that I don't need to make any future fixes but who knows. Thanks, James