Re: [PATCH] gdb, amdgpu: report SIGSEGV instead of SIGTRAP

[Simon Marchi <simon.marchi@efficios.com>]

On 9/29/26 10:31 AM, Tankut Baris Aktemur wrote:
> diff --git a/gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.exp b/gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.exp
> index 460d14a2b30..755fc0a7a56 100644
> --- a/gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.exp
> +++ b/gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.exp
> @@ -29,8 +29,7 @@ if {[build_executable "failed to prepare" $testfile $srcfile {debug hip}]} {
>  }
>  
>  proc do_test { } {
> -    clean_restart
> -    gdb_load $::binfile
> +    clean_restart $::testfile
>  
>      with_rocm_gpu_lock {
>  	if {![runto_main]} {
> @@ -41,6 +40,26 @@ proc do_test { } {
>  	gdb_test "continue" \
>  	    "SIGSEGV, Segmentation fault.*Warning: precise memory violation signal reporting is not enabled.*"
>      }
> +
> +    clean_restart $::testfile
> +
> +    with_rocm_gpu_lock {
> +	if {![runto_main]} {
> +	    return
> +	}
> +
> +	with_test_prefix "with-breakpoint" {
> +	    gdb_test_no_output "set amdgpu precise-memory off"
> +
> +	    # Define a breakpoint right after the line that would
> +	    # cause segfault.  SIGSEGV should be reported, not a
> +	    # breakpoint hit.
> +	    gdb_breakpoint [gdb_get_line_number "Break here"] -allow-pending
> +
> +	    gdb_test "continue" \
> +		"SIGSEGV, Segmentation fault.*Warning: precise memory violation signal reporting is not enabled.*"
> +	}
> +    }

I think this should use

  foreach_with_prefix with_breakpoint {yes no} {
     ...
  }

and then only set the breakpoint if $with_breakpoint is yes.

Otherwise, LGTM.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon