From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7adFOqb0u2qN5hgAWB0awg (envelope-from ) for ; Tue, 29 Sep 2026 13:25:58 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=bSIT6H7e; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C26C21E01F; Tue, 29 Sep 2026 13:25:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 50FCB1E01F for ; Tue, 29 Sep 2026 13:25:57 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C2AC64BB3BDF for ; Tue, 29 Sep 2026 17:25:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C2AC64BB3BDF Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=bSIT6H7e Received: from YT6PR01CU002.outbound.protection.outlook.com (mail-canadacentralazlp170120003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::3]) by sourceware.org (Postfix) with ESMTPS id D9D054B9DB4F for ; Tue, 29 Sep 2026 17:25:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D9D054B9DB4F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D9D054B9DB4F Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1790702730; cv=pass; b=dNZE8RzMEWwhvOUNG0/H9onIvK6sKIzYQMYD48l3y/HUCKMG9cLpB0CDRAwszBhnLpDlm6a/ECvG5wCsRJJ3cBYqiDOEiqsQkslj7m3tl7E6oRsH6eH8xxg3ADrdcia0pvp+b8Tm1d1M0yhmYua4WfIVBZlRiWnrMXVC6TiuToY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1790702730; c=relaxed/simple; bh=LMlp/1vNMCKDfbpDjsMyg37pbLYWbUuwoMDTUqbPv7Y=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=Zrc48MlGlVJzGME9zzQSm0EoFSwo1busHH0fNABEGXFhytlf2kDfexJwzqth9BCg6RDzTBqQwr0dhd1fa/9Q5THdj4rU+Y1XPiKktMrMI+U4yLXBHe5fkw0dH027un81H/yZlrWC1SBnPAWsqSyIqbqklS0tJEsh2kE3EnwcCv4= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=bSIT6H7e DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D9D054B9DB4F ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=davEmZWjCcNWIaKMjcyQmA29YJpEEK8gBpBbFkPwzDtMyBNmEJUdzDJTSpB4SVrC+D5cu4oHP8YmzNm+AXhDUFCczRkZWoCqJ7XcneCgAoYImT0Q6h3UEnOmp6AeDJTme78H6qDESXGiOHhc3/Yoq5JK19ZlQk8qj98sKkCJYPJYOD6RSZatcXVwTBK9OYFiC+yd9T/CmoXlLnCCzkzMqgdDRiaHD8uWQVB74SmmCl718zM+J0mmdOwmffbrS/MjG33sPAXxk0RifbMNj2xaDJ6+UHDElyZVta6tN0+6s4Ly1RY6xQqAnODWmgMyopPcSIwtC0mvUB0xMfE2Xe6gkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NzyA1wsZTnC/ept4RclP9Nnsyn8R0yQg61k+0gEuxvA=; b=luXo8ENthLmZ3s8ZfTcmjH3H/5BLdlNcmKjfQuz1xmQd7Jcilb3rl+hrs4JbN9GD2XG4xgq2020ImDuzA4r3k5Byy/07I+05X6eop5KzjATGXqMt38MTgYSBaSkzvSrmKrctsmDKTp0Yo1f18EODGaKMk/vdFOXFBn8/6bB9/Ln/2hLYMVrrIk8d3paLiSg2Gi8CGlpzgojBIxS8hXwjSXFvGy5fagBagNwk8BitmBmbKQiGA6/IwWfimwS2YVY8A4fzNiffQjaTC9aihi8zMCQvmCcLfjt6MWKsk7/yxGmA4PFL8negdjGGM7MaLwQlajW0Lu1QejH4SkYYYA4xoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NzyA1wsZTnC/ept4RclP9Nnsyn8R0yQg61k+0gEuxvA=; b=bSIT6H7eNs688vMwXkwm6EKyc/oUus1Oorpuf6wYHkY9MOXBx4m03ElAGLpeo4JDDNqVfM2PQefIWEOIyvJZt1XqTV1iEiBa8vNFbAAkYlZByKUIthQJp07yWS2K9q4L5A1LpLRnctAGGS+azHK9MJYP6bwBPF4ySIx1lWwB4s7QEthb/WLRBN9macZD1MrbbXlR3o9JRuKUb8Et81HnsISM7zVTM637OxJ1jIgRPECLO+sVwzSe6FrV5Hl7ibgy1yfBw6+dMmL/gglWGQGL20JR/57etqJuBTm6M/z2FqmDjLI0qoUoQpbE01tA1cpyxI5HbfQMHTPARBqrcjgKoQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YQBPR0101MB6554.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:49::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.25; Tue, 29 Sep 2026 17:25:22 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%7]) with mapi id 15.21.0451.026; Tue, 29 Sep 2026 17:25:22 +0000 Message-ID: <3501e2a3-1ec1-44fc-abcf-764e3991018c@efficios.com> Date: Tue, 29 Sep 2026 13:25:20 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb, amdgpu: report SIGSEGV instead of SIGTRAP To: Tankut Baris Aktemur , gdb-patches@sourceware.org, lancelot.six@amd.com References: <20260929143125.1098582-1-tankutbaris.aktemur@amd.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20260929143125.1098582-1-tankutbaris.aktemur@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0274.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:68::33) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YQBPR0101MB6554:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f6c4ce6-e711-42d7-7cf0-08df1e4ea43b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|10070799003|376014|366016|23010399003|1800799024|10067099003|56012099006|3023799007|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: OgjCjGo71tkJHTFvkmqNdjb82yJMtsPJbcE2mVxo4Bjkb1HFrCT2fHv39ZX00FNmFGCjbKA3cES+bh3jGDyrabK7gvP6KQUkadVRbnGEzicVoVqB+miO76gsWa9ENVHykpa7QjTalRrYnsdk8IHU7CN+Euj0+onDa879+4hQVFhww5Dmr9JRWNBTOpGqI/qb83anUH9RA9lIhxQ4aHXlDy3ujW/Sd1y/ySglGVbZwFotRKdNCNIKO2DcAO6qxEbC+XMgWT5/Jv7Hbaczn2e5SxUqPQ080FgEiHQBbdv1DiVOtuZ1RoFWvBYkLYnyKKPkHEuI/MgP99mCYrfuJ08tuMrKNYgdQ4MM/y9QJQBcLo6v1Eiq1voKgsEqslL8F3Jx4/7IaNWt/jQ0s4Zgg0MDz+26iNJK+tpjBCEqjzOzG8Q8WbncuWlhWe5g4PQTgDIH9c3SXOgaRKOf6fj2xJ5R5v6VoDvOH9IlFyQXerSaSlekY45RJeoDiHpOir2q0GI2ks22BP13xlHQNReqScKLZMEHXKkqUirF45t2mIk9eIgAKT0IReJkI4zytfXbNPvy7I0/a8CC9jWqmVYspU2T7JAd3DlXTvswkXO/DUsKNt9J4V2uSZ4KhMMHYe5t/EzPbjhuhybh+DZH3OeqSUBOIpOfx0LyAos/zj3vYnQEb1g= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(10070799003)(376014)(366016)(23010399003)(1800799024)(10067099003)(56012099006)(3023799007)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnlnWmRmZ2Y5MjJ6ZEZWcUVvNlQ2a2pLQ3Y2d2FxLzJROUMrSGtzTjA1Nkhx?= =?utf-8?B?U1JwS1Npb25EL1JtdFArYUhaQkhKWDBESGUxWWVidyt0cU9ENUxMamNXR1RZ?= =?utf-8?B?aVVoWGZyenBqbEozWmVFdVd2MUtiZWc3Wjl2Sjg5NFhpQVcybXFQSHNiZXpX?= =?utf-8?B?elFVYll4SHFibCtCbDZXVDlpVXh5RU9nd2hEekFabW1GenlDRWV0N25wMlN3?= =?utf-8?B?c0dzUjU2Sjhxd25zbUxTZkNGbElublVLVU43VWZZeUtJSGliUlBuMmxjZkdT?= =?utf-8?B?djNKZlBiREJTYmR0UVhwcXQ3Ymh6WmdpVkhYWDVHcVRpR2NVQkVTTElOZHN5?= =?utf-8?B?eG9hTEEybURvUnUvV2pGMEcwQ0gyeEhoeElWUy9IdHJJeFB5YmhrQ3FLSk40?= =?utf-8?B?aFlkS04rVndvLzhhZFNvQndDdTA0c3ROZERvdnNKU1pTTS9GYVZQUmJsc2dU?= =?utf-8?B?eTExNE05WXpSdElFM3IwcUxCZXFKK2Z4MlBaK1ZZMDkxSWl4TUdXY2ppOXY5?= =?utf-8?B?Rjh1RlBIQ2N1T0dzeGN3TndjWkZjdnppWTdrSTA5a1JNaDdnMW1aZk0xTXBx?= =?utf-8?B?M3llRGRUbVcwMjl5clljRmM4c1FwdlJTUUVDR3FiS0M0VXhwUHlhR2txZVBM?= =?utf-8?B?aysxdGNnNCtZRngvMmxqelp5bE16OHNnRU1VVG5vSWplVzlEaDdUb3l6ODV5?= =?utf-8?B?SnYyQnMyazUwbng4bVFpd2hkOHFRa2NQcVhmTUY3VXZZYmVtL0UwVmxOM3Nv?= =?utf-8?B?QUZSclZQWGRLYXRVQSszQ0pTaU1rb25TU3RKUlNOU2ZoWlVTWWVQaCtNaWNH?= =?utf-8?B?WEdteHQyQXZqaS9XcjhUdGlFMXZmRzRQMTRjczAzWlVpZlp2ZzN1K1RQM0Uw?= =?utf-8?B?NVVpd21Zajd1Y2dHUFBxZ3dUL2ZtdkFZelZVV2FxTmJJcUU3b2xCa2FHdHNm?= =?utf-8?B?TGltRkFyZno2NjdnU1hlT2tQbjJqSE1Ta2ZsV2EzZ3VQQWRaZ1M0eGpPUHZU?= =?utf-8?B?SXgrbWdnV3NSdDB5SnNYcDBMY2JuOWh5QzdUNThEajBacCs5dUVPaGsrSUQ5?= =?utf-8?B?RTY1d0pHT2Q3QUw0OXVVdWFaV01mSFhSRExDVW0rNWRZdFAwMUVvbVA0eFdt?= =?utf-8?B?R012citGdmRYMkVxUmRiZnhCSTdIaS9hSEtTMG9aS0kwZXpOT1pMVWJQRVBu?= =?utf-8?B?cFZCdTkzRTlLck9OSUpOaGdQaXZ2V29HL2hiYThXaVNMbHRWOCtwNlluK045?= =?utf-8?B?L29NSU9wa0lKYUlyaitPZ2JNTFVSeUVwVHdrTEFqRmd4NWhjVlVLZmlwamtU?= =?utf-8?B?MHYyMDRFQlczaklHNmVpOVZKQzBrWXlvV2Zha0RwL0hxdEZaOGlIc3A2M1hX?= =?utf-8?B?NGpQS0NXUTZuZU9qZ1NaWjdzR29pRjlBeVdFclE0eHpqTUw1b0tPS3c4UWYz?= =?utf-8?B?SjlQVG1nbVVsNTFPdGNJQmF4TjVwVHE0NGtGcDc5M1ZacHlBRUZXcWh3bU9K?= =?utf-8?B?VkZxUnBqZEZPOXlTVmdObWZqWWxFYU0ybENvV2g2M3VicDlsd211cSttSGEx?= =?utf-8?B?UlRSemhKc2lnMk5rUlUyb3g4V0pwUlVOSy9hMDFMVWVnRjRNR0lOYjhXV2xs?= =?utf-8?B?QXRLNHh6UU9pLzlMN3pUNlZNNEVCS2xxZUxvU0pBTWw2SmdEZmtmUmVJc0ph?= =?utf-8?B?cXFteXJXQnZOZGFjcjNsRm0yR093eWJJdFVIL1ZNNlZuZnR4T21NTzRqdFgx?= =?utf-8?B?dEszVUtSUWFsQkNDN29NRjRYdWFvRHY4bmZrQ2hQQTVNU1VBbnk5c3pZVlN3?= =?utf-8?B?VmsrMXZMY24rVldweERiOFlPVEM2em5yNDNOQ1NtK0hDa2tkZ29qQ2Y0WE9E?= =?utf-8?B?Ymd0amlKVk5uendpUncycEVqdyttRUovbDJkVHRLWWp6RTd6U2Q3T2tqQVZQ?= =?utf-8?B?T0VSdEh1NnhreXU3VVRtZ0Vxa1BWT29NOFliTU5OR0RWcnp4RkJNUlFPZ0Vp?= =?utf-8?B?MktDamdFdnhLZGQ0QUVBcERkamwweDRjdmI5VTZZcXFQZkhZTXE1YU5WRjZR?= =?utf-8?B?NXB2dGhtbE4zNEhzQ0NNbjJoZnlIWkIyYW1GdXd6TGVQQkwvWFV2a3BWYWJJ?= =?utf-8?B?SGpDcHoydldEZmdJWUo0SDUwNHJjVzB3bXBzWWo1bjZ2aStoWktLYWkxZkpM?= =?utf-8?B?SHVQeHhjeUxxSEJuczhkTDMwbzdNU3NqamwxK1RTbjRnOG9PMEpub3NKUXc3?= =?utf-8?B?Znc0Z0hXTGhMTGpZck1oeDFxd3YvUDdiWjZxY2RyTEd6TG53UTUrbDhCdnky?= =?utf-8?B?Y080YlpzM0FPNTVGQlBJWXQ5TDVJNFh5alZiVG9rZVhKMGN2a3g2WDdYNFFH?= =?utf-8?Q?eOmNd6kNNLdoo568ZqwDx7TZS6vvcSDPZDByYqCULlYlN?= X-MS-Exchange-AntiSpam-MessageData-1: 9X0L2KW9hEXyVg== X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f6c4ce6-e711-42d7-7cf0-08df1e4ea43b X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2026 17:25:22.2818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qV4iNNRQrcUnQoufbLCvNF+1QQcaU3TwgGhUrtSeh9MUMiwgxTf1i87EqwJdUtcrt5LN9guVHOkD37NsiA/XIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB6554 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/29/26 10:31 AM, Tankut Baris Aktemur wrote: > diff --git a/gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.exp b/gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.exp > index 460d14a2b30..755fc0a7a56 100644 > --- a/gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.exp > +++ b/gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.exp > @@ -29,8 +29,7 @@ if {[build_executable "failed to prepare" $testfile $srcfile {debug hip}]} { > } > > proc do_test { } { > - clean_restart > - gdb_load $::binfile > + clean_restart $::testfile > > with_rocm_gpu_lock { > if {![runto_main]} { > @@ -41,6 +40,26 @@ proc do_test { } { > gdb_test "continue" \ > "SIGSEGV, Segmentation fault.*Warning: precise memory violation signal reporting is not enabled.*" > } > + > + clean_restart $::testfile > + > + with_rocm_gpu_lock { > + if {![runto_main]} { > + return > + } > + > + with_test_prefix "with-breakpoint" { > + gdb_test_no_output "set amdgpu precise-memory off" > + > + # Define a breakpoint right after the line that would > + # cause segfault. SIGSEGV should be reported, not a > + # breakpoint hit. > + gdb_breakpoint [gdb_get_line_number "Break here"] -allow-pending > + > + gdb_test "continue" \ > + "SIGSEGV, Segmentation fault.*Warning: precise memory violation signal reporting is not enabled.*" > + } > + } I think this should use foreach_with_prefix with_breakpoint {yes no} { ... } and then only set the breakpoint if $with_breakpoint is yes. Otherwise, LGTM. Approved-By: Simon Marchi Simon