Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/remote] Reimplement escape_buffer
Date: Sat, 21 Mar 2026 10:45:55 +0100	[thread overview]
Message-ID: <34365e0a-41cb-4239-bed7-c70665baf32a@suse.de> (raw)
In-Reply-To: <87341u9zpw.fsf@tromey.com>

On 3/20/26 6:29 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> +#include <sstream>
> 
> I don't think we want C++ streams generally.
> At least we haven't so far.
> 
> Tom> +      if (isprint (c))
> 
> gdb generally uses c_isprint, not the ctype stuff.
> 

Hi Tom,

thanks for the review.

I've fixed these two things in a v2 ( 
https://sourceware.org/pipermail/gdb-patches/2026-March/226119.html ).

Thanks,
- Tom


      reply	other threads:[~2026-03-21  9:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20 14:09 Tom de Vries
2026-03-20 17:29 ` Tom Tromey
2026-03-21  9:45   ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34365e0a-41cb-4239-bed7-c70665baf32a@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox