From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6VEsNfFovmm3cTIAWB0awg (envelope-from ) for ; Sat, 21 Mar 2026 05:46:25 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fHBQRQXR; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=g3dsI2Mb; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fHBQRQXR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=g3dsI2Mb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D3B981E0BC; Sat, 21 Mar 2026 05:46:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 349211E04F for ; Sat, 21 Mar 2026 05:46:25 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id AB5084B920EB for ; Sat, 21 Mar 2026 09:46:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AB5084B920EB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fHBQRQXR; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=g3dsI2Mb; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fHBQRQXR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=g3dsI2Mb Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 562964BB5939 for ; Sat, 21 Mar 2026 09:45:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 562964BB5939 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 562964BB5939 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774086357; cv=none; b=dSeA9VHy3+0GOJOPwMWc6P25QzC6diK05yCqKOdkbYsGq+7NTEd6vTYnvm7BzXPyfKQsip+ve6rYLEnogANGNhOqTz7pcie6uYnNXDaRfi+8IIIb950mNqKnSfJ0sGbKhmm4vdHQ6+MoQVwh5bf3j/krQ3TRfb6cRVlOHOP3w7E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774086357; c=relaxed/simple; bh=CMcxD8H+RH/C8WeSAfgWvuft9LaawhyvZF1b2plbwVw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=xsWhVs6z6d/Z3GXvcA0xwT4NixTFsctVWhSjSL+P3sul9fzDFEG2GY01PRP0u2JJgyfTS3vgIPO6D139dwAvqygmo784OmwoYD0NCKT7ZfOFMfU/dA5lJC7/YgiIvPvEgt+Evxm365TVgEi4do4kmvPNUBumYn/01nuINVTHDwk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 562964BB5939 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 595C45BF44; Sat, 21 Mar 2026 09:45:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774086356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zH4EXo1sW4w1b/+jPi4zyNtKBmGlE/VZ9JllRDRB6wE=; b=fHBQRQXRDkgFvDMPEYnymt40nfoHH00FabB5DuSL4blasuqrGS0PK8DIZSwb8ijaoCdII3 ZwiuRs5EVYpeARn+PLQTz3N3Z3Q42qvnDKlrZvotBgmYqhRXzIkg7MiBF8uqRnBqeyqQG7 mrtdaJ7arFrVn878xoVO1vkDwXKTURU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774086356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zH4EXo1sW4w1b/+jPi4zyNtKBmGlE/VZ9JllRDRB6wE=; b=g3dsI2MbGn/MlMILck93NoAfVQRT6U6tVVm0bo4/XpDY9SRitaNMjaABUWSl8SHSjpoiXM wot63FDTgQ5FnfCw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774086356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zH4EXo1sW4w1b/+jPi4zyNtKBmGlE/VZ9JllRDRB6wE=; b=fHBQRQXRDkgFvDMPEYnymt40nfoHH00FabB5DuSL4blasuqrGS0PK8DIZSwb8ijaoCdII3 ZwiuRs5EVYpeARn+PLQTz3N3Z3Q42qvnDKlrZvotBgmYqhRXzIkg7MiBF8uqRnBqeyqQG7 mrtdaJ7arFrVn878xoVO1vkDwXKTURU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774086356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zH4EXo1sW4w1b/+jPi4zyNtKBmGlE/VZ9JllRDRB6wE=; b=g3dsI2MbGn/MlMILck93NoAfVQRT6U6tVVm0bo4/XpDY9SRitaNMjaABUWSl8SHSjpoiXM wot63FDTgQ5FnfCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4417042CD0; Sat, 21 Mar 2026 09:45:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id GDJGD9Rovmm9RwAAD6G6ig (envelope-from ); Sat, 21 Mar 2026 09:45:56 +0000 Message-ID: <34365e0a-41cb-4239-bed7-c70665baf32a@suse.de> Date: Sat, 21 Mar 2026 10:45:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/remote] Reimplement escape_buffer To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260320140926.3721875-1-tdevries@suse.de> <87341u9zpw.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87341u9zpw.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/20/26 6:29 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> +#include > > I don't think we want C++ streams generally. > At least we haven't so far. > > Tom> + if (isprint (c)) > > gdb generally uses c_isprint, not the ctype stuff. > Hi Tom, thanks for the review. I've fixed these two things in a v2 ( https://sourceware.org/pipermail/gdb-patches/2026-March/226119.html ). Thanks, - Tom