Re: [PATCH] Don't nest double quotes in tuiterm.exp

[Tom de Vries <tdevries@suse.de>]

On 7/30/25 20:07, Tom Tromey wrote:
> I found a line in tuiterm.exp that causes Emacs paren-matching to go
> awry.

Hi Tom,

thanks for finding this.

I played around a bit with this and was able to observe the following.

If I type foo between the double quotes:
...
             verbose -log "$fmt [get_line_1 $y "foo" $attrs]"
...
I observe that the foo gets highlighted as not part of a string.

If I change the double quotes to curly braces, that changes.  I'm not 
sure if that is the issue you observed though.

But yeah, I agree there is a problem with syntax highlighting.

Anyway, normally I don't observe this because I use emacs with 
TERM=xterm-old forcing monochrome to be able to read diffs.

> This patch fixes the problem by changing some apparent nested
> double quotes (which I think isn't really possible in Tcl but this
> seems to be the intent) to be more correct; which fixes the Emacs
> issue as well.

This was my code, so I build a small tcl example to understand if it 
made a difference or not:
...
#!/usr/bin/tclsh

proc verbose { args } {
     foreach arg $args {
	puts "$arg"
     }
}

set y "y z"
set attrs "attrs attrs2"

proc get_line_1 { args } {
     set str ""
     foreach arg $args {
	set str "$str<$arg>"
     }
     return $str
}

verbose -log "[get_line_1 $y "" $attrs]"
verbose -log "[get_line_1 $y {} $attrs]"
...
and it seems not:
...
$ ./test.tcl
-log
<y z><><attrs attrs2>
-log
<y z><><attrs attrs2>
...

Anyway, my understanding of TCL is purely operational, so you may be 
right that it's not proper TCL. FWIW, I looked here ( 
https://www.tcl-lang.org/man/tcl8.6/TclCmd/Tcl.htm#M11 ) and didn't see 
anything forbidding this usage.

I'll try to avoid this in the future.

LGTM.

Approved-By: Tom de Vries <tdevries@suse.de>


Thanks,
- Tom

> ---
>   gdb/testsuite/lib/tuiterm.exp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/lib/tuiterm.exp b/gdb/testsuite/lib/tuiterm.exp
> index cc8e852690a..b83b8afdcec 100644
> --- a/gdb/testsuite/lib/tuiterm.exp
> +++ b/gdb/testsuite/lib/tuiterm.exp
> @@ -1291,7 +1291,7 @@ namespace eval Term {
>   
>   	for {set y 0} {$y < $_rows} {incr y} {
>   	    set fmt [format %5d $y]
> -	    verbose -log "$fmt [get_line_1 $y "" $attrs]"
> +	    verbose -log "$fmt [get_line_1 $y {} $attrs]"
>   	}
>       }
>   
> 
> base-commit: 303045d9539d9032208b8b67f222943ff4c96b05