From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pWxEI038imjqmAAAWB0awg (envelope-from ) for ; Thu, 31 Jul 2025 01:17:01 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=C1ltDrCr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=b15g+6fU; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=mKsl0jPg; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qxMlFwQg; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7A8D41E102; Thu, 31 Jul 2025 01:17:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9DBAF1E089 for ; Thu, 31 Jul 2025 01:16:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A5B53858CD1 for ; Thu, 31 Jul 2025 05:16:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A5B53858CD1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=C1ltDrCr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=b15g+6fU; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=mKsl0jPg; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qxMlFwQg Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id E93393858D1E for ; Thu, 31 Jul 2025 05:16:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E93393858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E93393858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753938987; cv=none; b=O5FaWH2LfWMxWPRlGq+LNRxh0IW5TyxQjdMEHV7wBpS8KnwAuqnleuJMSpDuRssf3NazVMbL+ovM7zsnzslgvDX0NEzdfvuA9W69rv9dwmxPTFbHo7szODslEtX5ACjSEDn4x+zxjIWFcqUu5EU40Zf3t9gxkZrv5LYbu6WyNFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753938987; c=relaxed/simple; bh=sEDSkudK9IRzS8vMBEOlyWNy0wzykpNzufbq4fvsAsY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=qAzjX6ksnbSALZKOVilm3Cc15vPQBQBNK+8KpZaQhDI2aVyfVAKjxzjJromQcZCddkOfGbjlyvz2Rz3ZCpMS5XYMcW+rlDVSP4bg47O0J10xDMGS0wbh/nQi70UonFfrzKPcQ/mGsuIFD6WBXbCBUy+jfn/MSXKZycpV3YwHtqo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E93393858D1E Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B83B821986; Thu, 31 Jul 2025 05:16:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1753938986; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qplMIJATLZt9arl+c428zXyJ0acYofyuyeZUdkeQbj4=; b=C1ltDrCrv963VoWo9y72JglNxBIsrHHmPWNoX4nTbilKhUetSjpGSfS/f+J8fSkGugJFRA nZYshFystBJvM7J3W2fRIyH5mRG/bP14sOpZARgwQTEEamnda87dVHIGiOxyzP7WsFaHxk HapIvnKWMbySja55rBPtf4xUMm2aqnE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1753938986; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qplMIJATLZt9arl+c428zXyJ0acYofyuyeZUdkeQbj4=; b=b15g+6fU7+uUHsPlDS84NC8W4nJdJZpYv4Fls0VpX0QznjQHQ4tgfHKzDXU1r8698kYrz0 cmFfDspEqwTejWCw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mKsl0jPg; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qxMlFwQg DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1753938985; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qplMIJATLZt9arl+c428zXyJ0acYofyuyeZUdkeQbj4=; b=mKsl0jPgS7SBf5k5J1WqzJGQ7/JqAWiMhA5zsHmyEXdrOZBqQlu7VFjfXIQ2glTzaUZavg NU0rIe6csjM1pMzQwOvlaNpAgOLsYcWY+k6boH2FqcPy3zbyIR5t/v+VzKqJoXUGchZPEL t/JD9WEQwzHpcXFz/MES4CFRtEqrBGA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1753938985; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qplMIJATLZt9arl+c428zXyJ0acYofyuyeZUdkeQbj4=; b=qxMlFwQgZdtilME+iYU1iwCJYA1YHC5tx1nZkvglKgWeLv5sXgYEmkQ34cCl4sRt8B50Le aAviL0tfQa9Yw6AA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9F9FA1378C; Thu, 31 Jul 2025 05:16:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id S9DwJCn8imh+SQAAD6G6ig (envelope-from ); Thu, 31 Jul 2025 05:16:25 +0000 Message-ID: <33d74239-c166-4d5a-897d-977c000327df@suse.de> Date: Thu, 31 Jul 2025 07:16:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Don't nest double quotes in tuiterm.exp To: Tom Tromey , gdb-patches@sourceware.org References: <20250730180715.3443362-1-tromey@adacore.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20250730180715.3443362-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim,suse.de:email,tcl-lang.org:url]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns, suse.de:mid, suse.de:dkim, suse.de:email, tcl-lang.org:url] X-Rspamd-Queue-Id: B83B821986 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/30/25 20:07, Tom Tromey wrote: > I found a line in tuiterm.exp that causes Emacs paren-matching to go > awry. Hi Tom, thanks for finding this. I played around a bit with this and was able to observe the following. If I type foo between the double quotes: ... verbose -log "$fmt [get_line_1 $y "foo" $attrs]" ... I observe that the foo gets highlighted as not part of a string. If I change the double quotes to curly braces, that changes. I'm not sure if that is the issue you observed though. But yeah, I agree there is a problem with syntax highlighting. Anyway, normally I don't observe this because I use emacs with TERM=xterm-old forcing monochrome to be able to read diffs. > This patch fixes the problem by changing some apparent nested > double quotes (which I think isn't really possible in Tcl but this > seems to be the intent) to be more correct; which fixes the Emacs > issue as well. This was my code, so I build a small tcl example to understand if it made a difference or not: ... #!/usr/bin/tclsh proc verbose { args } { foreach arg $args { puts "$arg" } } set y "y z" set attrs "attrs attrs2" proc get_line_1 { args } { set str "" foreach arg $args { set str "$str<$arg>" } return $str } verbose -log "[get_line_1 $y "" $attrs]" verbose -log "[get_line_1 $y {} $attrs]" ... and it seems not: ... $ ./test.tcl -log <> -log <> ... Anyway, my understanding of TCL is purely operational, so you may be right that it's not proper TCL. FWIW, I looked here ( https://www.tcl-lang.org/man/tcl8.6/TclCmd/Tcl.htm#M11 ) and didn't see anything forbidding this usage. I'll try to avoid this in the future. LGTM. Approved-By: Tom de Vries Thanks, - Tom > --- > gdb/testsuite/lib/tuiterm.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/lib/tuiterm.exp b/gdb/testsuite/lib/tuiterm.exp > index cc8e852690a..b83b8afdcec 100644 > --- a/gdb/testsuite/lib/tuiterm.exp > +++ b/gdb/testsuite/lib/tuiterm.exp > @@ -1291,7 +1291,7 @@ namespace eval Term { > > for {set y 0} {$y < $_rows} {incr y} { > set fmt [format %5d $y] > - verbose -log "$fmt [get_line_1 $y "" $attrs]" > + verbose -log "$fmt [get_line_1 $y {} $attrs]" > } > } > > > base-commit: 303045d9539d9032208b8b67f222943ff4c96b05