Re: [RFA]: no "no debugging symbols found" for separate debug

[Tristan Gingold <gingold@adacore.com>]

Hi,

thanks for this quick review and sorry for removing one item from your  
todo list :-)

Committed with the nit fixed.

Tristan.

On Oct 12, 2009, at 9:12 PM, Doug Evans wrote:

> On Mon, Oct 12, 2009 at 12:04 PM, Doug Evans <dje@google.com> wrote:
>>
>> On Mon, Oct 12, 2009 at 6:57 AM, Tristan Gingold  
>> <gingold@adacore.com> wrote:
>>>
>>> Hi,
>>>
>>> when a stripped executable with a separate debug file is loaded,  
>>> gdb prints "no debugging symbols found".
>>> I think this is confusing and this was not printed in gdb 6.8
>>>
>>> The reason is that only the objfile is checked, not the separate  
>>> debug file.
>>>
>>> This patch fixes that and add a test in the sepdebug.exp file.
>>>
>>> Tristan.
>>>
>>> 2009-10-12  Tristan Gingold  <gingold@adacore.com>
>>>
>>>        * objfiles.c (objfile_has_symbols): New function.
>>>        * objfiles.h (objfile_has_symbols): Add prototype.
>>>        * symfile.c (symbol_file_add_with_addrs_or_offsets): Call
>>>        objfile_has_symbols.
>>>        (reread_symbols): Ditto.
>>>
>>> testsuite/
>>> 2009-10-12  Tristan Gingold  <gingold@adacore.com>
>>>
>>>        * gdb.base/sepdebug.exp: Check debug info are found.
>>>
>>
>> Thanks.  Tom pointed this out and it's on my todo list.  Or was.
>>
>> This is ok with me.
>>  Thanks again.
>>
>
> Apologies for the resend.  Gmail sent the reply as text/html.  Sigh.
>
> One nit:
>
> +    or throught its the separate debug file.  */
>
> s/throught its the/through its/
>