From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23673 invoked by alias); 13 Oct 2009 07:58:39 -0000 Received: (qmail 23660 invoked by uid 22791); 13 Oct 2009 07:58:38 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Oct 2009 07:58:35 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 90F4E290007; Tue, 13 Oct 2009 09:58:32 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RLCS8AdYNldJ; Tue, 13 Oct 2009 09:58:31 +0200 (CEST) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id E1AE5290030; Tue, 13 Oct 2009 09:58:31 +0200 (CEST) Subject: Re: [RFA]: no "no debugging symbols found" for separate debug Mime-Version: 1.0 (Apple Message framework v1076) Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes From: Tristan Gingold In-Reply-To: Date: Tue, 13 Oct 2009 07:58:00 -0000 Cc: gdb-patches ml Content-Transfer-Encoding: 7bit Message-Id: <339E7432-6684-4E46-830F-6A5E252CFA3D@adacore.com> References: To: Doug Evans X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00261.txt.bz2 Hi, thanks for this quick review and sorry for removing one item from your todo list :-) Committed with the nit fixed. Tristan. On Oct 12, 2009, at 9:12 PM, Doug Evans wrote: > On Mon, Oct 12, 2009 at 12:04 PM, Doug Evans wrote: >> >> On Mon, Oct 12, 2009 at 6:57 AM, Tristan Gingold >> wrote: >>> >>> Hi, >>> >>> when a stripped executable with a separate debug file is loaded, >>> gdb prints "no debugging symbols found". >>> I think this is confusing and this was not printed in gdb 6.8 >>> >>> The reason is that only the objfile is checked, not the separate >>> debug file. >>> >>> This patch fixes that and add a test in the sepdebug.exp file. >>> >>> Tristan. >>> >>> 2009-10-12 Tristan Gingold >>> >>> * objfiles.c (objfile_has_symbols): New function. >>> * objfiles.h (objfile_has_symbols): Add prototype. >>> * symfile.c (symbol_file_add_with_addrs_or_offsets): Call >>> objfile_has_symbols. >>> (reread_symbols): Ditto. >>> >>> testsuite/ >>> 2009-10-12 Tristan Gingold >>> >>> * gdb.base/sepdebug.exp: Check debug info are found. >>> >> >> Thanks. Tom pointed this out and it's on my todo list. Or was. >> >> This is ok with me. >> Thanks again. >> > > Apologies for the resend. Gmail sent the reply as text/html. Sigh. > > One nit: > > + or throught its the separate debug file. */ > > s/throught its the/through its/ >