Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Lancelot SIX <lsix@lancelotsix.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4 1/4] gdb: Introduce setting construct within cmd_list_element
Date: Thu, 30 Sep 2021 08:39:05 -0400	[thread overview]
Message-ID: <332a94bf-dbf4-b576-cc62-ac2e0bb66993@polymtl.ca> (raw)
In-Reply-To: <20210929215011.1489639-2-lsix@lancelotsix.com>

Just a nit here:

> +  /* Return the current value.
> +
> +     The template parameter T is the type of the variable used to store the
> +     setting.
> +
> +     The returned value cannot be NULL (this is checked at runtime).*/

The last line of the comment here doesn't seem relevant with the code we
have now.

> +  template<typename T>
> +  const T &get () const
> +  {
> +    gdb_assert (var_type_uses<T> (m_var_type));
> +    gdb_assert (m_var != nullptr);
> +
> +    return *static_cast<T const *> (m_var);
> +  }

Simon

  parent reply	other threads:[~2021-09-30 12:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 21:50 [PATCH v4 0/4] Refactor cmd_list_element.var Lancelot SIX via Gdb-patches
2021-09-29 21:50 ` [PATCH v4 1/4] gdb: Introduce setting construct within cmd_list_element Lancelot SIX via Gdb-patches
2021-09-30 12:12   ` Simon Marchi via Gdb-patches
2021-09-30 12:30     ` Simon Marchi via Gdb-patches
2021-09-30 23:15       ` Lancelot SIX via Gdb-patches
2021-10-01  1:16         ` Simon Marchi via Gdb-patches
2021-09-30 12:39   ` Simon Marchi via Gdb-patches [this message]
2021-09-29 21:50 ` [PATCH v4 2/4] gdb: make string-like set show commands use std::string variable Lancelot SIX via Gdb-patches
2021-09-29 21:50 ` [PATCH v4 3/4] gdb: Have setter and getter callbacks for settings Lancelot SIX via Gdb-patches
2021-09-30 12:42   ` Simon Marchi via Gdb-patches
2021-10-05 19:10   ` Simon Marchi via Gdb-patches
2021-10-05 20:27     ` Lancelot SIX via Gdb-patches
2021-10-05 20:39       ` Simon Marchi via Gdb-patches
2021-10-05 22:21         ` Lancelot SIX via Gdb-patches
2021-09-29 21:50 ` [PATCH v4 4/4] gdb: Setting setter return a bool to tell if the value changed Lancelot SIX via Gdb-patches
2021-09-30 12:43   ` Simon Marchi via Gdb-patches
2021-09-30 12:44 ` [PATCH v4 0/4] Refactor cmd_list_element.var Simon Marchi via Gdb-patches
2021-10-03 19:22   ` Lancelot SIX via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=332a94bf-dbf4-b576-cc62-ac2e0bb66993@polymtl.ca \
    --to=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox