From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4GBCKECwVWEgVAAAWB0awg (envelope-from ) for ; Thu, 30 Sep 2021 08:40:32 -0400 Received: by simark.ca (Postfix, from userid 112) id 912471EE27; Thu, 30 Sep 2021 08:40:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D58A51EDF7 for ; Thu, 30 Sep 2021 08:40:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0DE4F3858025 for ; Thu, 30 Sep 2021 12:40:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0DE4F3858025 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1633005631; bh=kAXNUoE92X/ItQRKcju4Ard53jUaKZHrLGsmowxw/xY=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=HR3lQimrrgFGkicWWbxgmzYXBYXL39ctk5kAX9Lw1E/krn/cU/VmeJT38B5aAaEUQ 2tIA3fhieYyPMY7MHS50wby7/lC7XRuzwEM8wx7qffsPAXiTA/nJc5GcRDT4IB4SCM hDdcskVElCpphjFaMIrtSwG4pYaj2JiXUZ8hVHDI= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id B427F3858C2C for ; Thu, 30 Sep 2021 12:40:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B427F3858C2C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 18UCd6tG026089 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Sep 2021 08:39:11 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 18UCd6tG026089 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2BBE91EDF7; Thu, 30 Sep 2021 08:39:05 -0400 (EDT) Message-ID: <332a94bf-dbf4-b576-cc62-ac2e0bb66993@polymtl.ca> Date: Thu, 30 Sep 2021 08:39:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH v4 1/4] gdb: Introduce setting construct within cmd_list_element Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org References: <20210929215011.1489639-1-lsix@lancelotsix.com> <20210929215011.1489639-2-lsix@lancelotsix.com> In-Reply-To: <20210929215011.1489639-2-lsix@lancelotsix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 30 Sep 2021 12:39:06 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Just a nit here: > + /* Return the current value. > + > + The template parameter T is the type of the variable used to store the > + setting. > + > + The returned value cannot be NULL (this is checked at runtime).*/ The last line of the comment here doesn't seem relevant with the code we have now. > + template > + const T &get () const > + { > + gdb_assert (var_type_uses (m_var_type)); > + gdb_assert (m_var != nullptr); > + > + return *static_cast (m_var); > + } Simon