From: pinskia@gmail.com
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: "Maciej W. Rozycki" <macro@codesourcery.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFC] Use address_from_register in dwarf2-frame.c:read_addr_from_reg
Date: Thu, 28 Aug 2014 12:37:00 -0000 [thread overview]
Message-ID: <32E1EB66-445E-476D-97E4-58DC67916808@gmail.com> (raw)
In-Reply-To: <201408281151.s7SBp3HT006739@d06av02.portsmouth.uk.ibm.com>
> On Aug 28, 2014, at 4:51 AM, "Ulrich Weigand" <uweigand@de.ibm.com> wrote:
>
> Maciej W. Rozycki wrote:
>>> On Wed, 27 Aug 2014, Ulrich Weigand wrote:
>>> I guess it isn't too hard to support gdbarch_convert_register_p in that
>>> routine as well; I just didn't have any target to test on.
>>>
>>> Can you try whether something along the following lines works for you?
>>
>> I'll see if I can push it through testing, though it may take a few days
>> as some of MIPS hardware I use (and especially 64-bit one) is slooow (and
>> I already have a test run under way).
>
> Thanks!
>
>> I'd expect the issue to be consistent across all ILP32 64-bit ABIs BTW,
>> that is e.g. x32 x86-64 as well.
>
> Well, I guess that depends on whether the hardware expects 32-bit pointer
> values to be sign-extended when loaded in 64-bit registers or not. I don't
> think x32 x86-64 requires this sign-extension (but I'm certainly not an
> expert here) ...
Both x32 and ilpl32 on arrch64 have zero-extended pointers so it should not be an issue with those two abis, only mips64's n32.
Thanks,
Andrew
>
> Bye,
> Ulrich
>
> --
> Dr. Ulrich Weigand
> GNU/Linux compilers and toolchain
> Ulrich.Weigand@de.ibm.com
>
next prev parent reply other threads:[~2014-08-28 12:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 17:00 Ulrich Weigand
2014-04-16 15:29 ` Joel Brobecker
2014-04-17 12:18 ` Ulrich Weigand
2014-08-27 4:01 ` Andrew Pinski
2014-08-27 12:21 ` Ulrich Weigand
2014-08-27 18:15 ` Maciej W. Rozycki
2014-08-28 11:51 ` Ulrich Weigand
2014-08-28 12:37 ` pinskia [this message]
2014-09-14 14:35 ` Maciej W. Rozycki
2014-09-15 11:40 ` Ulrich Weigand
2014-09-06 22:34 ` Andrew Pinski
2014-09-10 17:06 ` [COMMITTED] " Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32E1EB66-445E-476D-97E4-58DC67916808@gmail.com \
--to=pinskia@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox