From: Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tromey@adacore.com>,
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] Avoid self-test failures on x86-linux
Date: Fri, 29 Oct 2021 11:28:50 -0300 [thread overview]
Message-ID: <325373ef-31b2-6403-329b-cf8e3fa45c26@linaro.org> (raw)
In-Reply-To: <87y26clzyv.fsf@tromey.com>
On 10/29/21 10:31 AM, Tom Tromey via Gdb-patches wrote:
>>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Tom> The disassembly tests in "maint selftest" will fail on x86-linux.
> Tom> This happens because opcodes rejects an attempt to disassemble for an
> Tom> arch with a 64-bit address size when bfd_vma is 32-bit.
>
> Tom> This patch avoids this problem by avoiding the test in this case. I
> Tom> chose to do it this way because this seems to be the only situation
> Tom> where opcodes checks the size of bfd_vma.
>
> Tom> For v2 of this patch, I've also updated memory_error_test to do the
> Tom> same thing. This is needed due to the "improve error reporting from
> Tom> the disassembler" patch.
>
> I'm checking this in.
>
> Tom
>
Isn't this a broader issue? I recently reported some failures in the
gdb.base/all-architectures-2.exp, where disassembling fails due to
(apparently) some recent changes in error reporting.
next prev parent reply other threads:[~2021-10-29 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 19:43 Tom Tromey via Gdb-patches
2021-10-29 13:31 ` Tom Tromey via Gdb-patches
2021-10-29 14:28 ` Luis Machado via Gdb-patches [this message]
2021-10-29 14:47 ` Tom Tromey via Gdb-patches
2021-10-29 14:51 ` Luis Machado via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=325373ef-31b2-6403-329b-cf8e3fa45c26@linaro.org \
--to=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox