From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id coxMCzsFfGGwagAAWB0awg (envelope-from ) for ; Fri, 29 Oct 2021 10:29:15 -0400 Received: by simark.ca (Postfix, from userid 112) id 197961F0BB; Fri, 29 Oct 2021 10:29:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 61C0E1EE18 for ; Fri, 29 Oct 2021 10:29:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D669A3857802 for ; Fri, 29 Oct 2021 14:29:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D669A3857802 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1635517753; bh=ss3rhykSMoTfZ/vbzjhr2rtS+vnRxX7+YoT2+qzDdag=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=C4sX2Pt+IoHneyInQJnX2zZYOY/tPpNIhDcoTPGQ67sbzUmDt1GyjKrav2QD4AzC1 jv6QxL2qps1tuQsX6D/Kgy3kQbBNi4SlpmFhdDCWb2nZYcczHTCCpgZQ0xGPsByrQE n+QOiXei5T/wKAQdijYG1GLs4wy5ls9CzKoaLFHY= Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by sourceware.org (Postfix) with ESMTPS id 87C343858408 for ; Fri, 29 Oct 2021 14:28:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 87C343858408 Received: by mail-qk1-x72a.google.com with SMTP id bm16so9413505qkb.11 for ; Fri, 29 Oct 2021 07:28:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ss3rhykSMoTfZ/vbzjhr2rtS+vnRxX7+YoT2+qzDdag=; b=wB45z7B5FdZSAQV7b9BgsUS2OHX9WAWoy3G5ffPIgFSd+MDSsEpqF6yEMzqFsexuRf XHQNPuH8LE0dxcrWmQpSQTYFgErJeNA+vzJZLntHF5v1+/VbVzXwQfNzQ8BTw6rI/0HC JUGypVgj3RJsnKVFsH3sXWs/+Smau4qPr2X+PDJIZ8lsDZKRkb65voFLSMixAyWp4/8+ TGIn3M2EuLWrJvboy3JwU7r9pVyOE7utvoOCUODBP/XkCfu92qUWMwn2xLH/k8cCmTZj as8W1wufqtpXxxzSZtpNV98Xv13xigj3bRk9mIIX7yOAvpzlWNN9LRliGn55lUNWbF22 vdEA== X-Gm-Message-State: AOAM533y8UupHehAMq6O6mi1W+LProvT3vqEP8TSZWLeeZOSzcYr/sUT q0EIt+WaKYi/VpJXQiscH3rUiIxmDEcnGA== X-Google-Smtp-Source: ABdhPJwuSo1z4TkIx8531ZGCUO5Ul4kO83Q7ECRF4pjtpXuLqZ+UCU6YJS4Tfw+sK+M3WmUeMGIPgA== X-Received: by 2002:a05:620a:24ce:: with SMTP id m14mr9223090qkn.212.1635517734083; Fri, 29 Oct 2021 07:28:54 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:487c:90de:b9d2:cf03:8b6f? ([2804:7f0:4841:487c:90de:b9d2:cf03:8b6f]) by smtp.gmail.com with ESMTPSA id a17sm1421568qtx.7.2021.10.29.07.28.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Oct 2021 07:28:53 -0700 (PDT) Subject: Re: [PATCH v2] Avoid self-test failures on x86-linux To: Tom Tromey , Tom Tromey via Gdb-patches References: <20211018194308.177367-1-tromey@adacore.com> <87y26clzyv.fsf@tromey.com> Message-ID: <325373ef-31b2-6403-329b-cf8e3fa45c26@linaro.org> Date: Fri, 29 Oct 2021 11:28:50 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87y26clzyv.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 10/29/21 10:31 AM, Tom Tromey via Gdb-patches wrote: >>>>>> "Tom" == Tom Tromey via Gdb-patches writes: > > Tom> The disassembly tests in "maint selftest" will fail on x86-linux. > Tom> This happens because opcodes rejects an attempt to disassemble for an > Tom> arch with a 64-bit address size when bfd_vma is 32-bit. > > Tom> This patch avoids this problem by avoiding the test in this case. I > Tom> chose to do it this way because this seems to be the only situation > Tom> where opcodes checks the size of bfd_vma. > > Tom> For v2 of this patch, I've also updated memory_error_test to do the > Tom> same thing. This is needed due to the "improve error reporting from > Tom> the disassembler" patch. > > I'm checking this in. > > Tom > Isn't this a broader issue? I recently reported some failures in the gdb.base/all-architectures-2.exp, where disassembling fails due to (apparently) some recent changes in error reporting.