From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Sync proc_service definition with GLIBC
Date: Fri, 19 Aug 2016 14:02:00 -0000 [thread overview]
Message-ID: <3250b867-0477-ba2e-595b-226bad631ca4@linaro.org> (raw)
In-Reply-To: <b0adb59d-b4af-a084-ebb4-ec2a205e4c34@redhat.com>
On 17/08/2016 20:13, Pedro Alves wrote:
> On 08/17/2016 10:18 PM, Adhemerval Zanella wrote:
>> GLIBC BZ#20311 [1] proc_service.h install patch also remove 'const'
>> attributes from ps_get_thread_area and comment #15 discuss why to remove
>> the const attribute (basically since it a callback with the struct
>> ps_prochandle owned by the client it should be able to modify it if
>> it the case).
>>
>> On default build this is not the issue and current g++ does not trigger
>> any issue with this mismatch declaration. However, on some bootstrap
>> build configuration where gdbserver is build with gcc instead this
>> triggers:
>>
>> error: conflicting types for 'ps_get_thread_area'
>>
>> This patch fixes it by syncing the declaration with GLIBC.
>>
>> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=20311
>>
>> 2016-08-17 Adhemerval Zanella <adhemerval.zanella@linaro.org>
>>
>> * gdb/aarch64-linux-nat.c (ps_get_thread_area): Remove const from
>> struct ps_prochandle.
>> * gdb/amd64-linux-nat.c (ps_get_thread_area): Likewise.
>> * gdb/arm-linux-nat.c (ps_get_thread_area): Likewise.
>> * gdb/gdb_proc_service.h (ps_get_thread_area): Likewise.
>> * gdb/gdbserver/gdb_proc_service.h (ps_get_thread_area): Likewise.
>> * gdb/gdbserver/linux-aarch64-low.c (ps_get_thread_area): Likewise.
>> * gdb/gdbserver/linux-arm-low.c (ps_get_thread_area): Likewise.
>> * gdb/gdbserver/linux-crisv32-low.c (ps_get_thread_area): Likewise.
>> * gdb/gdbserver/linux-m68k-low.c (ps_get_thread_area): Likewise.
>> * gdb/gdbserver/linux-mips-low.c (ps_get_thread_area): Likewise.
>> * gdb/gdbserver/linux-nios2-low.c (ps_get_thread_area): Likewise.
>> * gdb/gdbserver/linux-tic6x-low.c (ps_get_thread_area): Likewise.
>> * gdb/gdbserver/linux-x86-low.c (ps_get_thread_area): Likewise.
>> * gdb/gdbserver/linux-xtensa-low.c (ps_get_thread_area): Likewise.
>> * gdb/i386-linux-nat.c (ps_get_thread_area): Likewise.
>> * gdb/m68klinux-nat.c (ps_get_thread_area): Likewise.
>> * gdb/mips-linux-nat.c (ps_get_thread_area): Likewise.
>> * gdb/nat/aarch64-linux.c (aarch64_ps_get_thread_area): Likewise.
>> * gdb/nat/aarch64-linux.h (aarch64_ps_get_thread_area): Likewise.
>> * gdb/xtensa-linux-nat.c (ps_get_thread_area): Likewise.
>
> OK, but please move the ChangeLog entries to the correct ChangeLog files,
> and make the entry paths be relative to the corresponding ChangeLog file.
> gdbserver changes go to gdb/gdbserver/ChangeLog, the rest goes
> to gdb/ChangeLog.
I forgot about the project distinctions, I will resend a proper one with
corrected ChangeLogs entries.
I will need someone to push it for me, since I think I do not have write
access to binutils git.
next prev parent reply other threads:[~2016-08-19 14:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 21:19 Adhemerval Zanella
2016-08-17 23:13 ` Pedro Alves
2016-08-19 8:37 ` Yao Qi
2016-08-19 8:41 ` Pedro Alves
2016-08-19 9:14 ` Yao Qi
2016-08-19 9:43 ` Pedro Alves
2016-08-19 14:02 ` Adhemerval Zanella [this message]
2016-08-22 10:15 ` Yao Qi
2016-08-19 8:25 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3250b867-0477-ba2e-595b-226bad631ca4@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox