From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27546 invoked by alias); 19 Aug 2016 14:02:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27529 invoked by uid 89); 19 Aug 2016 14:02:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2712 X-HELO: mail-yw0-f179.google.com Received: from mail-yw0-f179.google.com (HELO mail-yw0-f179.google.com) (209.85.161.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Aug 2016 14:02:29 +0000 Received: by mail-yw0-f179.google.com with SMTP id z8so13260634ywa.1 for ; Fri, 19 Aug 2016 07:02:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=wzV1IbzSo0Exi5Pt9kfMxCvEPCk5BoEJAnp7cMxUZ8o=; b=clPZJ7iNIlca6Qgfka8lOGCaw6SkwYFmIkBHwb588lPTU2xiRxKVbrjqUojuHE2KBZ pYPP1Yt2KbWHOVtU2EhcVhuVikSPWjqDd3pXPbtwJ2nG1HAEqQoYHzYpcV6P03Qg2gRC CEdyZ0nwwG4FQdanWFB8vTvYU/giQwTUsXwSZ6F58goKo1YeQCtFdo+ipHSndXENjB/r KoGxnQS5uKHAzuErOxwERol+1b5S0OzeA58PRFNVcJp4SazAEcRT7lxdaDwti/dN5qqF hG829vN27tYxvatMl3CqWVyV++YqDdM9SR1m/qBMPkE1t/1mM6L9kpJx20cofF2smgdQ gBKA== X-Gm-Message-State: AEkoouuWOh+KivoisXf8/iCB/VDBbaE1/Be674vJtfOgyrehg/cF4aujqyq8WisUvGKp1sMu X-Received: by 10.13.197.195 with SMTP id h186mr6336532ywd.54.1471615348174; Fri, 19 Aug 2016 07:02:28 -0700 (PDT) Received: from [10.0.0.5] ([179.159.110.216]) by smtp.googlemail.com with ESMTPSA id y12sm1634596ywg.46.2016.08.19.07.02.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Aug 2016 07:02:27 -0700 (PDT) Subject: Re: [PATCH] Sync proc_service definition with GLIBC To: Pedro Alves , gdb-patches@sourceware.org References: <1471468737-10208-1-git-send-email-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Message-ID: <3250b867-0477-ba2e-595b-226bad631ca4@linaro.org> Date: Fri, 19 Aug 2016 14:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00201.txt.bz2 On 17/08/2016 20:13, Pedro Alves wrote: > On 08/17/2016 10:18 PM, Adhemerval Zanella wrote: >> GLIBC BZ#20311 [1] proc_service.h install patch also remove 'const' >> attributes from ps_get_thread_area and comment #15 discuss why to remove >> the const attribute (basically since it a callback with the struct >> ps_prochandle owned by the client it should be able to modify it if >> it the case). >> >> On default build this is not the issue and current g++ does not trigger >> any issue with this mismatch declaration. However, on some bootstrap >> build configuration where gdbserver is build with gcc instead this >> triggers: >> >> error: conflicting types for 'ps_get_thread_area' >> >> This patch fixes it by syncing the declaration with GLIBC. >> >> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=20311 >> >> 2016-08-17 Adhemerval Zanella >> >> * gdb/aarch64-linux-nat.c (ps_get_thread_area): Remove const from >> struct ps_prochandle. >> * gdb/amd64-linux-nat.c (ps_get_thread_area): Likewise. >> * gdb/arm-linux-nat.c (ps_get_thread_area): Likewise. >> * gdb/gdb_proc_service.h (ps_get_thread_area): Likewise. >> * gdb/gdbserver/gdb_proc_service.h (ps_get_thread_area): Likewise. >> * gdb/gdbserver/linux-aarch64-low.c (ps_get_thread_area): Likewise. >> * gdb/gdbserver/linux-arm-low.c (ps_get_thread_area): Likewise. >> * gdb/gdbserver/linux-crisv32-low.c (ps_get_thread_area): Likewise. >> * gdb/gdbserver/linux-m68k-low.c (ps_get_thread_area): Likewise. >> * gdb/gdbserver/linux-mips-low.c (ps_get_thread_area): Likewise. >> * gdb/gdbserver/linux-nios2-low.c (ps_get_thread_area): Likewise. >> * gdb/gdbserver/linux-tic6x-low.c (ps_get_thread_area): Likewise. >> * gdb/gdbserver/linux-x86-low.c (ps_get_thread_area): Likewise. >> * gdb/gdbserver/linux-xtensa-low.c (ps_get_thread_area): Likewise. >> * gdb/i386-linux-nat.c (ps_get_thread_area): Likewise. >> * gdb/m68klinux-nat.c (ps_get_thread_area): Likewise. >> * gdb/mips-linux-nat.c (ps_get_thread_area): Likewise. >> * gdb/nat/aarch64-linux.c (aarch64_ps_get_thread_area): Likewise. >> * gdb/nat/aarch64-linux.h (aarch64_ps_get_thread_area): Likewise. >> * gdb/xtensa-linux-nat.c (ps_get_thread_area): Likewise. > > OK, but please move the ChangeLog entries to the correct ChangeLog files, > and make the entry paths be relative to the corresponding ChangeLog file. > gdbserver changes go to gdb/gdbserver/ChangeLog, the rest goes > to gdb/ChangeLog. I forgot about the project distinctions, I will resend a proper one with corrected ChangeLogs entries. I will need someone to push it for me, since I think I do not have write access to binutils git.