From: Simon Marchi <simon.marchi@polymtl.ca>
To: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 13/19] gdb: move ada-exp-parser.y's support code to ada-exp-parser.c
Date: Thu, 1 Oct 2026 14:00:04 -0400 [thread overview]
Message-ID: <31cf4b16-fd68-49b0-91d4-fbdd696d4142@polymtl.ca> (raw)
In-Reply-To: <20260908112802.3630e0dc@f44-mesa-1>
On 9/8/26 2:28 PM, Kevin Buettner wrote:
> On Sat, 5 Sep 2026 00:23:16 -0400
> simon.marchi@polymtl.ca wrote:
>
>> diff --git a/gdb/ada-exp-parser.y b/gdb/ada-exp-parser.y
>> index 433293d22ad9..0a629f82cc86 100644
>> --- a/gdb/ada-exp-parser.y
>> +++ b/gdb/ada-exp-parser.y
>> @@ -40,412 +40,19 @@
>> #include "value.h"
>> #include "parser-defs.h"
>> #include "language.h"
>> +#include "ada-exp-parser.h"
>> #include "ada-lang.h"
>> #include "frame.h"
>> #include "block.h"
>> #include "ada-exp.h"
>> +#include "ada-exp-parser.h"
>> #include "cli/cli-style.h"
>
> Nit: ada-exp-parser.h is included twice here. (Found by AI.)
>
> My AIs (GLM 5.3 Flash and Claude Opus for detailed patch review)
> checked the rest of the series, including build and regression
> testing. No problems found except for the above nit.
>
> You still have my approval for the entire series:
>
> Approved-By: Kevin Buettner <kevinb@redhat.com>
Thanks, I fixed that and I will push the series shortly, after doing a
quick build test.
Simon
next prev parent reply other threads:[~2026-10-01 18:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 4:23 [PATCH v2 00/19] Move C++ support code out of .y files simon.marchi
2026-09-05 4:23 ` [PATCH v2 01/19] gdb/ada-exp-parser: remove name_info struct simon.marchi
2026-09-05 4:23 ` [PATCH v2 02/19] gdb: replace parse_type macros with functions simon.marchi
2026-09-05 4:23 ` [PATCH v2 03/19] gdb: suffix flex/bison output files with -gen.c simon.marchi
2026-09-05 4:23 ` [PATCH v2 04/19] gdb: remove YY_NULL to YY_NULLPTR substitution simon.marchi
2026-09-05 4:23 ` [PATCH v2 05/19] gdb: move parser output post-processing to a script simon.marchi
2026-09-05 4:23 ` [PATCH v2 06/19] gdb: let the parser and lexer generators prefix their symbols simon.marchi
2026-09-05 4:23 ` [PATCH v2 07/19] gdb: separate cp-name-parser's symbol prefix with an underscore simon.marchi
2026-09-05 4:23 ` [PATCH v2 08/19] gdb: make $(YACC) and $(FLEX) generate headers simon.marchi
2026-09-05 4:23 ` [PATCH v2 09/19] gdb: add check for stale build generated files simon.marchi
2026-09-05 4:23 ` [PATCH v2 10/19] gdb: move cp-name-parser.y's support code to cp-name-parser.c simon.marchi
2026-09-05 4:23 ` [PATCH v2 11/19] gdb: rename LANG-exp.y to LANG-exp-parser.y simon.marchi
2026-09-05 4:23 ` [PATCH v2 12/19] gdb: move c-exp-parser.y's support code to c-exp-parser.c simon.marchi
2026-09-05 4:23 ` [PATCH v2 13/19] gdb: move ada-exp-parser.y's support code to ada-exp-parser.c simon.marchi
2026-09-08 18:28 ` Kevin Buettner
2026-10-01 18:00 ` Simon Marchi [this message]
2026-09-05 4:23 ` [PATCH v2 14/19] gdb: move d-exp-parser.y's support code to d-exp-parser.c simon.marchi
2026-09-05 4:23 ` [PATCH v2 15/19] gdb: move f-exp-parser.y's support code to f-exp-parser.c simon.marchi
2026-09-05 4:23 ` [PATCH v2 16/19] gdb: move go-exp-parser.y's support code to go-exp-parser.c simon.marchi
2026-09-05 4:23 ` [PATCH v2 17/19] gdb: move m2-exp-parser.y's support code to m2-exp-parser.c simon.marchi
2026-09-05 4:23 ` [PATCH v2 18/19] gdb: move p-exp-parser.y's support code to p-exp-parser.c simon.marchi
2026-09-05 4:23 ` [PATCH v2 19/19] gdb: honor "set debug parser" in the Modula-2 and Pascal parsers simon.marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31cf4b16-fd68-49b0-91d4-fbdd696d4142@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox