From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id u06ZBMafvmoa3SQAWB0awg (envelope-from ) for ; Thu, 01 Oct 2026 14:00:38 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=ZjTgYpxJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EE8051E04F; Thu, 01 Oct 2026 14:00:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 706531E047 for ; Thu, 01 Oct 2026 14:00:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E84E4BB3BB6 for ; Thu, 1 Oct 2026 18:00:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E84E4BB3BB6 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=ZjTgYpxJ Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 49AB54BAE7C8 for ; Thu, 1 Oct 2026 18:00:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 49AB54BAE7C8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 49AB54BAE7C8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790877613; cv=none; b=nHofnZlph66QaZ6sEVrS8MyOo5yGfIQYYHLtm1rqE43rzR4d1PqrFM+BPEs1aGx8OQxPweMEDc+qZAQlljpFdeUN1b/ogP1pA3AFRLA0Fo5pOjKBEEY5mJYdnI2Fc1RuOy19la3eJfTOUrCocJc9fUPodximPqxTp6mlhhgFH2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790877613; c=relaxed/simple; bh=Q3xONX2c1h1WXJ6xp2RdDbLGl3jMU40P4lKsJi+zwRw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ZQiad45MVGkhMoKCl4oICyO3rSdT71tBcLXh+5h0vOYxEjXaHRrwSfJCcmNvz6zCfCQtxrAPp44lE1HBoSrwcp1AbsY52Ox4NfAWiPuOlfQHPi7p4N/DK/pDPjGc81xw6dtA5Q9uKLHfnQ/BEPrkPt9kiggJqTfpAyNv0QVk5/k= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=ZjTgYpxJ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 49AB54BAE7C8 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 691I06V0212046 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Oct 2026 14:00:11 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 691I06V0212046 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1790877611; bh=8+RTVti44DZ+96TkFWkJj91PLhOeLD6eVmSIv84AHaI=; h=Date:Subject:To:From:In-Reply-To:From; b=ZjTgYpxJV1aSCpE1bZpqbLiujjVxwSf7S8I86Dinkz/86YS8SlwEDDpW9TQ0s2s4I +GyF3ZwBh/CH/WrS9li5imdsfvt+M4O8AniIJt3CYuGT+oswd/zKS0bKOFycIZ9D95 Eomt4j2JDxuIn/Xo+7W+WQRhi3hCd8bq/d/olEtjFbqJLTdhSM+44JnyrilIFwMkuJ Xe6eE3vK7PME+fgdsU6LqjAC5S6FRoZSn8c4Eyde70QoUrLvssPCJ8SI3jBESJa6AM kIQo6fi7NL5+JmFfT7iGGuz5Xa3MlfTxDfNQSmRtJDQhTAV04VWGBn6IerBwXxR2TW 30pD98dO+m1AQ== Received: by simark.ca (Postfix) id 084181E047; Thu, 01 Oct 2026 14:00:05 -0400 (EDT) Message-ID: <31cf4b16-fd68-49b0-91d4-fbdd696d4142@polymtl.ca> Date: Thu, 1 Oct 2026 14:00:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/19] gdb: move ada-exp-parser.y's support code to ada-exp-parser.c To: Kevin Buettner , gdb-patches@sourceware.org References: <20260905042353.1702204-1-simon.marchi@polymtl.ca> <20260905042353.1702204-14-simon.marchi@polymtl.ca> <20260908112802.3630e0dc@f44-mesa-1> Content-Language: fr From: Simon Marchi In-Reply-To: <20260908112802.3630e0dc@f44-mesa-1> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 1 Oct 2026 18:00:06 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/8/26 2:28 PM, Kevin Buettner wrote: > On Sat, 5 Sep 2026 00:23:16 -0400 > simon.marchi@polymtl.ca wrote: > >> diff --git a/gdb/ada-exp-parser.y b/gdb/ada-exp-parser.y >> index 433293d22ad9..0a629f82cc86 100644 >> --- a/gdb/ada-exp-parser.y >> +++ b/gdb/ada-exp-parser.y >> @@ -40,412 +40,19 @@ >> #include "value.h" >> #include "parser-defs.h" >> #include "language.h" >> +#include "ada-exp-parser.h" >> #include "ada-lang.h" >> #include "frame.h" >> #include "block.h" >> #include "ada-exp.h" >> +#include "ada-exp-parser.h" >> #include "cli/cli-style.h" > > Nit: ada-exp-parser.h is included twice here. (Found by AI.) > > My AIs (GLM 5.3 Flash and Claude Opus for detailed patch review) > checked the rest of the series, including build and regression > testing. No problems found except for the above nit. > > You still have my approval for the entire series: > > Approved-By: Kevin Buettner Thanks, I fixed that and I will push the series shortly, after doing a quick build test. Simon