Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Lancelot SIX <Lancelot.Six@amd.com>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Cc: Tankut Baris Aktemur <tankutbaris.aktemur@amd.com>,
	Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdb/solib-rocm: add support for file URI on Windows
Date: Wed, 27 May 2026 11:33:21 +0100	[thread overview]
Message-ID: <313b4edc-1932-4dca-9598-d3c1707f22b6@amd.com> (raw)
In-Reply-To: <b8b47678-390d-4e6a-8541-2514ade70fe5@palves.net>

> I'd suggest rewording the comment to something like:
> 
>    /* A Windows absolute file path is encoded in a file: URI with a leading
>       "/" before the drive letter: "file:///C:/Users/foo/bar".  See grammar in
>       RFC 8089 Section 2, the path-absolute production requires the leading "/".
>       'path-absolute' is defined by RFC 3986 Section 3.3.
>       After decoding, decoded_path would be "/C:/Users/foo/bar", which is not a
>       valid Windows path.  Drop the leading "/" as a normalization step.  */
> 
> Otherwise LGTM.
> 
> Approved-By: Pedro Alves <pedro@palves.net>
> 
> Thanks,
> Pedro Alves
> 

Thanks,

I updated the comment and pushed as 
d623dadc2c4ecd509359015ae5a1ac856ba89b05.

Best,
Lancelot.

      reply	other threads:[~2026-05-27 10:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 17:22 Lancelot SIX
2026-05-20 21:35 ` Pedro Alves
2026-05-27 10:33   ` Lancelot SIX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=313b4edc-1932-4dca-9598-d3c1707f22b6@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    --cc=simon.marchi@efficios.com \
    --cc=tankutbaris.aktemur@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox