From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ATewMZnIFmq/8h8AWB0awg (envelope-from ) for ; Wed, 27 May 2026 06:34:01 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=hGCFqSrA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C448E1E0A3; Wed, 27 May 2026 06:34:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C5C011E062 for ; Wed, 27 May 2026 06:34:00 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 317B84BA2E08 for ; Wed, 27 May 2026 10:34:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 317B84BA2E08 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=hGCFqSrA Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012014.outbound.protection.outlook.com [40.107.200.14]) by sourceware.org (Postfix) with ESMTPS id 573164BA2E08 for ; Wed, 27 May 2026 10:33:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 573164BA2E08 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 573164BA2E08 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=40.107.200.14 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1779878013; cv=pass; b=csqdUHO0T+sQ+xqXOn6MQvnnYcgY7/sSXz95ovzhkPeurExuJFdrWNoU1BZDPrWLtjEW/QtHduVPWNae9AgheKWkxaeiNSWawHGXW9pKzZVp/6rFCnS6suSNnhcpw8cDwMN3/9Nu5Hkr42HIyyH+lkdOdtV7MbZL45h1MhLNMbI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1779878013; c=relaxed/simple; bh=iTavC/fEk1s7USsfWXNMfm/hz69qkCIxAz40n0qR1QE=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=IntFI3VMI6rJPcDgxLMiE4zB835GMdVIMigOtatQ9ePxZsC3cX/47SUrnSxStDFRfJkusGyyJBcJHe2cj5RAMxkTuaa1kwVehut7oAQwDOTS/Z32xrSgPAEjD+PaAqjfxeHKM0d2n/U4ts85UYxmbQaAD7FLkWzhnl2ItKluJrg= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=hGCFqSrA DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 573164BA2E08 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G2G6ua8AaQS21OoHfkLiIz9XlbGpiQB7TSUQDxl/3Ov83HAlAsDCDz5uxUZqrvnLQB+DH6KdEokNc0QoSydF7GRt9PRG//W3z3aeNgTpUbGXtvwm2eocGkCzPGAkAjaFYZxsrmXO2R/d1fl0E3aVU9fD8fZL/QpUZDY0LDAX0sxeBE4fCpUo8oVmceSYOyQb4rkYaK3iLuyt9sP6wOiMSf2VAd2V2f2cduE3LrTegEav1k9raRKfYnUXGDz6wKG3hsDfUbc8cRfTYbM9fIlxeVLgJUBUsF5qtXOqacM0CTi5oF0fI+Pb5ER9Vv6A3bDblsdP7uKolP1sgjjA7kWhHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t4ULTIjc0BT0IHMvxe1El/v3XnC4bBV6aiVAyuQohQQ=; b=sAWoznMzn3wKiyXPHjVGQwBsXD7DtI5S5PO3hP1mMqN9nI3FmT3e+a1nh71799TtChLtiZs0k7Nq+j5JBiLcQMHRf0JHUv8i6VO4i54BGFjVszkn7DmvQyi2OAUoFeo5x+37DFr5iSFdtvjPEV8Kuw/qzyQZgdrEZ544heKoeu+w8WFn5ljI6qs4zoPYCt3JPcjChQ8svxd2URrVM50KmGeDIb7proTxwuNUIrA7aeAr3vG2bE9xsAgEnP5DayQveL9LPNPsVTxyb5s5ZpDnBHoySUqFt5rdf9boSLvbH8+FRUUiT3oyz6bhkK0LxoQQYP6/0rFgLqmfpuhymYdyJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t4ULTIjc0BT0IHMvxe1El/v3XnC4bBV6aiVAyuQohQQ=; b=hGCFqSrANQ6VoFklQmL6VvJuIfnXtfkHl9XcsE8ZDGseev/BncpKEd+14pGm2ugDzqndFuWR+Tce9gXSWGq7a0pmSyYWRvkoh70haY4uBw7mJu1yMBZBqixm20Gdre/yb1fEZw02nnoB8cU8Re1FFnXynT221gEvEGx8oc1ChHM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by PH7PR12MB6883.namprd12.prod.outlook.com (2603:10b6:510:1b9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.12; Wed, 27 May 2026 10:33:26 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3%5]) with mapi id 15.21.0071.011; Wed, 27 May 2026 10:33:26 +0000 Message-ID: <313b4edc-1932-4dca-9598-d3c1707f22b6@amd.com> Date: Wed, 27 May 2026 11:33:21 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/solib-rocm: add support for file URI on Windows To: Pedro Alves , gdb-patches@sourceware.org Cc: Tankut Baris Aktemur , Simon Marchi References: <20260520172256.629890-1-lancelot.six@amd.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0048.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::10) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|PH7PR12MB6883:EE_ X-MS-Office365-Filtering-Correlation-Id: b855961b-6e65-40f1-e4fc-08debbdb62b4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|18002099003|22082099003|11063799006|4143699003|3023799007|56012099006; X-Microsoft-Antispam-Message-Info: 7qO9S/VCfq67jpFBIgSSKtw3hfaJKD1n+4BCSmXtyUHiJnJEWMmFRBAQi1TAav5uVjhyUgz3wu/95Ei4X28BJ9F1VPy3ejj7fhx351MNF41jv+CkIlnm1DbeTfsy+uTBmGiVidR7/yC//JIFKN9OfPzDtQzuQuHZLzq4YTmnWLOsyMkhFa+CCleP4FT4rdoFbxJB49CcvO9NDGmqxwOdYomCBunlAtaIHoU5HdDusATydXuCafQGanCx00HOG9auhL+98hDODJ9vcgP8XarNS8ksbpQD+wd1LAne5jK7byVArcziQwURW8uF1OyIHN/GulMc1JnQ/FHe3GE5SXifHAIoeW9DYFS9eE9s2tOS3YTtYFsVrmv8VYqSsuEfIyRWyyDquLIc1G0D7Szi5P6Yk3qxn6EPhkS824LPkro0JG78r3ED9x5NFN2eY3WkvvM9YZd2BHCdE/bDDC8Q7UUV5U2gCD70fEKR7hBzzOpHRJqhKygV8O5TonP/CXebk8DmAld4kieAsNiEBEoELs9lA0F3XncztzApTJdmpDA3z1KxlN4f3CBQc5i3CuV0vtcoNwz9wHU891ZbZljdu2RPzJbNaSHPVrwvuHztmW71ANTJlztShdYTfYZNbYnTJGxleXOrHge10V6A63KfXOHTQKVUtbbPvwxVzS+hI0Sma+cSmi3VJDUWMD+1Qg22NWeE X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(18002099003)(22082099003)(11063799006)(4143699003)(3023799007)(56012099006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDV3dVpBWjlxcE9zU2JGS2dWS0tCZWNpM1IvelY2NkxrdEhoYVNhVjZ3QkFT?= =?utf-8?B?WjZoTm1mZzJVOW9sVmtBdm5IcWxaZnNmakR4bEJxZEY5N01NY0FDQVBoN29H?= =?utf-8?B?Q0lVMUZtUUR2NXl5OEh5TEZ5TTdwZjRBNUQ1a0grQ0lUS0dGeXRYeFd0RkNI?= =?utf-8?B?K3kzeTI4YXlDT0wwaHlMVXhmYjZzVkZkL0NTRXM4aC8ySmxMUWsrQjc4RUpS?= =?utf-8?B?eG1TNTZnN1d2Ky84UzVxLzBoMmJpNm1QQnRTQW9NaE4wNWVwRjJGZTAvUVht?= =?utf-8?B?Q2dJUWdTekRMb29La3ZZQVpEMnZ4R0NXbUN5QUg1MXgwbENRUExVeDlMQXRN?= =?utf-8?B?V2g1T2ZWZHJ0cTRZc0ZSRENRRnZOdkNINnMxeEhpa2NYYTBKZVh4Q054eks1?= =?utf-8?B?RVNCUFkwWXB5dEUrMEJEbEhNUi9DOUR6NmVQb3dZeURpUUh3dHNhZW9kYi93?= =?utf-8?B?bHVyaERabS9ZWFFoeU9VS0huRUlQcUZuMmV2bWUzc2ZiYitJMjV6d0pVamdU?= =?utf-8?B?MzRERjBhUTh0cGtHWVVDb29xQXpuUmJxenJoL3k3WHpDOWU3b2RIZ0JxeVkv?= =?utf-8?B?eFVGTEFNRjk3UEtjYTgxSWN4VGxUVUZ3aE1FamMxRFpHbjdUdS9ITnJMZGFq?= =?utf-8?B?ZmFlZjdHRkFTZHBVbFQxODIwTndmZGdoeE5NZkRqRmpETU02WVU0Z3BJYXJs?= =?utf-8?B?U2hTbEVBcGtIclVHbWk1ZnIwcjB6cGY0T3BnRzh4ZkFGVDJoOEMybndHdjdX?= =?utf-8?B?NTVoK0lkZUMzRWVsQi9qemZXNXd2MEI3c3NZY0pBSkZkOTRYU2tTbWtmUXQ1?= =?utf-8?B?QWxodmhZQVRGOWl3VGVLNXZkSDZvQk9tajdDVlZZb2gzd3JvSXRQUUhlRkV3?= =?utf-8?B?ZEpUNE54ZWpaZVhmeXlUdm1jaDRQRFIzQ215NUVzSjU5cmJCaW1nZm1BQkVI?= =?utf-8?B?YWxWTi90MzZRaW5pS0hwOUdtMW5LNGlEOHBacVdTbHFwRm5UVkMwMHlrV21v?= =?utf-8?B?V1orWWNOMkdMQm1mQVdUbGtiNUhpRWlKU25oeFhoQTgweGVBRHBTM0RpZDJy?= =?utf-8?B?L3hqZTI1ZmVGM2daZlBNVWUwK0FnTnFKS3R6QVBoTWtWUWtRUjBQbXZLdS9I?= =?utf-8?B?a1RPeFk4SFJJR3h5OG11RHBQcFVRRFJLdzVCRFdtbFRoWFkwQ0M5WC9lNWxx?= =?utf-8?B?RWFmUkptRTd0NnRxTEs5QW0ySXZvazl0MmM0Njlha0dqdVNBN0dKYThGNEF6?= =?utf-8?B?RE1CQTRuY1pydGFZckk1MVF6dnV4ZEVnTjNCc2h5YWZ5OWhyZWRtL3JydTRk?= =?utf-8?B?dm8yYkVzZ3ZaVHlySCtqaUVMQ3ZJQmdwMjJEQlpqZGJGSmEzUFptTmJ3cjhX?= =?utf-8?B?bTBmMkw5QW5mZzRWV0RUdWFPTm91VTN2bGk0a3hsZUVsdWs5WUh1QWNGb3R3?= =?utf-8?B?WmxuMnpiMlRCd1hPY0xUekdYZjRCTnZIcGltK0hmeC9nZTEyYjlVcHd1QXQ3?= =?utf-8?B?THNOYkpvL1pjaUVadktxYjd3UURYbzZLOW5qSG9Za2dTTGUzeGJydlA0NG5U?= =?utf-8?B?Nk9zeldkS3JTdk5NMThQWUd3YVRSVkpFblMwMmU5d25KdzlLRmZKUWFCWFY0?= =?utf-8?B?ODFOTVcxaDVSWDJqZGd0RTJWcy8vOEF5MkNlSkNSWmZNVTdlc0h0SWV4b1lU?= =?utf-8?B?emlGblZ6Rjg1ekRlZ2F1eFZ1RGNleGFmdnF3U1NiV3NmRkh4ZUNNMGdMTXA5?= =?utf-8?B?N2ZuU09YV2F0NnAvYXZVd2tUSndyNk8wYTNEM2RxTjQwREJHTUNFamU1MWxT?= =?utf-8?B?dDNBMUFTSitBUlFZM2xsTjJBN1VGT3V3WFVBcVpzT2kwWGdRMno4NG1pUFRF?= =?utf-8?B?d3JSbDRmSERmYmlhbXh0TXlldEkvYUpINmpqVHcxdVJkTkNqc2lMbmF3NFhO?= =?utf-8?B?cWY5MldKcExwcXJhay9KMzhwWEo1SjMrTklacGU0R1FQcG5ZbzNXUUh5UjNs?= =?utf-8?B?SXV4Yld2Zk9Na3pKUVJHY0pWZHJUYm9wdGJWN3lNT1hYVTFUVkhBNEpTcE1L?= =?utf-8?B?YnhSYWhpOHlWeUNBM3dhMGJmSWI1LzlZZmVTcW5UcmN0Q29DQS9DWlNaa0pK?= =?utf-8?B?NDVNYmVpZXBQODNwd0UwSDFzREg0QUd2SU11UVM3OWthYWp3Sm5qSmM0ekdO?= =?utf-8?B?ZXFtSllIdjNNSEd2MDRpN0U2QjdnREliMVllNzRsaGxQUUJJbTAxTzh5S2FM?= =?utf-8?B?dkpTRmpGYWNZekwrb09tMEFFSVg2NFZodUNkNENrVmoxd29ZbkJRblI0Q1Vz?= =?utf-8?Q?mAcuRH9Qjstkz2H5uq?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b855961b-6e65-40f1-e4fc-08debbdb62b4 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2026 10:33:26.5569 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J511xOGcElchlkJgSYEVGZ6dJAFLAeCi0kjwpg4RtE5QCUjh+5YEriUq8rwUBeub+U4fHu/yq3n5OSqtBc4FEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6883 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > I'd suggest rewording the comment to something like: > > /* A Windows absolute file path is encoded in a file: URI with a leading > "/" before the drive letter: "file:///C:/Users/foo/bar". See grammar in > RFC 8089 Section 2, the path-absolute production requires the leading "/". > 'path-absolute' is defined by RFC 3986 Section 3.3. > After decoding, decoded_path would be "/C:/Users/foo/bar", which is not a > valid Windows path. Drop the leading "/" as a normalization step. */ > > Otherwise LGTM. > > Approved-By: Pedro Alves > > Thanks, > Pedro Alves > Thanks, I updated the comment and pushed as d623dadc2c4ecd509359015ae5a1ac856ba89b05. Best, Lancelot.