Re: [RFA] Remove make_cleanup_restore_target_terminal

[Pedro Alves <palves@redhat.com>]

On 09/20/2017 05:04 PM, Tom Tromey wrote:
> This removes make_cleanup_restore_target_terminal and generally
> C++-ifies target terminal handling.  It changes all target_terminal_*
> functions to be static members of a new target_terminal class and
> changes the cleanup to be a scoped_* class.
> make_cleanup_override_quit_handler is also removed in favor of simply
> using scoped_restore.
> 
> Note that there are some files in this patch that I could not compile.
> Considering that some of the rewrites were automated, and that none of
> these files involed cleanups, I feel that this is relatively safe.
> 
> Regression tested by the buildbot.

Looks fine to me.

> +
> +  static terminal_state terminal_state;//  = terminal_is_ours;
> +};
>

Stale comment?

Thanks,
Pedro Alves