From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65588 invoked by alias); 20 Sep 2017 16:21:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65576 invoked by uid 89); 20 Sep 2017 16:21:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:833 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Sep 2017 16:21:10 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 52E0C80465; Wed, 20 Sep 2017 16:21:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 52E0C80465 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E05D5D97D; Wed, 20 Sep 2017 16:21:08 +0000 (UTC) Subject: Re: [RFA] Remove make_cleanup_restore_target_terminal To: Tom Tromey , gdb-patches@sourceware.org References: <20170920160404.20543-1-tom@tromey.com> From: Pedro Alves Message-ID: <313985bd-111f-cea6-7b13-96217ee450cc@redhat.com> Date: Wed, 20 Sep 2017 16:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170920160404.20543-1-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00502.txt.bz2 On 09/20/2017 05:04 PM, Tom Tromey wrote: > This removes make_cleanup_restore_target_terminal and generally > C++-ifies target terminal handling. It changes all target_terminal_* > functions to be static members of a new target_terminal class and > changes the cleanup to be a scoped_* class. > make_cleanup_override_quit_handler is also removed in favor of simply > using scoped_restore. > > Note that there are some files in this patch that I could not compile. > Considering that some of the rewrites were automated, and that none of > these files involed cleanups, I feel that this is relatively safe. > > Regression tested by the buildbot. Looks fine to me. > + > + static terminal_state terminal_state;// = terminal_is_ours; > +}; > Stale comment? Thanks, Pedro Alves